* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
@ 2011-01-11 7:29 Liu Ying
2011-01-26 1:52 ` Liu Ying-B17645
2011-01-26 23:28 ` Anatolij Gustschin
0 siblings, 2 replies; 6+ messages in thread
From: Liu Ying @ 2011-01-11 7:29 UTC (permalink / raw)
To: u-boot
CONFIG_SPLASH_SCREEN_ALIGN makes uboot support display
offset for splashimage. The framebuffer writing address
should be calculated according to different kinds of
framebuffer pixel format, i.e., bits per pixel value.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
common/lcd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/lcd.c b/common/lcd.c
index d854c21..0555ab4 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -731,7 +731,7 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y)
bmap = (uchar *)bmp + le32_to_cpu (bmp->header.data_offset);
fb = (uchar *) (lcd_base +
- (y + height - 1) * lcd_line_length + x);
+ (y + height - 1) * lcd_line_length + x * bpix / 8);
switch (bmp_bpix) {
case 1: /* pass through */
--
1.6.3.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
2011-01-11 7:29 [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset Liu Ying
@ 2011-01-26 1:52 ` Liu Ying-B17645
2011-01-26 7:40 ` Wolfgang Denk
2011-01-26 22:04 ` Anatolij Gustschin
2011-01-26 23:28 ` Anatolij Gustschin
1 sibling, 2 replies; 6+ messages in thread
From: Liu Ying-B17645 @ 2011-01-26 1:52 UTC (permalink / raw)
To: u-boot
Hello,
I sent the following patch for view about 2 weeks ago and haven't got any comment till now.
Could anyone help to give comments? Thanks.
Best Regards,
Liu Ying
-----Original Message-----
From: Liu Ying-B17645
Sent: Tuesday, January 11, 2011 3:30 PM
To: u-boot at lists.denx.de
Cc: Liu Ying-B17645
Subject: [U-Boot][PATCH 1/1] lcd: align fb writing address for horizontal display offset
CONFIG_SPLASH_SCREEN_ALIGN makes uboot support display offset for splashimage. The framebuffer writing address should be calculated according to different kinds of framebuffer pixel format, i.e., bits per pixel value.
Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
common/lcd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/common/lcd.c b/common/lcd.c index d854c21..0555ab4 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -731,7 +731,7 @@ int lcd_display_bitmap(ulong bmp_image, int x, int y)
bmap = (uchar *)bmp + le32_to_cpu (bmp->header.data_offset);
fb = (uchar *) (lcd_base +
- (y + height - 1) * lcd_line_length + x);
+ (y + height - 1) * lcd_line_length + x * bpix / 8);
switch (bmp_bpix) {
case 1: /* pass through */
--
1.6.3.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
2011-01-26 1:52 ` Liu Ying-B17645
@ 2011-01-26 7:40 ` Wolfgang Denk
2011-01-26 22:04 ` Anatolij Gustschin
1 sibling, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2011-01-26 7:40 UTC (permalink / raw)
To: u-boot
Dear Liu Ying-B17645,
In message <D62B998DB8EFB547B4D75C9E57658A7F0BED86@039-SN1MPN1-006.039d.mgd.msft.net> you wrote:
> Hello,
>
> I sent the following patch for view about 2 weeks ago and haven't got any c=
> omment till now.
> Could anyone help to give comments? Thanks.
It would definitely help if you put the responsible custodian on Cc:
[Done now.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A man is not complete until he is married -- then he is finished.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
2011-01-26 1:52 ` Liu Ying-B17645
2011-01-26 7:40 ` Wolfgang Denk
@ 2011-01-26 22:04 ` Anatolij Gustschin
1 sibling, 0 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2011-01-26 22:04 UTC (permalink / raw)
To: u-boot
Hello,
On Wed, 26 Jan 2011 01:52:33 +0000
Liu Ying-B17645 <B17645@freescale.com> wrote:
> Hello,
>
> I sent the following patch for view about 2 weeks ago and haven't got any comment till now.
> Could anyone help to give comments? Thanks.
Thanks! Your patch is delegated to me and is currently under review,
please see [1]. Sorry it takes so long, I'm quite busy now, but I'll
have a look at it soon. Please put me on Cc: next time when
submitting video related patches, it should help.
Best regards,
Anatolij
[1] http://patchwork.ozlabs.org/patch/78285/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
2011-01-11 7:29 [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset Liu Ying
2011-01-26 1:52 ` Liu Ying-B17645
@ 2011-01-26 23:28 ` Anatolij Gustschin
2011-01-27 2:05 ` Liu Ying-B17645
1 sibling, 1 reply; 6+ messages in thread
From: Anatolij Gustschin @ 2011-01-26 23:28 UTC (permalink / raw)
To: u-boot
Hello,
On Tue, 11 Jan 2011 15:29:58 +0800
Liu Ying <Ying.Liu@freescale.com> wrote:
> CONFIG_SPLASH_SCREEN_ALIGN makes uboot support display
> offset for splashimage. The framebuffer writing address
> should be calculated according to different kinds of
> framebuffer pixel format, i.e., bits per pixel value.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> common/lcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot-video/master. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
2011-01-26 23:28 ` Anatolij Gustschin
@ 2011-01-27 2:05 ` Liu Ying-B17645
0 siblings, 0 replies; 6+ messages in thread
From: Liu Ying-B17645 @ 2011-01-27 2:05 UTC (permalink / raw)
To: u-boot
Hello, Anatolij,
Thanks for your review!
Best Regards,
Liu Ying
-----Original Message-----
From: Anatolij Gustschin [mailto:agust at denx.de]
Sent: Thursday, January 27, 2011 7:29 AM
To: Liu Ying-B17645
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset
Hello,
On Tue, 11 Jan 2011 15:29:58 +0800
Liu Ying <Ying.Liu@freescale.com> wrote:
> CONFIG_SPLASH_SCREEN_ALIGN makes uboot support display offset for
> splashimage. The framebuffer writing address should be calculated
> according to different kinds of framebuffer pixel format, i.e., bits
> per pixel value.
>
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> common/lcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied to u-boot-video/master. Thanks!
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-27 2:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-11 7:29 [U-Boot] [PATCH 1/1] lcd: align fb writing address for horizontal display offset Liu Ying
2011-01-26 1:52 ` Liu Ying-B17645
2011-01-26 7:40 ` Wolfgang Denk
2011-01-26 22:04 ` Anatolij Gustschin
2011-01-26 23:28 ` Anatolij Gustschin
2011-01-27 2:05 ` Liu Ying-B17645
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.