From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/4] Makefile: generate CMake toolchain-file in $(O)
Date: Wed, 26 Jan 2011 08:47:48 +0100 [thread overview]
Message-ID: <20110126084748.5b5338f3@surf> (raw)
In-Reply-To: <AANLkTinED=7r462NdPQB7USDn3BxDotAt5c5n_rP7r=r@mail.gmail.com>
On Wed, 26 Jan 2011 01:33:38 +0100
Bj?rn Forsman <bjorn.forsman@gmail.com> wrote:
> > Could you also add:
> >
> > + ? ? ? set(ENV{PKG_CONFIG_SYSROOT_DIR} $(STAGING_DIR))\n\
> >
> > This is needed to get CMake pkg-config module to work properly.
>
> Thanks for the tip.
You're welcome. Thanks for doing this work in the first place.
> > I am not entirely happy with the name/location of the CMake
> > toolchain file, but that's something we can sort out later.
>
> Or now, if you want :-) I'm open for suggestions.
I don't have suggestions at the moment. It's related to the future SDK
thing, which isn't completely well-defined at the moment. I'd say let's
keep it how it is for now, unless someone comes up with a better
location/name. We can always change it later on when we have a clearer
idea of what this SDK thing will look like.
> > So, once this change is done, your patch gets my:
> >
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> Great!
>
> By the way, how are 'acked-by's handled? Do I add them to every patch
> in the next series?
Yes, exactly.
Thanks again!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-01-26 7:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-15 20:53 [Buildroot] [PATCH v2 0/4] Introducing CMAKETARGETS infrastructure Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 1/4] Makefile: generate CMake toolchain-file in $(O) Bjørn Forsman
2011-01-25 23:21 ` Thomas Petazzoni
2011-01-26 0:33 ` Bjørn Forsman
2011-01-26 7:47 ` Thomas Petazzoni [this message]
2011-01-15 20:53 ` [Buildroot] [PATCH v2 2/4] Add CMAKETARGETS infrastructure for CMake packages Bjørn Forsman
2011-01-23 13:30 ` Samuel Martin
2011-01-25 23:25 ` Thomas Petazzoni
2011-01-26 0:39 ` Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 3/4] doc: add CMAKETARGETS documentation Bjørn Forsman
2011-01-15 20:53 ` [Buildroot] [PATCH v2 4/4] cdrkit: convert to CMAKETARGETS infrastructure Bjørn Forsman
2011-01-23 13:30 ` Samuel Martin
2011-01-23 14:42 ` Bjørn Forsman
2011-01-25 23:26 ` Thomas Petazzoni
2011-01-26 8:43 ` Thomas Petazzoni
2011-01-26 9:56 ` Bjørn Forsman
2011-01-22 11:54 ` [Buildroot] [PATCH v2 0/4] Introducing " Bjørn Forsman
2011-01-24 17:16 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126084748.5b5338f3@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.