From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/4] ASoC: Add optional pointer to machine audio routes to snd_soc_card
Date: Wed, 26 Jan 2011 13:35:22 +0000 [thread overview]
Message-ID: <20110126133522.GC8501@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1296043097-11720-2-git-send-email-jhnikula@gmail.com>
On Wed, Jan 26, 2011 at 01:58:15PM +0200, Jarkko Nikula wrote:
> + /*
> + * use the last codec and dapm context of it when setting up
> + * the common audio map
> + */
> + codec = list_first_entry(&card->codec_dev_list,
> + struct snd_soc_codec, card_list);
> + temp = codec->name_prefix;
> + codec->name_prefix = NULL;
> + ret = snd_soc_dapm_add_routes(&codec->dapm,
> + card->route, card->num_routes);
Rather than faff around like this it seems we should just bite the
bullet and add a DAPM context for the card.
Probably also worth doing the same thing as this for widgets - the
combination of these two would eliminate almost all machine init()
functions.
next prev parent reply other threads:[~2011-01-26 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:58 [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
2011-01-26 11:58 ` [PATCH 2/4] ASoC: Add optional pointer to machine audio routes to snd_soc_card Jarkko Nikula
2011-01-26 13:35 ` Mark Brown [this message]
2011-01-26 11:58 ` [PATCH 3/4] ASoC: Add optional pointer to codec interconnects to snd_soc_codec_driver Jarkko Nikula
2011-01-26 13:41 ` Mark Brown
2011-01-26 11:58 ` [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration Jarkko Nikula
2011-01-26 13:28 ` Mark Brown
2011-01-26 13:41 ` Jarkko Nikula
2011-01-27 6:57 ` Peter Ujfalusi
2011-01-27 7:21 ` Jarkko Nikula
2011-01-27 9:58 ` Mark Brown
2011-01-26 14:28 ` [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126133522.GC8501@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.