From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration
Date: Thu, 27 Jan 2011 09:21:16 +0200 [thread overview]
Message-ID: <20110127092116.e29f5cb1.jhnikula@gmail.com> (raw)
In-Reply-To: <4D411745.4070307@nokia.com>
On Thu, 27 Jan 2011 08:57:09 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> On 01/26/11 13:58, ext Jarkko Nikula wrote:
> > These codec drivers have only single interconnect map so these can be
> > switched to use soc-core based interconnect registration.
> >
> > This simplifies those codecs that check the return value of
> > snd_soc_dapm_add_routes and adds a failure path to those that don't.
>
> I might be missing something, but the only benefit of the 3+4 patch is
> actually the failure check for the snd_soc_dapm_add_routes, which was
> not done for most of the codecs, but now it is done in the core.
> On the other hand, now we always have one check for the
> codec->driver->route in soc_probe_codec.
> I don't see how these actually simplifies the codec drivers.
> We had a single snd_soc_dapm_add_routes call before the patches, now we
> have two fields to fill in snd_soc_codec_driver...
>
Yeah, simplification comes only if a driver is checking the return value
what most are not doing currently.
Another issue that came to my mind if some drivers need to add
additional interconnects later then there's basically need to revert
the 4/4 for those codecs. However, I don't think there are many codecs
that will do that.
--
Jarkko
next prev parent reply other threads:[~2011-01-27 7:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 11:58 [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
2011-01-26 11:58 ` [PATCH 2/4] ASoC: Add optional pointer to machine audio routes to snd_soc_card Jarkko Nikula
2011-01-26 13:35 ` Mark Brown
2011-01-26 11:58 ` [PATCH 3/4] ASoC: Add optional pointer to codec interconnects to snd_soc_codec_driver Jarkko Nikula
2011-01-26 13:41 ` Mark Brown
2011-01-26 11:58 ` [PATCH 4/4] ASoC: Convert bunch of codecs to use soc-core interconnect registration Jarkko Nikula
2011-01-26 13:28 ` Mark Brown
2011-01-26 13:41 ` Jarkko Nikula
2011-01-27 6:57 ` Peter Ujfalusi
2011-01-27 7:21 ` Jarkko Nikula [this message]
2011-01-27 9:58 ` Mark Brown
2011-01-26 14:28 ` [PATCH 1/4] ASoC: soc-core: Increment codec and platform driver refcounts before probing Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127092116.e29f5cb1.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.