From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/8 v3] P1021: add P1021MDS board support
Date: Fri, 28 Jan 2011 13:13:59 -0600 [thread overview]
Message-ID: <20110128131359.77bbfb1a@udp111988uds.am.freescale.net> (raw)
In-Reply-To: <AANLkTin2dxhLWWDX4CLPM=SP3SpjxecC==Zx4KowMrSx@mail.gmail.com>
On Fri, 28 Jan 2011 13:06:28 -0600
Timur Tabi <timur@freescale.com> wrote:
> > +void putc(char c)
> > +{
> > + ? ? ? if (c == '\n')
> > + ? ? ? ? ? ? ? NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, '\r');
> > +
> > + ? ? ? NS16550_putc((NS16550_t)CONFIG_SYS_NS16550_COM1, c);
> > +}
> > +
> > +void puts(const char *str)
> > +{
> > + ? ? ? while (*str)
> > + ? ? ? ? ? ? ? putc(*str++);
> > +}
>
> These look like functions that shouldn't be in board-specific code.
That's been established practice in the SPL board files so far, though
I suppose it could be factored out to its own file.
-Scott
next prev parent reply other threads:[~2011-01-28 19:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 4:58 [U-Boot] [PATCH 3/8 v3] Introduce the Tertiary Program loader Haiying.Wang at freescale.com
2011-01-28 4:58 ` [U-Boot] [PATCH 4/8 v3] powerpc/85xx: add TPL support Haiying.Wang at freescale.com
2011-01-28 4:58 ` [U-Boot] [PATCH 5/8 v3] P1021: add P1021MDS board support Haiying.Wang at freescale.com
2011-01-28 14:49 ` Kumar Gala
2011-01-28 15:19 ` Haiying Wang
2011-01-28 19:06 ` Timur Tabi
2011-01-28 19:13 ` Scott Wood [this message]
2011-01-28 19:22 ` Haiying Wang
2011-01-28 19:24 ` Timur Tabi
2011-01-28 19:30 ` Haiying Wang
2011-01-28 4:58 ` [U-Boot] [PATCH 8/8 v3] p1021mds: add QE and UEC support Haiying.Wang at freescale.com
2011-01-28 4:58 ` [U-Boot] [PATCH 7/7] add gc-sections to TPL boot Haiying.Wang at freescale.com
2011-01-28 17:36 ` Scott Wood
2011-01-28 18:08 ` Haiying Wang
2011-01-28 18:21 ` Albert ARIBAUD
2011-01-28 18:30 ` Scott Wood
2011-01-28 18:46 ` Haiying Wang
2011-01-28 18:58 ` Scott Wood
2011-01-28 19:07 ` Haiying Wang
2011-01-28 19:12 ` Scott Wood
[not found] ` <1296190690-21146-3-git-send-email-Haiying.Wang@freescale.c om>
2011-01-28 10:02 ` [U-Boot] [PATCH 5/8 v3] P1021: add P1021MDS board support Fabian Cenedese
2011-01-28 14:43 ` Haiying Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128131359.77bbfb1a@udp111988uds.am.freescale.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.