[PATCH] crypto: mark ghash as fips_allowed

* [PATCH] crypto: mark ghash as fips_allowed
@ 2011-01-26 17:00 Jarod Wilson
  2011-01-29  4:14 ` Herbert Xu
  0 siblings, 1 reply; 2+ messages in thread
From: Jarod Wilson @ 2011-01-26 17:00 UTC (permalink / raw)
  To: linux-crypto; +Cc: Herbert Xu

A self-test failure in fips mode means a panic. Well, gcm(aes)
self-tests currently fail in fips mode, as gcm is dependent on ghash,
which semi-recently got self-test vectors added, but wasn't marked as a
fips_allowed algorithm. Because of gcm's dependence on what is now seen
as a non-fips_allowed algorithm, its self-tests refuse to run.
Previously, ghash got a pass in fips mode, due to the lack of any test
vectors at all, and thus gcm self-tests were able to run. After this
patch, a 'modprobe tcrypt mode=35' no longer panics in fips mode, and
successful self-test of gcm(aes) is reported.

Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
 crypto/testmgr.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 521fdb2..2854865 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -2077,6 +2077,7 @@ static const struct alg_test_desc alg_test_descs[] = {
 	}, {
 		.alg = "ghash",
 		.test = alg_test_hash,
+		.fips_allowed = 1,
 		.suite = {
 			.hash = {
 				.vecs = ghash_tv_template,
-- 
1.7.1

-- 
Jarod Wilson
jarod@redhat.com

^ permalink raw reply related	[flat|nested] 2+ messages in thread