All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain.patch removed from -mm tree
@ 2011-01-31 19:14 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2011-01-31 19:14 UTC (permalink / raw)
  To: dillowda, James.Bottomley, bharrosh, mm-commits


The patch titled
     scsi: include linux/scatterlist.h to pick up ARCH_HAS_SG_CHAIN
has been removed from the -mm tree.  Its filename was
     scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain.patch

This patch was dropped because it was merged into mainline or a subsystem tree

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: scsi: include linux/scatterlist.h to pick up ARCH_HAS_SG_CHAIN
From: David Dillow <dillowda@ornl.gov>

If the compiled object doesn't include linux/scatterlist.h before
scsi/scsi.h, it will get an incorrect definition of
SCSI_MAX_SG_CHAIN_SEGMENTS.

This fixes an issue I found while working on the SRP initiator, where
linux/scatterlist.h was being pulled in by scsi/scsi_device.h.  It's not
clear if I'm supposed to include linux/scatterlist.h myself, or if I'm
including the scsi headers in the wrong order.  It makes sense for me that
scsi.h would pickup the needed headers itself to prevent confusion.

Another option is to potentially get rid of the ARCH_HAS_SG_CHAIN define
as all archs have it save m68knommu.

Signed-off-by: David Dillow <dillowda@ornl.gov>
Cc: Boaz Harrosh <bharrosh@panasas.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/scsi/scsi.h |    1 +
 1 file changed, 1 insertion(+)

diff -puN include/scsi/scsi.h~scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain include/scsi/scsi.h
--- a/include/scsi/scsi.h~scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain
+++ a/include/scsi/scsi.h
@@ -9,6 +9,7 @@
 #define _SCSI_SCSI_H
 
 #include <linux/types.h>
+#include <linux/scatterlist.h>
 
 struct scsi_cmnd;
 
_

Patches currently in -mm which might be from dillowda@ornl.gov are

linux-next.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-01-31 19:14 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-31 19:14 [merged] scsi-include-linux-scatterlisth-to-pick-up-arch_has_sg_chain.patch removed from -mm tree akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.