All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional
@ 2011-01-31 17:12 Fabio Estevam
  2011-01-31 19:35 ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2011-01-31 17:12 UTC (permalink / raw)
  To: linux-arm-kernel

Fix UART1 IOMUX settings and configure UART1 to work with only RX/TX pins.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx53_evk.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c
index eba9df0..4ee9556 100644
--- a/arch/arm/mach-mx5/board-mx53_evk.c
+++ b/arch/arm/mach-mx5/board-mx53_evk.c
@@ -44,8 +44,6 @@
 static iomux_v3_cfg_t mx53_evk_pads[] = {
 	MX53_PAD_CSI0_DAT10__UART1_TXD_MUX,
 	MX53_PAD_CSI0_DAT11__UART1_RXD_MUX,
-	MX53_PAD_PATA_DIOW__UART1_TXD_MUX,
-	MX53_PAD_PATA_DMACK__UART1_RXD_MUX,
 
 	MX53_PAD_PATA_BUFFER_EN__UART2_RXD_MUX,
 	MX53_PAD_PATA_DMARQ__UART2_TXD_MUX,
@@ -72,7 +70,7 @@ static const struct imxuart_platform_data mx53_evk_uart_pdata __initconst = {
 
 static inline void mx53_evk_init_uart(void)
 {
-	imx53_add_imx_uart(0, &mx53_evk_uart_pdata);
+	imx53_add_imx_uart(0, NULL);
 	imx53_add_imx_uart(1, &mx53_evk_uart_pdata);
 	imx53_add_imx_uart(2, &mx53_evk_uart_pdata);
 }
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional
  2011-01-31 17:12 [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional Fabio Estevam
@ 2011-01-31 19:35 ` Uwe Kleine-König
  2011-01-31 19:53   ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2011-01-31 19:35 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Jan 31, 2011 at 03:12:54PM -0200, Fabio Estevam wrote:
> Fix UART1 IOMUX settings and configure UART1 to work with only RX/TX pins.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
I cannot see a difference to the patch you sent ~5h earlier. ??

Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional
  2011-01-31 19:35 ` Uwe Kleine-König
@ 2011-01-31 19:53   ` Fabio Estevam
  2011-01-31 20:25     ` Uwe Kleine-König
  0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2011-01-31 19:53 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Uwe,

On 1/31/2011 5:35 PM, Uwe Kleine-K?nig wrote:
> On Mon, Jan 31, 2011 at 03:12:54PM -0200, Fabio Estevam wrote:
>> Fix UART1 IOMUX settings and configure UART1 to work with only RX/TX pins.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> I cannot see a difference to the patch you sent ~5h earlier. ??

The first patch was targeted for MX53_SMD board. After having sent it I noticed that the MX53_EVK board also had the same issue, then I sent another one for fixing MX53_EVK console.

If you prefer I can combine the two patches into a single one.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional
  2011-01-31 19:53   ` Fabio Estevam
@ 2011-01-31 20:25     ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2011-01-31 20:25 UTC (permalink / raw)
  To: linux-arm-kernel

Hey Fabio,

On Mon, Jan 31, 2011 at 05:53:53PM -0200, Fabio Estevam wrote:
> > I cannot see a difference to the patch you sent ~5h earlier. ??
> 
> The first patch was targeted for MX53_SMD board. After having sent it
> I noticed that the MX53_EVK board also had the same issue, then I sent
> another one for fixing MX53_EVK console.
Ah, I see.

> If you prefer I can combine the two patches into a single one.
I don't care much.  I assume it's OK for Sascha as it is.

Best regards and sorry for bothering,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-01-31 20:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-31 17:12 [PATCH] ARM: mx5/board-mx53_evk.c: Make UART1 functional Fabio Estevam
2011-01-31 19:35 ` Uwe Kleine-König
2011-01-31 19:53   ` Fabio Estevam
2011-01-31 20:25     ` Uwe Kleine-König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.