All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, Michael J Wolf <mjwolf@us.ibm.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFC][PATCH 6/6] have smaps show transparent huge pages
Date: Mon, 31 Jan 2011 16:34:05 -0800	[thread overview]
Message-ID: <20110201003405.FC58B813@kernel> (raw)
In-Reply-To: <20110201003357.D6F0BE0D@kernel>


Now that the mere act of _looking_ at /proc/$pid/smaps will not
destroy transparent huge pages, tell how much of the VMA is
actually mapped with them.

This way, we can make sure that we're getting THPs where we
expect to see them.

Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---

 linux-2.6.git-dave/fs/proc/task_mmu.c |    4 ++++
 1 file changed, 4 insertions(+)

diff -puN fs/proc/task_mmu.c~teach-smaps-thp fs/proc/task_mmu.c
--- linux-2.6.git/fs/proc/task_mmu.c~teach-smaps-thp	2011-01-31 16:25:15.948685305 -0800
+++ linux-2.6.git-dave/fs/proc/task_mmu.c	2011-01-31 16:25:34.600671992 -0800
@@ -331,6 +331,7 @@ struct mem_size_stats {
 	unsigned long private_dirty;
 	unsigned long referenced;
 	unsigned long anonymous;
+	unsigned long anonymous_thp;
 	unsigned long swap;
 	u64 pss;
 };
@@ -394,6 +395,7 @@ static int smaps_pte_range(pmd_t *pmd, u
 			spin_lock(&walk->mm->page_table_lock);
 			goto normal_ptes;
 		}
+		mss->anonymous_thp += HPAGE_SIZE;
 		smaps_pte_entry(*(pte_t *)pmd, addr, HPAGE_SIZE, walk);
 		return 0;
 	}
@@ -438,6 +440,7 @@ static int show_smap(struct seq_file *m,
 		   "Private_Dirty:  %8lu kB\n"
 		   "Referenced:     %8lu kB\n"
 		   "Anonymous:      %8lu kB\n"
+		   "AnonHugePages:  %8lu kB\n"
 		   "Swap:           %8lu kB\n"
 		   "KernelPageSize: %8lu kB\n"
 		   "MMUPageSize:    %8lu kB\n"
@@ -451,6 +454,7 @@ static int show_smap(struct seq_file *m,
 		   mss.private_dirty >> 10,
 		   mss.referenced >> 10,
 		   mss.anonymous >> 10,
+		   mss.anonymous_thp >> 10,
 		   mss.swap >> 10,
 		   vma_kernel_pagesize(vma) >> 10,
 		   vma_mmu_pagesize(vma) >> 10,
_

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, Michael J Wolf <mjwolf@us.ibm.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Dave Hansen <dave@linux.vnet.ibm.com>
Subject: [RFC][PATCH 6/6] have smaps show transparent huge pages
Date: Mon, 31 Jan 2011 16:34:05 -0800	[thread overview]
Message-ID: <20110201003405.FC58B813@kernel> (raw)
In-Reply-To: <20110201003357.D6F0BE0D@kernel>


Now that the mere act of _looking_ at /proc/$pid/smaps will not
destroy transparent huge pages, tell how much of the VMA is
actually mapped with them.

This way, we can make sure that we're getting THPs where we
expect to see them.

Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
---

 linux-2.6.git-dave/fs/proc/task_mmu.c |    4 ++++
 1 file changed, 4 insertions(+)

diff -puN fs/proc/task_mmu.c~teach-smaps-thp fs/proc/task_mmu.c
--- linux-2.6.git/fs/proc/task_mmu.c~teach-smaps-thp	2011-01-31 16:25:15.948685305 -0800
+++ linux-2.6.git-dave/fs/proc/task_mmu.c	2011-01-31 16:25:34.600671992 -0800
@@ -331,6 +331,7 @@ struct mem_size_stats {
 	unsigned long private_dirty;
 	unsigned long referenced;
 	unsigned long anonymous;
+	unsigned long anonymous_thp;
 	unsigned long swap;
 	u64 pss;
 };
@@ -394,6 +395,7 @@ static int smaps_pte_range(pmd_t *pmd, u
 			spin_lock(&walk->mm->page_table_lock);
 			goto normal_ptes;
 		}
+		mss->anonymous_thp += HPAGE_SIZE;
 		smaps_pte_entry(*(pte_t *)pmd, addr, HPAGE_SIZE, walk);
 		return 0;
 	}
@@ -438,6 +440,7 @@ static int show_smap(struct seq_file *m,
 		   "Private_Dirty:  %8lu kB\n"
 		   "Referenced:     %8lu kB\n"
 		   "Anonymous:      %8lu kB\n"
+		   "AnonHugePages:  %8lu kB\n"
 		   "Swap:           %8lu kB\n"
 		   "KernelPageSize: %8lu kB\n"
 		   "MMUPageSize:    %8lu kB\n"
@@ -451,6 +454,7 @@ static int show_smap(struct seq_file *m,
 		   mss.private_dirty >> 10,
 		   mss.referenced >> 10,
 		   mss.anonymous >> 10,
+		   mss.anonymous_thp >> 10,
 		   mss.swap >> 10,
 		   vma_kernel_pagesize(vma) >> 10,
 		   vma_mmu_pagesize(vma) >> 10,
_

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2011-02-01  0:34 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01  0:33 [RFC][PATCH 0/6] more detailed per-process transparent hugepage statistics Dave Hansen
2011-02-01  0:33 ` Dave Hansen
2011-02-01  0:33 ` [RFC][PATCH 1/6] count transparent hugepage splits Dave Hansen
2011-02-01  0:33   ` Dave Hansen
2011-02-01  9:58   ` Johannes Weiner
2011-02-01  9:58     ` Johannes Weiner
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-04 21:18     ` Andrea Arcangeli
2011-02-04 21:18       ` Andrea Arcangeli
2011-02-04 21:28       ` Dave Hansen
2011-02-04 21:28         ` Dave Hansen
2011-02-01  0:33 ` [RFC][PATCH 2/6] pagewalk: only split huge pages when necessary Dave Hansen
2011-02-01  0:33   ` Dave Hansen
2011-02-01 10:04   ` Johannes Weiner
2011-02-01 10:04     ` Johannes Weiner
2011-02-01 15:03     ` Dave Hansen
2011-02-01 15:03       ` Dave Hansen
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-03 21:33     ` Dave Hansen
2011-02-03 21:33       ` Dave Hansen
2011-02-03 21:46       ` David Rientjes
2011-02-03 21:46         ` David Rientjes
2011-02-04 17:19         ` Dave Hansen
2011-02-04 17:19           ` Dave Hansen
2011-02-04 21:10           ` Andrea Arcangeli
2011-02-04 21:10             ` Andrea Arcangeli
2011-02-01  0:34 ` [RFC][PATCH 3/6] break out smaps_pte_entry() from smaps_pte_range() Dave Hansen
2011-02-01  0:34   ` Dave Hansen
2011-02-01 10:08   ` Johannes Weiner
2011-02-01 10:08     ` Johannes Weiner
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-03 21:40     ` Dave Hansen
2011-02-03 21:40       ` Dave Hansen
2011-02-01  0:34 ` [RFC][PATCH 4/6] pass pte size argument in to smaps_pte_entry() Dave Hansen
2011-02-01  0:34   ` Dave Hansen
2011-02-01 10:09   ` Johannes Weiner
2011-02-01 10:09     ` Johannes Weiner
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-01  0:34 ` [RFC][PATCH 5/6] teach smaps_pte_range() about THP pmds Dave Hansen
2011-02-01  0:34   ` Dave Hansen
2011-02-01 10:11   ` Johannes Weiner
2011-02-01 10:11     ` Johannes Weiner
2011-02-01 15:02     ` Dave Hansen
2011-02-01 15:02       ` Dave Hansen
2011-02-01 16:09       ` Andrea Arcangeli
2011-02-01 16:09         ` Andrea Arcangeli
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-03 21:34     ` Dave Hansen
2011-02-03 21:34       ` Dave Hansen
2011-02-01  0:34 ` Dave Hansen [this message]
2011-02-01  0:34   ` [RFC][PATCH 6/6] have smaps show transparent huge pages Dave Hansen
2011-02-01 10:12   ` Johannes Weiner
2011-02-01 10:12     ` Johannes Weiner
2011-02-03 21:22   ` David Rientjes
2011-02-03 21:22     ` David Rientjes
2011-02-01 15:38 ` [RFC][PATCH 0/6] more detailed per-process transparent hugepage statistics Andrea Arcangeli
2011-02-01 15:38   ` Andrea Arcangeli
2011-02-01 17:15   ` Dave Hansen
2011-02-01 17:15     ` Dave Hansen
2011-02-01 20:39     ` Andrea Arcangeli
2011-02-01 20:39       ` Andrea Arcangeli
2011-02-01 20:56       ` Dave Hansen
2011-02-01 20:56         ` Dave Hansen
2011-02-02  0:07         ` Andrea Arcangeli
2011-02-02  0:07           ` Andrea Arcangeli
2011-02-08 17:54           ` Dave Hansen
2011-02-08 17:54             ` Dave Hansen
2011-02-08 18:17             ` Andrea Arcangeli
2011-02-08 18:17               ` Andrea Arcangeli
2011-02-03 21:54 ` David Rientjes
2011-02-03 21:54   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201003405.FC58B813@kernel \
    --to=dave@linux.vnet.ibm.com \
    --cc=aarcange@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mjwolf@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.