* [PATCH] rotary_encoder: Use proper irqflags
@ 2011-02-02 21:29 Alexander Stein
2011-02-03 6:05 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2011-02-02 21:29 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Alexander Stein
IORESOURCE_IRQ_* is wrong for irq_request, use the correct IRQF_* instead.
Signed-off-by: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
---
drivers/input/misc/rotary_encoder.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
index 1f8e010..7e64d01 100644
--- a/drivers/input/misc/rotary_encoder.c
+++ b/drivers/input/misc/rotary_encoder.c
@@ -176,7 +176,7 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
/* request the IRQs */
err = request_irq(encoder->irq_a, &rotary_encoder_irq,
- IORESOURCE_IRQ_HIGHEDGE | IORESOURCE_IRQ_LOWEDGE,
+ IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
DRV_NAME, encoder);
if (err) {
dev_err(&pdev->dev, "unable to request IRQ %d\n",
@@ -185,7 +185,7 @@ static int __devinit rotary_encoder_probe(struct platform_device *pdev)
}
err = request_irq(encoder->irq_b, &rotary_encoder_irq,
- IORESOURCE_IRQ_HIGHEDGE | IORESOURCE_IRQ_LOWEDGE,
+ IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
DRV_NAME, encoder);
if (err) {
dev_err(&pdev->dev, "unable to request IRQ %d\n",
--
1.7.4.rc3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rotary_encoder: Use proper irqflags
2011-02-02 21:29 [PATCH] rotary_encoder: Use proper irqflags Alexander Stein
@ 2011-02-03 6:05 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-02-03 6:05 UTC (permalink / raw)
To: Alexander Stein; +Cc: linux-input
On Wed, Feb 02, 2011 at 10:29:29PM +0100, Alexander Stein wrote:
> IORESOURCE_IRQ_* is wrong for irq_request, use the correct IRQF_* instead.
>
> Signed-off-by: Alexander Stein <alexander.stein@informatik.tu-chemnitz.de>
Applied, thank you Alexander.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-03 6:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-02 21:29 [PATCH] rotary_encoder: Use proper irqflags Alexander Stein
2011-02-03 6:05 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.