USB: Gadget: COMPOSITE: Debug interface number

USB: Gadget: COMPOSITE: Debug interface number

[Jassi Brar]

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi,

The commit 'avoid access beyond array max length' incorrectly
compares w_index with MAX_CONFIG_INTERFACES. Whereas only
lower 8bits of w_index refer to the interface number.
So, use 'intf' rather than 'w_index' for comparison.

Thanks

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 1004 bytes --]

From: Jassi Brar <jassi.brar@samsung.com>
Date: Fri, 4 Feb 2011 17:46:06 +0900
Subject: [PATCH] USB: Gadget: COMPOSITE: Debug interface number

The commit 'avoid access beyond array max length' incorrectly
compares w_index with MAX_CONFIG_INTERFACES. Whereas only
lower 8bits of w_index refer to the interface number.
So, use 'intf' rather than 'w_index' for comparison.

Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
 drivers/usb/gadget/composite.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index 1ba4bef..e30da2c 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -928,7 +928,7 @@ unknown:
 		 */
 		switch (ctrl->bRequestType & USB_RECIP_MASK) {
 		case USB_RECIP_INTERFACE:
-			if (!cdev->config || w_index >= MAX_CONFIG_INTERFACES)
+			if (!cdev->config || intf >= MAX_CONFIG_INTERFACES)
 				break;
 			f = cdev->config->interface[intf];
 			break;
-- 
1.7.1

Re: USB: Gadget: COMPOSITE: Debug interface number

[Greg KH]

On Fri, Feb 04, 2011 at 06:50:27PM +0900, Jassi Brar wrote:
> Hi,
> 
> The commit 'avoid access beyond array max length' incorrectly
> compares w_index with MAX_CONFIG_INTERFACES. Whereas only
> lower 8bits of w_index refer to the interface number.
> So, use 'intf' rather than 'w_index' for comparison.

Why did you attach the patch in base64 mode?  Please fix your email
client to not do this and send it to me in a format that I can apply it
in.

Try using 'git send-email' instead.

thanks,

greg k-h

Re: USB: Gadget: COMPOSITE: Debug interface number

[Jassi Brar]

On Sat, Feb 5, 2011 at 4:58 AM, Greg KH <greg@kroah.com> wrote:
> On Fri, Feb 04, 2011 at 06:50:27PM +0900, Jassi Brar wrote:
>> Hi,
>>
>> The commit 'avoid access beyond array max length' incorrectly
>> compares w_index with MAX_CONFIG_INTERFACES. Whereas only
>> lower 8bits of w_index refer to the interface number.
>> So, use 'intf' rather than 'w_index' for comparison.
>
> Why did you attach the patch in base64 mode?  Please fix your email
> client to not do this and send it to me in a format that I can apply it
> in.
>
> Try using 'git send-email' instead.

I always use git send-email, only this time the network connectivity is down
and immediate fix out of sight due to long holiday season here. So, I had
to send it as an attachment.
Will resend next week by git send-email.

Thanks