All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch 0/4] UML: Convert irq_chips and use proper accessors
@ 2011-02-06 22:45 Thomas Gleixner
  2011-02-06 22:45 ` [patch 1/4] um: Remove stale irq_chip.end Thomas Gleixner
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Thomas Gleixner @ 2011-02-06 22:45 UTC (permalink / raw)
  To: LKML; +Cc: Jeff Dike

Convert the irq_chips to the new functions and use proper accessor
functions for irq_desc. Finally set GENERIC_HARDIRQS_NO_DEPRECATED

Thanks,

	tglx


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [patch 1/4] um: Remove stale irq_chip.end
  2011-02-06 22:45 [patch 0/4] UML: Convert irq_chips and use proper accessors Thomas Gleixner
@ 2011-02-06 22:45 ` Thomas Gleixner
  2011-02-14 18:39   ` [tip:um/irq] " tip-bot for Thomas Gleixner
  2011-02-06 22:45 ` [patch 2/4] um: Convert irq_chips to new functions Thomas Gleixner
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2011-02-06 22:45 UTC (permalink / raw)
  To: LKML; +Cc: Jeff Dike, Peter Zijlstra

[-- Attachment #1: um-remove-stale-irq_chip-end.patch --]
[-- Type: text/plain, Size: 815 bytes --]

irq_chip.end got obsolete with the remnoval of __do_IRQ().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <20110203004210.627778423@linutronix.de>
---
 arch/um/kernel/irq.c |    2 --
 1 file changed, 2 deletions(-)

Index: linux-next/arch/um/kernel/irq.c
===================================================================
--- linux-next.orig/arch/um/kernel/irq.c
+++ linux-next/arch/um/kernel/irq.c
@@ -374,7 +374,6 @@ static struct irq_chip normal_irq_type =
 	.disable = dummy,
 	.enable = dummy,
 	.ack = dummy,
-	.end = dummy
 };
 
 static struct irq_chip SIGVTALRM_irq_type = {
@@ -384,7 +383,6 @@ static struct irq_chip SIGVTALRM_irq_typ
 	.disable = dummy,
 	.enable = dummy,
 	.ack = dummy,
-	.end = dummy
 };
 
 void __init init_IRQ(void)



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [patch 2/4] um: Convert irq_chips to new functions
  2011-02-06 22:45 [patch 0/4] UML: Convert irq_chips and use proper accessors Thomas Gleixner
  2011-02-06 22:45 ` [patch 1/4] um: Remove stale irq_chip.end Thomas Gleixner
@ 2011-02-06 22:45 ` Thomas Gleixner
  2011-02-14 18:40   ` [tip:um/irq] " tip-bot for Thomas Gleixner
  2011-02-06 22:45 ` [patch 3/4] um: Use proper accessors in show_interrupts() Thomas Gleixner
  2011-02-06 22:45 ` [patch 4/4] um: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
  3 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2011-02-06 22:45 UTC (permalink / raw)
  To: LKML; +Cc: Jeff Dike

[-- Attachment #1: um-convert-irq-chips.patch --]
[-- Type: text/plain, Size: 1285 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/um/kernel/irq.c |   19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

Index: linux-next/arch/um/kernel/irq.c
===================================================================
--- linux-next.orig/arch/um/kernel/irq.c
+++ linux-next/arch/um/kernel/irq.c
@@ -360,10 +360,10 @@ EXPORT_SYMBOL(um_request_irq);
 EXPORT_SYMBOL(reactivate_fd);
 
 /*
- * irq_chip must define (startup || enable) &&
- * (shutdown || disable) && end
+ * irq_chip must define at least enable/disable and ack when
+ * the edge handler is used.
  */
-static void dummy(unsigned int irq)
+static void dummy(struct irq_data *d)
 {
 }
 
@@ -371,18 +371,17 @@ static void dummy(unsigned int irq)
 static struct irq_chip normal_irq_type = {
 	.name = "SIGIO",
 	.release = free_irq_by_irq_and_dev,
-	.disable = dummy,
-	.enable = dummy,
-	.ack = dummy,
+	.irq_disable = dummy,
+	.irq_enable = dummy,
+	.irq_ack = dummy,
 };
 
 static struct irq_chip SIGVTALRM_irq_type = {
 	.name = "SIGVTALRM",
 	.release = free_irq_by_irq_and_dev,
-	.shutdown = dummy, /* never called */
-	.disable = dummy,
-	.enable = dummy,
-	.ack = dummy,
+	.irq_disable = dummy,
+	.irq_enable = dummy,
+	.irq_ack = dummy,
 };
 
 void __init init_IRQ(void)



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [patch 3/4] um: Use proper accessors in show_interrupts()
  2011-02-06 22:45 [patch 0/4] UML: Convert irq_chips and use proper accessors Thomas Gleixner
  2011-02-06 22:45 ` [patch 1/4] um: Remove stale irq_chip.end Thomas Gleixner
  2011-02-06 22:45 ` [patch 2/4] um: Convert irq_chips to new functions Thomas Gleixner
@ 2011-02-06 22:45 ` Thomas Gleixner
  2011-02-14 18:40   ` [tip:um/irq] " tip-bot for Thomas Gleixner
  2011-02-06 22:45 ` [patch 4/4] um: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
  3 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2011-02-06 22:45 UTC (permalink / raw)
  To: LKML; +Cc: Jeff Dike

[-- Attachment #1: um-use-proper-accessors-in-show-interrupts.patch --]
[-- Type: text/plain, Size: 1283 bytes --]

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/um/kernel/irq.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Index: linux-next/arch/um/kernel/irq.c
===================================================================
--- linux-next.orig/arch/um/kernel/irq.c
+++ linux-next/arch/um/kernel/irq.c
@@ -35,8 +35,10 @@ int show_interrupts(struct seq_file *p, 
 	}
 
 	if (i < NR_IRQS) {
-		raw_spin_lock_irqsave(&irq_desc[i].lock, flags);
-		action = irq_desc[i].action;
+		struct irq_desc *desc = irq_to_desc(i);
+
+		raw_spin_lock_irqsave(&desc->lock, flags);
+		action = desc->action;
 		if (!action)
 			goto skip;
 		seq_printf(p, "%3d: ",i);
@@ -46,7 +48,7 @@ int show_interrupts(struct seq_file *p, 
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", kstat_irqs_cpu(i, j));
 #endif
-		seq_printf(p, " %14s", irq_desc[i].chip->name);
+		seq_printf(p, " %14s", get_irq_desc_chip(desc)->name);
 		seq_printf(p, "  %s", action->name);
 
 		for (action=action->next; action; action = action->next)
@@ -54,7 +56,7 @@ int show_interrupts(struct seq_file *p, 
 
 		seq_putc(p, '\n');
 skip:
-		raw_spin_unlock_irqrestore(&irq_desc[i].lock, flags);
+		raw_spin_unlock_irqrestore(&desc->lock, flags);
 	} else if (i == NR_IRQS)
 		seq_putc(p, '\n');
 



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [patch 4/4] um: Select GENERIC_HARDIRQS_NO_DEPRECATED
  2011-02-06 22:45 [patch 0/4] UML: Convert irq_chips and use proper accessors Thomas Gleixner
                   ` (2 preceding siblings ...)
  2011-02-06 22:45 ` [patch 3/4] um: Use proper accessors in show_interrupts() Thomas Gleixner
@ 2011-02-06 22:45 ` Thomas Gleixner
  2011-02-14 18:41   ` [tip:um/irq] " tip-bot for Thomas Gleixner
  3 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2011-02-06 22:45 UTC (permalink / raw)
  To: LKML; +Cc: Jeff Dike

[-- Attachment #1: um-set-nodepr.patch --]
[-- Type: text/plain, Size: 509 bytes --]

irq chips converted and proper accessor functions used.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 arch/um/Kconfig.common |    1 +
 1 file changed, 1 insertion(+)

Index: linux-next/arch/um/Kconfig.common
===================================================================
--- linux-next.orig/arch/um/Kconfig.common
+++ linux-next/arch/um/Kconfig.common
@@ -7,6 +7,7 @@ config UML
 	bool
 	default y
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_HARDIRQS_NO_DEPRECATED
 
 config MMU
 	bool



^ permalink raw reply	[flat|nested] 9+ messages in thread

* [tip:um/irq] um: Remove stale irq_chip.end
  2011-02-06 22:45 ` [patch 1/4] um: Remove stale irq_chip.end Thomas Gleixner
@ 2011-02-14 18:39   ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Thomas Gleixner @ 2011-02-14 18:39 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, jdike, hpa, mingo, akpm, peterz, tglx

Commit-ID:  6ea96e7e4946f790330557e4b7c4c8a174c1c6d2
Gitweb:     http://git.kernel.org/tip/6ea96e7e4946f790330557e4b7c4c8a174c1c6d2
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 6 Feb 2011 22:45:31 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 14 Feb 2011 19:37:39 +0100

um: Remove stale irq_chip.end

irq_chip.end got obsolete with the remnoval of __do_IRQ().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <20110206224515.135703209@linutronix.de>
---
 arch/um/kernel/irq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c
index 3f0ac9e..c916748 100644
--- a/arch/um/kernel/irq.c
+++ b/arch/um/kernel/irq.c
@@ -374,7 +374,6 @@ static struct irq_chip normal_irq_type = {
 	.disable = dummy,
 	.enable = dummy,
 	.ack = dummy,
-	.end = dummy
 };
 
 static struct irq_chip SIGVTALRM_irq_type = {
@@ -384,7 +383,6 @@ static struct irq_chip SIGVTALRM_irq_type = {
 	.disable = dummy,
 	.enable = dummy,
 	.ack = dummy,
-	.end = dummy
 };
 
 void __init init_IRQ(void)

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [tip:um/irq] um: Convert irq_chips to new functions
  2011-02-06 22:45 ` [patch 2/4] um: Convert irq_chips to new functions Thomas Gleixner
@ 2011-02-14 18:40   ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Thomas Gleixner @ 2011-02-14 18:40 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, jdike, hpa, mingo, akpm, tglx

Commit-ID:  1d119aa06fb2b2608151a162f15c480d46694b65
Gitweb:     http://git.kernel.org/tip/1d119aa06fb2b2608151a162f15c480d46694b65
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 6 Feb 2011 22:45:34 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 14 Feb 2011 19:37:39 +0100

um: Convert irq_chips to new functions

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <20110206224515.224027758@linutronix.de>
---
 arch/um/kernel/irq.c |   19 +++++++++----------
 1 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c
index c916748..f771b85 100644
--- a/arch/um/kernel/irq.c
+++ b/arch/um/kernel/irq.c
@@ -360,10 +360,10 @@ EXPORT_SYMBOL(um_request_irq);
 EXPORT_SYMBOL(reactivate_fd);
 
 /*
- * irq_chip must define (startup || enable) &&
- * (shutdown || disable) && end
+ * irq_chip must define at least enable/disable and ack when
+ * the edge handler is used.
  */
-static void dummy(unsigned int irq)
+static void dummy(struct irq_data *d)
 {
 }
 
@@ -371,18 +371,17 @@ static void dummy(unsigned int irq)
 static struct irq_chip normal_irq_type = {
 	.name = "SIGIO",
 	.release = free_irq_by_irq_and_dev,
-	.disable = dummy,
-	.enable = dummy,
-	.ack = dummy,
+	.irq_disable = dummy,
+	.irq_enable = dummy,
+	.irq_ack = dummy,
 };
 
 static struct irq_chip SIGVTALRM_irq_type = {
 	.name = "SIGVTALRM",
 	.release = free_irq_by_irq_and_dev,
-	.shutdown = dummy, /* never called */
-	.disable = dummy,
-	.enable = dummy,
-	.ack = dummy,
+	.irq_disable = dummy,
+	.irq_enable = dummy,
+	.irq_ack = dummy,
 };
 
 void __init init_IRQ(void)

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [tip:um/irq] um: Use proper accessors in show_interrupts()
  2011-02-06 22:45 ` [patch 3/4] um: Use proper accessors in show_interrupts() Thomas Gleixner
@ 2011-02-14 18:40   ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Thomas Gleixner @ 2011-02-14 18:40 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, jdike, hpa, mingo, akpm, tglx

Commit-ID:  d5b4eea1c575b78448fd5dc54d250ff302ca22f9
Gitweb:     http://git.kernel.org/tip/d5b4eea1c575b78448fd5dc54d250ff302ca22f9
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 6 Feb 2011 22:45:36 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 14 Feb 2011 19:37:40 +0100

um: Use proper accessors in show_interrupts()

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <20110206224515.322707425@linutronix.de>
---
 arch/um/kernel/irq.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/arch/um/kernel/irq.c b/arch/um/kernel/irq.c
index f771b85..64cfea8 100644
--- a/arch/um/kernel/irq.c
+++ b/arch/um/kernel/irq.c
@@ -35,8 +35,10 @@ int show_interrupts(struct seq_file *p, void *v)
 	}
 
 	if (i < NR_IRQS) {
-		raw_spin_lock_irqsave(&irq_desc[i].lock, flags);
-		action = irq_desc[i].action;
+		struct irq_desc *desc = irq_to_desc(i);
+
+		raw_spin_lock_irqsave(&desc->lock, flags);
+		action = desc->action;
 		if (!action)
 			goto skip;
 		seq_printf(p, "%3d: ",i);
@@ -46,7 +48,7 @@ int show_interrupts(struct seq_file *p, void *v)
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", kstat_irqs_cpu(i, j));
 #endif
-		seq_printf(p, " %14s", irq_desc[i].chip->name);
+		seq_printf(p, " %14s", get_irq_desc_chip(desc)->name);
 		seq_printf(p, "  %s", action->name);
 
 		for (action=action->next; action; action = action->next)
@@ -54,7 +56,7 @@ int show_interrupts(struct seq_file *p, void *v)
 
 		seq_putc(p, '\n');
 skip:
-		raw_spin_unlock_irqrestore(&irq_desc[i].lock, flags);
+		raw_spin_unlock_irqrestore(&desc->lock, flags);
 	} else if (i == NR_IRQS)
 		seq_putc(p, '\n');
 

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [tip:um/irq] um: Select GENERIC_HARDIRQS_NO_DEPRECATED
  2011-02-06 22:45 ` [patch 4/4] um: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
@ 2011-02-14 18:41   ` tip-bot for Thomas Gleixner
  0 siblings, 0 replies; 9+ messages in thread
From: tip-bot for Thomas Gleixner @ 2011-02-14 18:41 UTC (permalink / raw)
  To: linux-tip-commits; +Cc: linux-kernel, jdike, hpa, mingo, akpm, tglx

Commit-ID:  53c39ce56d203d80ba8217a16bb024b25185fb7e
Gitweb:     http://git.kernel.org/tip/53c39ce56d203d80ba8217a16bb024b25185fb7e
Author:     Thomas Gleixner <tglx@linutronix.de>
AuthorDate: Sun, 6 Feb 2011 22:45:38 +0000
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 14 Feb 2011 19:37:40 +0100

um: Select GENERIC_HARDIRQS_NO_DEPRECATED

irq chips converted and proper accessor functions used.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <20110206224515.430825903@linutronix.de>
---
 arch/um/Kconfig.common |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/um/Kconfig.common b/arch/um/Kconfig.common
index e351e14..1e78940 100644
--- a/arch/um/Kconfig.common
+++ b/arch/um/Kconfig.common
@@ -7,6 +7,7 @@ config UML
 	bool
 	default y
 	select HAVE_GENERIC_HARDIRQS
+	select GENERIC_HARDIRQS_NO_DEPRECATED
 
 config MMU
 	bool

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2011-02-14 18:41 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-06 22:45 [patch 0/4] UML: Convert irq_chips and use proper accessors Thomas Gleixner
2011-02-06 22:45 ` [patch 1/4] um: Remove stale irq_chip.end Thomas Gleixner
2011-02-14 18:39   ` [tip:um/irq] " tip-bot for Thomas Gleixner
2011-02-06 22:45 ` [patch 2/4] um: Convert irq_chips to new functions Thomas Gleixner
2011-02-14 18:40   ` [tip:um/irq] " tip-bot for Thomas Gleixner
2011-02-06 22:45 ` [patch 3/4] um: Use proper accessors in show_interrupts() Thomas Gleixner
2011-02-14 18:40   ` [tip:um/irq] " tip-bot for Thomas Gleixner
2011-02-06 22:45 ` [patch 4/4] um: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner
2011-02-14 18:41   ` [tip:um/irq] " tip-bot for Thomas Gleixner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.