All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nilfs2_ss_manager: fix TypeError at exit
@ 2011-02-06 12:24 Ryusuke Konishi
       [not found] ` <1296995057-30479-1-git-send-email-ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Ryusuke Konishi @ 2011-02-06 12:24 UTC (permalink / raw)
  To: Jiro SEKIBA; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA, Ryusuke Konishi

Fixes the following error on shutdown:

Traceback (most recent call last):
  File "./nilfs2_ss_manager", line 211, in <module>
    mainloop.run()
TypeError: __exit__() takes exactly 1 argument (4 given)

Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
---
 nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
index 5821e2a..cff7d35 100755
--- a/nilfs2_ss_manager/nilfs2_ss_manager
+++ b/nilfs2_ss_manager/nilfs2_ss_manager
@@ -150,7 +150,7 @@ class NODaemonContext:
     def __enter__(self):
         pass
 
-    def __exit__(self):
+    def __exit__(self, *execinfo):
         pass
 
 def register_sighandlers(managers, mainloop):
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
       [not found] ` <1296995057-30479-1-git-send-email-ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2011-02-06 12:34   ` Ryusuke Konishi
       [not found]     ` <20110206.213453.187450645.ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Ryusuke Konishi @ 2011-02-06 12:34 UTC (permalink / raw)
  To: jir-hfpbi5WX9J54Eiagz67IpQ
  Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA, ryusuke-sG5X7nlA6pw

On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> Fixes the following error on shutdown:
> 
> Traceback (most recent call last):
>   File "./nilfs2_ss_manager", line 211, in <module>
>     mainloop.run()
> TypeError: __exit__() takes exactly 1 argument (4 given)
> 
> Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>

There is a typo on the previous patch.

Please apply the following one instead.

Thanks,
Ryusuke Konishi
--
From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>

nilfs2_ss_manager: fix TypeError at exit

Fixes the following error on shutdown:

Traceback (most recent call last):
  File "./nilfs2_ss_manager", line 211, in <module>
    mainloop.run()
TypeError: __exit__() takes exactly 1 argument (4 given)

Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
---
 nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
index 5821e2a..2243034 100755
--- a/nilfs2_ss_manager/nilfs2_ss_manager
+++ b/nilfs2_ss_manager/nilfs2_ss_manager
@@ -150,7 +150,7 @@ class NODaemonContext:
     def __enter__(self):
         pass
 
-    def __exit__(self):
+    def __exit__(self, *excinfo):
         pass
 
 def register_sighandlers(managers, mainloop):
-- 
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
       [not found]     ` <20110206.213453.187450645.ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2011-02-07  3:49       ` Jiro SEKIBA
       [not found]         ` <87mxm8a4hg.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Jiro SEKIBA @ 2011-02-07  3:49 UTC (permalink / raw)
  To: Ryusuke Konishi; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA


At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
Ryusuke Konishi wrote:
> 
> On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > Fixes the following error on shutdown:
> > 
> > Traceback (most recent call last):
> >   File "./nilfs2_ss_manager", line 211, in <module>
> >     mainloop.run()
> > TypeError: __exit__() takes exactly 1 argument (4 given)
> > 
> > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> 
> There is a typo on the previous patch.
> 
> Please apply the following one instead.

Did you mean "follwoing" as "will send a new mail followed by this"
or as "new patch contained in bottom of this mail" ?

Because the patch in the mail looks same one with before to me.
If you don't mind, I'll fix the bug by myself.

Thank you anyway for the fix!

regards,

> Thanks,
> Ryusuke Konishi
> --
> From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> 
> nilfs2_ss_manager: fix TypeError at exit
> 
> Fixes the following error on shutdown:
> 
> Traceback (most recent call last):
>   File "./nilfs2_ss_manager", line 211, in <module>
>     mainloop.run()
> TypeError: __exit__() takes exactly 1 argument (4 given)
> 
> Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> ---
>  nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
> index 5821e2a..2243034 100755
> --- a/nilfs2_ss_manager/nilfs2_ss_manager
> +++ b/nilfs2_ss_manager/nilfs2_ss_manager
> @@ -150,7 +150,7 @@ class NODaemonContext:
>      def __enter__(self):
>          pass
>  
> -    def __exit__(self):
> +    def __exit__(self, *excinfo):
>          pass
>  
>  def register_sighandlers(managers, mainloop):
> -- 
> 1.7.2.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 




-- 
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
       [not found]         ` <87mxm8a4hg.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
@ 2011-02-07  4:13           ` Ryusuke Konishi
       [not found]             ` <20110207.131318.212382134.ryusuke-sG5X7nlA6pw@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Ryusuke Konishi @ 2011-02-07  4:13 UTC (permalink / raw)
  To: jir-hfpbi5WX9J54Eiagz67IpQ; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA

On Mon, 07 Feb 2011 12:49:31 +0900, Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org> wrote:
> 
> At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
> Ryusuke Konishi wrote:
> > 
> > On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > > Fixes the following error on shutdown:
> > > 
> > > Traceback (most recent call last):
> > >   File "./nilfs2_ss_manager", line 211, in <module>
> > >     mainloop.run()
> > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > 
> > > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > 
> > There is a typo on the previous patch.
> > 
> > Please apply the following one instead.
> 
> Did you mean "follwoing" as "will send a new mail followed by this"
> or as "new patch contained in bottom of this mail" ?

I mean "new patch contained in bottom of this mail."

The second patch just fixes a typo "execinfo" -> "excinfo", where
"exc" is abbreviation of "exception" (not "execution").

Regards,
Ryusuke Konishi

 
> Because the patch in the mail looks same one with before to me.
> If you don't mind, I'll fix the bug by myself.
> 
> Thank you anyway for the fix!
> 
> regards,
> 
> > Thanks,
> > Ryusuke Konishi
> > --
> > From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > 
> > nilfs2_ss_manager: fix TypeError at exit
> > 
> > Fixes the following error on shutdown:
> > 
> > Traceback (most recent call last):
> >   File "./nilfs2_ss_manager", line 211, in <module>
> >     mainloop.run()
> > TypeError: __exit__() takes exactly 1 argument (4 given)
> > 
> > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > ---
> >  nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
> > index 5821e2a..2243034 100755
> > --- a/nilfs2_ss_manager/nilfs2_ss_manager
> > +++ b/nilfs2_ss_manager/nilfs2_ss_manager
> > @@ -150,7 +150,7 @@ class NODaemonContext:
> >      def __enter__(self):
> >          pass
> >  
> > -    def __exit__(self):
> > +    def __exit__(self, *excinfo):
> >          pass
> >  
> >  def register_sighandlers(managers, mainloop):
> > -- 
> > 1.7.2.3
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> > 
> 
> 
> 
> 
> -- 
> Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
       [not found]             ` <20110207.131318.212382134.ryusuke-sG5X7nlA6pw@public.gmane.org>
@ 2011-02-08  8:42               ` Jiro SEKIBA
       [not found]                 ` <87aai6533k.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 6+ messages in thread
From: Jiro SEKIBA @ 2011-02-08  8:42 UTC (permalink / raw)
  To: Ryusuke Konishi; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA


At Mon, 07 Feb 2011 13:13:18 +0900 (JST),
Ryusuke Konishi wrote:
> 
> On Mon, 07 Feb 2011 12:49:31 +0900, Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org> wrote:
> > 
> > At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
> > Ryusuke Konishi wrote:
> > > 
> > > On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > > > Fixes the following error on shutdown:
> > > > 
> > > > Traceback (most recent call last):
> > > >   File "./nilfs2_ss_manager", line 211, in <module>
> > > >     mainloop.run()
> > > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > > 
> > > > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > > 
> > > There is a typo on the previous patch.
> > > 
> > > Please apply the following one instead.
> > 
> > Did you mean "follwoing" as "will send a new mail followed by this"
> > or as "new patch contained in bottom of this mail" ?
> 
> I mean "new patch contained in bottom of this mail."
> 
> The second patch just fixes a typo "execinfo" -> "excinfo", where
> "exc" is abbreviation of "exception" (not "execution").

Ah, I got it.

I applied this one and former series patches.

Thank you!

regards,

> Regards,
> Ryusuke Konishi
> 
>  
> > Because the patch in the mail looks same one with before to me.
> > If you don't mind, I'll fix the bug by myself.
> > 
> > Thank you anyway for the fix!
> > 
> > regards,
> > 
> > > Thanks,
> > > Ryusuke Konishi
> > > --
> > > From: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > > 
> > > nilfs2_ss_manager: fix TypeError at exit
> > > 
> > > Fixes the following error on shutdown:
> > > 
> > > Traceback (most recent call last):
> > >   File "./nilfs2_ss_manager", line 211, in <module>
> > >     mainloop.run()
> > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > 
> > > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > > ---
> > >  nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
> > > index 5821e2a..2243034 100755
> > > --- a/nilfs2_ss_manager/nilfs2_ss_manager
> > > +++ b/nilfs2_ss_manager/nilfs2_ss_manager
> > > @@ -150,7 +150,7 @@ class NODaemonContext:
> > >      def __enter__(self):
> > >          pass
> > >  
> > > -    def __exit__(self):
> > > +    def __exit__(self, *excinfo):
> > >          pass
> > >  
> > >  def register_sighandlers(managers, mainloop):
> > > -- 
> > > 1.7.2.3
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > -- 
> > Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 


-- 
Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit
       [not found]                 ` <87aai6533k.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
@ 2011-02-08 10:52                   ` Ryusuke Konishi
  0 siblings, 0 replies; 6+ messages in thread
From: Ryusuke Konishi @ 2011-02-08 10:52 UTC (permalink / raw)
  To: jir-hfpbi5WX9J54Eiagz67IpQ; +Cc: linux-nilfs-u79uwXL29TY76Z2rM5mHXA

On Tue, 08 Feb 2011 17:42:55 +0900, Jiro SEKIBA wrote:
> At Mon, 07 Feb 2011 13:13:18 +0900 (JST),
> Ryusuke Konishi wrote:
> > 
> > On Mon, 07 Feb 2011 12:49:31 +0900, Jiro SEKIBA <jir-hfpbi5WX9J54Eiagz67IpQ@public.gmane.org> wrote:
> > > 
> > > At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
> > > Ryusuke Konishi wrote:
> > > > 
> > > > On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > > > > Fixes the following error on shutdown:
> > > > > 
> > > > > Traceback (most recent call last):
> > > > >   File "./nilfs2_ss_manager", line 211, in <module>
> > > > >     mainloop.run()
> > > > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > > > 
> > > > > Signed-off-by: Ryusuke Konishi <ryusuke-sG5X7nlA6pw@public.gmane.org>
> > > > 
> > > > There is a typo on the previous patch.
> > > > 
> > > > Please apply the following one instead.
> > > 
> > > Did you mean "follwoing" as "will send a new mail followed by this"
> > > or as "new patch contained in bottom of this mail" ?
> > 
> > I mean "new patch contained in bottom of this mail."
> > 
> > The second patch just fixes a typo "execinfo" -> "excinfo", where
> > "exc" is abbreviation of "exception" (not "execution").
> 
> Ah, I got it.
> 
> I applied this one and former series patches.
> 
> Thank you!
> 
> regards,

Thanks.

How about replacing the v0.1 package with v0.1.1 before moving on ?

Cheers,
Ryusuke Konishi
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-08 10:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-06 12:24 [PATCH] nilfs2_ss_manager: fix TypeError at exit Ryusuke Konishi
     [not found] ` <1296995057-30479-1-git-send-email-ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-06 12:34   ` Ryusuke Konishi
     [not found]     ` <20110206.213453.187450645.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-07  3:49       ` Jiro SEKIBA
     [not found]         ` <87mxm8a4hg.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2011-02-07  4:13           ` Ryusuke Konishi
     [not found]             ` <20110207.131318.212382134.ryusuke-sG5X7nlA6pw@public.gmane.org>
2011-02-08  8:42               ` Jiro SEKIBA
     [not found]                 ` <87aai6533k.wl%jir-27yqGEOhnJbQT0dZR+AlfA@public.gmane.org>
2011-02-08 10:52                   ` Ryusuke Konishi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.