From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Sebastian Pipping <webmaster@hartwork.org>,
Git ML <git@vger.kernel.org>
Subject: Re: "git add -u" broken in git 1.7.4?
Date: Mon, 7 Feb 2011 00:53:14 -0500 [thread overview]
Message-ID: <20110207055314.GA5511@sigill.intra.peff.net> (raw)
In-Reply-To: <7vwrlcv1ea.fsf@alter.siamese.dyndns.org>
On Sun, Feb 06, 2011 at 09:50:37PM -0800, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>
> > Sebastian Pipping <webmaster@hartwork.org> writes:
> >
> >> I was and I can confirm the different behaviour with 1.7.4 over here: it
> >> does work on the root directory of the repo as you supposed.
> >
> > What do you mean by "it does not work"?
> >
> > "git add -u" adds files under the current directory, and it always
> > did.
>
> As it takes pathspecs (think "git add -u this-file"), it fundamentally
> shouldn't be tree-wide. I think the original implementation didn't take
> pathspecs and was mistakenly done as tree-wide operation, but I think it
> was fixed rather quickly.
Is "git add -p" broken, then? It takes pathspecs relative to the current
directory, but "git add -p" without arguments operates from the root,
not from the current subdirectory.
-Peff
next prev parent reply other threads:[~2011-02-07 5:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 0:39 "git add -u" broken in git 1.7.4? Sebastian Pipping
2011-02-06 5:13 ` Jeff King
2011-02-06 19:35 ` Sebastian Pipping
2011-02-06 20:48 ` Matthieu Moy
2011-02-06 23:19 ` SZEDER Gábor
2011-02-06 23:49 ` Sebastian Pipping
2011-02-07 5:50 ` Junio C Hamano
2011-02-07 5:53 ` Jeff King [this message]
2011-02-07 6:46 ` Junio C Hamano
2011-02-07 7:29 ` Nguyen Thai Ngoc Duy
2011-02-07 18:34 ` SZEDER Gábor
2011-02-07 19:31 ` Junio C Hamano
2011-02-07 19:50 ` Jeff King
2011-02-08 10:05 ` SZEDER Gábor
2011-02-09 21:03 ` Jeff King
2011-02-09 22:40 ` Junio C Hamano
2011-02-09 23:46 ` Jeff King
2011-02-10 2:24 ` Nguyen Thai Ngoc Duy
2011-02-10 2:31 ` Jeff King
2011-02-10 2:46 ` Junio C Hamano
2011-02-10 7:46 ` Johannes Sixt
2011-02-10 8:13 ` Joshua Juran
2011-02-10 18:00 ` Matthieu Moy
2011-02-15 7:04 ` [PATCH] command-list.txt: mark git-archive plumbing Nguyen Thai Ngoc Duy
2011-02-15 19:11 ` Junio C Hamano
2011-02-16 9:32 ` Nguyen Thai Ngoc Duy
2011-02-07 20:57 ` "git add -u" broken in git 1.7.4? Matthieu Moy
2011-02-07 21:02 ` Jeff King
2011-02-07 21:49 ` Junio C Hamano
2011-02-08 1:25 ` Eric Raible
2011-02-08 2:16 ` Junio C Hamano
2011-02-07 6:48 ` Matthieu Moy
2011-02-07 8:27 ` Michael J Gruber
2011-02-07 11:15 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207055314.GA5511@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=webmaster@hartwork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.