All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH] adjust XZ_DEC_* Kconfig defaults
       [not found] <4D5260530200007800030F22@vpn.id2.novell.com>
@ 2011-02-09  9:51 ` Lasse Collin
  2011-02-09 19:27   ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Lasse Collin @ 2011-02-09  9:51 UTC (permalink / raw)
  To: Jan Beulich; +Cc: linux-kbuild

On 2011-02-09 Jan Beulich wrote:
> Having architecture specific decoders enabled by default makes little
> sense - only at most one of the respective encoders is being used,
> and hence the other decoders are not necessary in the common
> (default) case.

It can be nice to be able to mount a Squashfs image containing ARM 
binaries on a x86 desktop, but maybe that isn't important enough to keep 
all BCJ filters enabled by default. If they are not enabled by default, 
I think "if EXPERT" needs to be removed from those options too.

For bigger size savings, it doesn't seem too useful to have five 
decompressors enabled by default (and behind "if EXPERT") for initramfs. 
I added XZ to that list to be consistent with the existing methods, but 
it wasn't the best thing to do.

Bzip2 and LZMA are completely __init, but most of the gzip, LZO, and XZ 
code for initramfs is not __init. They pull zlib_inflate, 
lzo_decompress, xz_dec, and crc32 modules into the kernel.

I think gzip and LZO support for initramfs should be enough by default, 
because bzip2, LZMA, and XZ are slower to decompress. The compression 
ratio of initramfs doesn't matter much on desktop systems so the fast 
options are the best. Users of embedded systems will pick exactly one 
method anyway, ignoring the defaults.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] adjust XZ_DEC_* Kconfig defaults
  2011-02-09  9:51 ` [PATCH] adjust XZ_DEC_* Kconfig defaults Lasse Collin
@ 2011-02-09 19:27   ` Randy Dunlap
  2011-02-09 20:18     ` Lasse Collin
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2011-02-09 19:27 UTC (permalink / raw)
  To: Lasse Collin; +Cc: Jan Beulich, linux-kbuild

On Wed, 9 Feb 2011 11:51:08 +0200 Lasse Collin wrote:

> On 2011-02-09 Jan Beulich wrote:
> > Having architecture specific decoders enabled by default makes little
> > sense - only at most one of the respective encoders is being used,
> > and hence the other decoders are not necessary in the common
> > (default) case.
> 
> It can be nice to be able to mount a Squashfs image containing ARM 
> binaries on a x86 desktop, but maybe that isn't important enough to keep 
> all BCJ filters enabled by default. If they are not enabled by default, 
> I think "if EXPERT" needs to be removed from those options too.
> 
> For bigger size savings, it doesn't seem too useful to have five 
> decompressors enabled by default (and behind "if EXPERT") for initramfs. 
> I added XZ to that list to be consistent with the existing methods, but 
> it wasn't the best thing to do.
> 
> Bzip2 and LZMA are completely __init, but most of the gzip, LZO, and XZ 
> code for initramfs is not __init. They pull zlib_inflate, 
> lzo_decompress, xz_dec, and crc32 modules into the kernel.
> 
> I think gzip and LZO support for initramfs should be enough by default, 
> because bzip2, LZMA, and XZ are slower to decompress. The compression 
> ratio of initramfs doesn't matter much on desktop systems so the fast 
> options are the best. Users of embedded systems will pick exactly one 
> method anyway, ignoring the defaults.

Hi,
Did you see this email?  what do you think of it?

https://lkml.org/lkml/2011/2/1/438
Subject: Change DECOMPRESS_LZMA to boolean

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] adjust XZ_DEC_* Kconfig defaults
  2011-02-09 19:27   ` Randy Dunlap
@ 2011-02-09 20:18     ` Lasse Collin
  0 siblings, 0 replies; 3+ messages in thread
From: Lasse Collin @ 2011-02-09 20:18 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: Jan Beulich, linux-kbuild

On 2011-02-09 Randy Dunlap wrote:
> Did you see this email?  what do you think of it?
> 
> https://lkml.org/lkml/2011/2/1/438
> Subject: Change DECOMPRESS_LZMA to boolean

No, I didn't see it. Seems that the five DECOMPRESS_* symbols should all 
be booleans. They cannot be built as modules.

-- 
Lasse Collin  |  IRC: Larhzu @ IRCnet & Freenode

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-09 20:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <4D5260530200007800030F22@vpn.id2.novell.com>
2011-02-09  9:51 ` [PATCH] adjust XZ_DEC_* Kconfig defaults Lasse Collin
2011-02-09 19:27   ` Randy Dunlap
2011-02-09 20:18     ` Lasse Collin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.