From: Alan Cox <alan@lxorguk.ukuu.org.uk> To: Subhasish Ghosh <subhasish@mistralsolutions.com> Cc: davinci-linux-open-source@linux.davincidsp.com, linux-arm-kernel@lists.infradead.org, m-watkins@ti.com, nsekhar@ti.com, sachi@mistralsolutions.com, Greg Kroah-Hartman <gregkh@suse.de>, linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH v2 13/13] tty: pruss SUART driver Date: Fri, 11 Feb 2011 16:28:14 +0000 [thread overview] Message-ID: <20110211162814.6ff274f1@lxorguk.ukuu.org.uk> (raw) In-Reply-To: <1297435892-28278-14-git-send-email-subhasish@mistralsolutions.com> Don't see why it needs its own sub-directory > +#ifdef __SUART_DEBUG > +#define __suart_debug(fmt, args...) \ > + printk(KERN_DEBUG "suart_debug: " fmt, ## args) > +#else > +#define __suart_debug(fmt, args...) > +#endif > + > +#define __suart_err(fmt, args...) printk(KERN_ERR "suart_err: " fmt, ## args) Use dev_dbg/dev_err/pr_debug/pr_err > +static void omapl_pru_tx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) > +{ > + struct circ_buf *xmit = &soft_uart->port[uart_no].state->xmit; > + struct device *dev = soft_uart->dev; > + s32 count = 0; > + > + if (!(suart_get_duplex(soft_uart, uart_no) & ePRU_SUART_HALF_TX)) > + return; > + > + if (down_trylock(&soft_uart->port_sem[uart_no])) > + return; Please use a mutex not a semaphore. We are trying to get almost all the kernel using mutexes as it is needed for hard real time. > + pru_softuart_read_data(dev, &soft_uart->suart_hdl[uart_no], > + suart_data, data_len + 1, > + &data_len_read); > + > + for (i = 0; i <= data_len_read; i++) { > + soft_uart->port[uart_no].icount.rx++; > + /* check for sys rq */ > + if (uart_handle_sysrq_char > + (&soft_uart->port[uart_no], suart_data)) > + continue; > + } > + /* update the tty data structure */ > + tty_insert_flip_string(tty, suart_data, data_len_read); You can avoid a copy here by using tty_prepare_flip_string() Also please use the tty_port_tty_get/tty_kref_put interfaces so the tty refcounting is right > +static void pruss_suart_set_termios(struct uart_port *port, > + struct ktermios *termios, > + struct ktermios *old) > +{ > + struct omapl_pru_suart *soft_uart = > + container_of(port, struct omapl_pru_suart, port[port->line]); > + struct device *dev = soft_uart->dev; > + u8 cval = 0; > + unsigned long flags = 0; > + u32 baud = 0; > + u32 old_csize = old ? old->c_cflag & CSIZE : CS8; > + > +/* > + * Do not allow unsupported configurations to be set > + */ > + if (1) { > + termios->c_cflag &= ~(HUPCL | CRTSCTS | CMSPAR | CSTOPB > + | PARENB | PARODD | CMSPAR); > + termios->c_cflag |= CLOCAL; No. CLOCAL and HUPCL are user side flags. Apps expect to able to set them even if in fact they have no effect, so leave those two alone. The rest is fine. > +/* > + * Characteres to ignore Typo > diff --git a/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c b/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c > new file mode 100644 > index 0000000..d809dd3 > --- /dev/null > +++ b/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c > @@ -0,0 +1,2350 @@ > +/* > + * Copyright (C) 2010 Texas Instruments Incorporated > + * Author: Jitendra Kumar <jitendra@mistralsolutions.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation version 2. > + * > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any kind, > + * whether express or implied; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + */ > + > +#include <linux/types.h> > +#include <linux/mfd/pruss/da8xx_pru.h> > +#include <linux/io.h> > +#include <mach/hardware.h> > +#include "pruss_suart_api.h" > +#include "pruss_suart_regs.h" > +#include "pruss_suart_board.h" > +#include "pruss_suart_utils.h" > +#include "pruss_suart_err.h" > + > +static u8 g_uart_statu_table[8]; Can you lose the g_, its a windows naming convention we dont use > +s16 pru_softuart_open(suart_handle h_suart) > +{ If you just used normal integers you could surely make this routine trivial and remove all the duplication in the switches > + s16 status = PRU_SUART_SUCCESS; And please stick to Linux error codes > +/* suart instance close routine */ > +s16 pru_softuart_close(suart_handle h_uart) > +{ > + s16 status = SUART_SUCCESS; > + > + if (h_uart == NULL) { > + return PRU_SUART_ERR_HANDLE_INVALID; Which is never checked. Far better to use WARN_ON and the like for such cases - or if like this one they don't appear to be possible to simply delete them > + if ((tx_clk_divisor > 385) || (tx_clk_divisor == 0)) > + return SUART_INVALID_CLKDIVISOR; > + if ((rx_clk_divisor > 385) || (rx_clk_divisor == 0)) > + return SUART_INVALID_CLKDIVISOR; [minor] Lots of excess brackets > + u32offset = (u32) (PRUSS_INTC_CHANMAP9 & 0xFFFF); > + u32value = PRU_INTC_CHAN_34_SYSEVT_36_39; > + s16retval = pruss_writel(dev, u32offset, (u32 *)&u32value, 1); > + if (-1 == s16retval) > + return -1; If you fixed the API here you'd be able to just write if (pruss_writel(dev, PRUSS_INTC_CHANMAP9 & 0xFFFF, PRU_INTC_BLAH) or similar which would clean up a lot of messy code and shrink it dramatically. Given you have lots of series of writes some kind of pruss_writel_multi(dev, array, len) that took an array of addr/value pairs might also clean up a ton of code and turn it into trivial tables
WARNING: multiple messages have this Message-ID (diff)
From: alan@lxorguk.ukuu.org.uk (Alan Cox) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 13/13] tty: pruss SUART driver Date: Fri, 11 Feb 2011 16:28:14 +0000 [thread overview] Message-ID: <20110211162814.6ff274f1@lxorguk.ukuu.org.uk> (raw) In-Reply-To: <1297435892-28278-14-git-send-email-subhasish@mistralsolutions.com> Don't see why it needs its own sub-directory > +#ifdef __SUART_DEBUG > +#define __suart_debug(fmt, args...) \ > + printk(KERN_DEBUG "suart_debug: " fmt, ## args) > +#else > +#define __suart_debug(fmt, args...) > +#endif > + > +#define __suart_err(fmt, args...) printk(KERN_ERR "suart_err: " fmt, ## args) Use dev_dbg/dev_err/pr_debug/pr_err > +static void omapl_pru_tx_chars(struct omapl_pru_suart *soft_uart, u32 uart_no) > +{ > + struct circ_buf *xmit = &soft_uart->port[uart_no].state->xmit; > + struct device *dev = soft_uart->dev; > + s32 count = 0; > + > + if (!(suart_get_duplex(soft_uart, uart_no) & ePRU_SUART_HALF_TX)) > + return; > + > + if (down_trylock(&soft_uart->port_sem[uart_no])) > + return; Please use a mutex not a semaphore. We are trying to get almost all the kernel using mutexes as it is needed for hard real time. > + pru_softuart_read_data(dev, &soft_uart->suart_hdl[uart_no], > + suart_data, data_len + 1, > + &data_len_read); > + > + for (i = 0; i <= data_len_read; i++) { > + soft_uart->port[uart_no].icount.rx++; > + /* check for sys rq */ > + if (uart_handle_sysrq_char > + (&soft_uart->port[uart_no], suart_data)) > + continue; > + } > + /* update the tty data structure */ > + tty_insert_flip_string(tty, suart_data, data_len_read); You can avoid a copy here by using tty_prepare_flip_string() Also please use the tty_port_tty_get/tty_kref_put interfaces so the tty refcounting is right > +static void pruss_suart_set_termios(struct uart_port *port, > + struct ktermios *termios, > + struct ktermios *old) > +{ > + struct omapl_pru_suart *soft_uart = > + container_of(port, struct omapl_pru_suart, port[port->line]); > + struct device *dev = soft_uart->dev; > + u8 cval = 0; > + unsigned long flags = 0; > + u32 baud = 0; > + u32 old_csize = old ? old->c_cflag & CSIZE : CS8; > + > +/* > + * Do not allow unsupported configurations to be set > + */ > + if (1) { > + termios->c_cflag &= ~(HUPCL | CRTSCTS | CMSPAR | CSTOPB > + | PARENB | PARODD | CMSPAR); > + termios->c_cflag |= CLOCAL; No. CLOCAL and HUPCL are user side flags. Apps expect to able to set them even if in fact they have no effect, so leave those two alone. The rest is fine. > +/* > + * Characteres to ignore Typo > diff --git a/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c b/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c > new file mode 100644 > index 0000000..d809dd3 > --- /dev/null > +++ b/drivers/tty/serial/da8xx_pruss/pruss_suart_api.c > @@ -0,0 +1,2350 @@ > +/* > + * Copyright (C) 2010 Texas Instruments Incorporated > + * Author: Jitendra Kumar <jitendra@mistralsolutions.com> > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of the GNU General Public License as published by the > + * Free Software Foundation version 2. > + * > + * This program is distributed "as is" WITHOUT ANY WARRANTY of any kind, > + * whether express or implied; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. > + */ > + > +#include <linux/types.h> > +#include <linux/mfd/pruss/da8xx_pru.h> > +#include <linux/io.h> > +#include <mach/hardware.h> > +#include "pruss_suart_api.h" > +#include "pruss_suart_regs.h" > +#include "pruss_suart_board.h" > +#include "pruss_suart_utils.h" > +#include "pruss_suart_err.h" > + > +static u8 g_uart_statu_table[8]; Can you lose the g_, its a windows naming convention we dont use > +s16 pru_softuart_open(suart_handle h_suart) > +{ If you just used normal integers you could surely make this routine trivial and remove all the duplication in the switches > + s16 status = PRU_SUART_SUCCESS; And please stick to Linux error codes > +/* suart instance close routine */ > +s16 pru_softuart_close(suart_handle h_uart) > +{ > + s16 status = SUART_SUCCESS; > + > + if (h_uart == NULL) { > + return PRU_SUART_ERR_HANDLE_INVALID; Which is never checked. Far better to use WARN_ON and the like for such cases - or if like this one they don't appear to be possible to simply delete them > + if ((tx_clk_divisor > 385) || (tx_clk_divisor == 0)) > + return SUART_INVALID_CLKDIVISOR; > + if ((rx_clk_divisor > 385) || (rx_clk_divisor == 0)) > + return SUART_INVALID_CLKDIVISOR; [minor] Lots of excess brackets > + u32offset = (u32) (PRUSS_INTC_CHANMAP9 & 0xFFFF); > + u32value = PRU_INTC_CHAN_34_SYSEVT_36_39; > + s16retval = pruss_writel(dev, u32offset, (u32 *)&u32value, 1); > + if (-1 == s16retval) > + return -1; If you fixed the API here you'd be able to just write if (pruss_writel(dev, PRUSS_INTC_CHANMAP9 & 0xFFFF, PRU_INTC_BLAH) or similar which would clean up a lot of messy code and shrink it dramatically. Given you have lots of series of writes some kind of pruss_writel_multi(dev, array, len) that took an array of addr/value pairs might also clean up a ton of code and turn it into trivial tables
next prev parent reply other threads:[~2011-02-11 16:24 UTC|newest] Thread overview: 161+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-11 14:51 [PATCH v2 00/13] pruss mfd drivers Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 01/13] mfd: pruss mfd driver Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-21 16:30 ` Samuel Ortiz 2011-02-21 16:30 ` Samuel Ortiz 2011-02-22 5:43 ` Subhasish Ghosh 2011-02-22 5:43 ` Subhasish Ghosh 2011-02-22 10:31 ` Samuel Ortiz 2011-02-22 10:31 ` Samuel Ortiz 2011-02-22 10:48 ` Wolfgang Grandegger 2011-02-22 10:48 ` Wolfgang Grandegger 2011-02-22 11:33 ` Samuel Ortiz 2011-02-22 11:33 ` Samuel Ortiz 2011-02-22 12:49 ` Subhasish Ghosh 2011-02-22 12:49 ` Subhasish Ghosh 2011-02-22 16:27 ` Wolfgang Grandegger 2011-02-22 16:27 ` Wolfgang Grandegger 2011-02-23 12:25 ` Subhasish Ghosh 2011-02-23 12:25 ` Subhasish Ghosh 2011-02-23 13:09 ` Russell King - ARM Linux 2011-02-23 13:09 ` Russell King - ARM Linux 2011-02-11 14:51 ` [PATCH v2 02/13] da850: pruss platform specific additions Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 18:41 ` Sergei Shtylyov 2011-02-11 18:41 ` Sergei Shtylyov 2011-02-18 7:18 ` Subhasish Ghosh 2011-02-18 7:18 ` Subhasish Ghosh 2011-02-28 13:04 ` TK, Pratheesh Gangadhar 2011-02-28 13:04 ` TK, Pratheesh Gangadhar 2011-03-01 6:59 ` Subhasish Ghosh 2011-03-01 6:59 ` Subhasish Ghosh 2011-03-03 11:12 ` TK, Pratheesh Gangadhar 2011-03-03 11:12 ` TK, Pratheesh Gangadhar 2011-02-11 14:51 ` [PATCH v2 03/13] da850: pruss board " Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 18:43 ` Sergei Shtylyov 2011-02-11 18:43 ` Sergei Shtylyov 2011-02-18 7:18 ` Subhasish Ghosh 2011-02-18 7:18 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 04/13] mfd: pruss CAN private data Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 05/13] da850: pruss CAN platform specific additions Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 06/13] da850: pruss CAN board " Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 18:45 ` Sergei Shtylyov 2011-02-11 18:45 ` Sergei Shtylyov 2011-02-18 7:19 ` Subhasish Ghosh 2011-02-18 7:19 ` Subhasish Ghosh 2011-02-18 7:19 ` Subhasish Ghosh 2011-02-18 7:19 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 07/13] da850: pruss CAN platform specific changes for gpios Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 18:47 ` Sergei Shtylyov 2011-02-11 18:47 ` Sergei Shtylyov 2011-02-18 7:20 ` Subhasish Ghosh 2011-02-18 7:20 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 08/13] da850: pruss CAN board " Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 09/13] can: pruss CAN driver Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 15:06 ` Kurt Van Dijck 2011-02-11 15:06 ` Kurt Van Dijck 2011-02-11 15:06 ` Kurt Van Dijck 2011-02-14 4:54 ` Subhasish Ghosh 2011-02-14 4:54 ` Subhasish Ghosh 2011-02-14 7:23 ` Wolfgang Grandegger [not found] ` <4D58D854.5090503-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org> 2011-02-14 7:42 ` Kurt Van Dijck 2011-02-14 7:42 ` Kurt Van Dijck 2011-02-14 8:45 ` Subhasish Ghosh 2011-02-14 8:45 ` Subhasish Ghosh 2011-02-14 9:28 ` Wolfgang Grandegger 2011-02-14 9:35 ` Marc Kleine-Budde 2011-02-14 13:15 ` Subhasish Ghosh 2011-02-14 13:15 ` Subhasish Ghosh 2011-02-14 13:15 ` Subhasish Ghosh 2011-02-14 13:33 ` Marc Kleine-Budde 2011-02-14 13:42 ` Wolfgang Grandegger 2011-02-11 15:20 ` Kurt Van Dijck 2011-02-11 15:20 ` Kurt Van Dijck 2011-02-11 15:20 ` Kurt Van Dijck 2011-02-18 7:07 ` Subhasish Ghosh 2011-02-18 7:07 ` Subhasish Ghosh 2011-02-18 7:07 ` Subhasish Ghosh 2011-02-18 7:53 ` Wolfgang Grandegger 2011-02-18 8:15 ` Subhasish Ghosh 2011-02-18 8:15 ` Subhasish Ghosh 2011-02-18 8:15 ` Subhasish Ghosh 2011-02-18 8:36 ` Marc Kleine-Budde 2011-02-18 8:36 ` Marc Kleine-Budde 2011-02-18 8:36 ` Marc Kleine-Budde 2011-02-18 9:09 ` Subhasish Ghosh 2011-02-18 9:09 ` Subhasish Ghosh 2011-02-18 9:09 ` Subhasish Ghosh [not found] ` <1297435892-28278-10-git-send-email-subhasish-EvXpCiN+lbve9wHmmfpqLFaTQe2KTcn/@public.gmane.org> 2011-02-11 20:33 ` Wolfgang Grandegger 2011-02-11 21:33 ` Marc Kleine-Budde 2011-02-18 15:07 ` Arnd Bergmann 2011-02-18 15:07 ` Arnd Bergmann 2011-03-22 7:30 ` Subhasish Ghosh 2011-03-22 7:30 ` Subhasish Ghosh 2011-03-22 7:30 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 10/13] mfd: pruss SUART private data Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 11/13] da850: pruss SUART board specific additions Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 15:26 ` Michael Williamson 2011-02-11 15:26 ` Michael Williamson 2011-02-18 7:13 ` Subhasish Ghosh 2011-02-18 7:13 ` Subhasish Ghosh 2011-02-11 18:50 ` Sergei Shtylyov 2011-02-11 18:50 ` Sergei Shtylyov 2011-02-22 6:22 ` Subhasish Ghosh 2011-02-22 6:22 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 12/13] da850: pruss SUART platform " Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 18:55 ` Sergei Shtylyov 2011-02-11 18:55 ` Sergei Shtylyov 2011-02-22 9:18 ` Subhasish Ghosh 2011-02-22 9:18 ` Subhasish Ghosh 2011-02-22 11:20 ` Sergei Shtylyov 2011-02-22 11:20 ` Sergei Shtylyov 2011-02-22 13:24 ` Subhasish Ghosh 2011-02-22 13:24 ` Subhasish Ghosh 2011-02-11 14:51 ` [PATCH v2 13/13] tty: pruss SUART driver Subhasish Ghosh 2011-02-11 14:51 ` Subhasish Ghosh 2011-02-11 16:28 ` Alan Cox [this message] 2011-02-11 16:28 ` Alan Cox 2011-02-18 13:47 ` Subhasish Ghosh 2011-02-18 13:47 ` Subhasish Ghosh 2011-02-18 14:35 ` Alan Cox 2011-02-18 14:35 ` Alan Cox 2011-02-18 18:23 ` Thomas Gleixner 2011-02-18 18:23 ` Thomas Gleixner 2011-02-18 18:51 ` Arnd Bergmann 2011-02-18 18:51 ` Arnd Bergmann 2011-02-22 8:42 ` Subhasish Ghosh 2011-02-22 8:42 ` Subhasish Ghosh 2011-02-22 14:37 ` Greg KH 2011-02-22 14:37 ` Greg KH 2011-02-23 5:30 ` Subhasish Ghosh 2011-02-23 5:30 ` Subhasish Ghosh 2011-02-23 18:20 ` Greg KH 2011-02-23 18:20 ` Greg KH 2011-02-22 8:43 ` Subhasish Ghosh 2011-02-22 8:43 ` Subhasish Ghosh 2011-02-22 16:34 ` Arnd Bergmann 2011-02-22 16:34 ` Arnd Bergmann 2011-02-24 10:31 ` Subhasish Ghosh 2011-02-24 10:31 ` Subhasish Ghosh 2011-02-22 10:26 ` Subhasish 2011-02-22 10:26 ` Subhasish 2011-02-22 11:11 ` Alan Cox 2011-02-22 11:11 ` Alan Cox 2011-03-01 13:37 ` Subhasish Ghosh 2011-03-01 13:37 ` Subhasish Ghosh 2011-03-01 14:07 ` Alan Cox 2011-03-01 14:07 ` Alan Cox 2011-02-23 13:35 Subhasish Ghosh 2011-02-23 13:34 ` Subhasish Ghosh 2011-02-23 18:21 ` Greg KH 2011-02-23 18:21 ` Greg KH
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110211162814.6ff274f1@lxorguk.ukuu.org.uk \ --to=alan@lxorguk.ukuu.org.uk \ --cc=davinci-linux-open-source@linux.davincidsp.com \ --cc=gregkh@suse.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=m-watkins@ti.com \ --cc=nsekhar@ti.com \ --cc=sachi@mistralsolutions.com \ --cc=subhasish@mistralsolutions.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.