All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@freescale.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: s.hauer@pengutronix.de, Chris Ball <cjb@laptop.org>,
	linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	LW@karo-electronics.de
Subject: Re: [PATCH v2 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28
Date: Wed, 16 Feb 2011 05:27:18 +0800	[thread overview]
Message-ID: <20110215212717.GF10990@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <201102132335.54868.arnd@arndb.de>

On Sun, Feb 13, 2011 at 11:35:54PM +0100, Arnd Bergmann wrote:
> On Sunday 13 February 2011, Chris Ball wrote:
> > On Mon, Feb 14, 2011 at 10:32:20AM +0800, Shawn Guo wrote:
> > > This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28.
> > > The driver calls into mxs-dma via generic dmaengine api for both pio
> > > and data transfer.
> > > 
> > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> > 
> > Please add a Reviewed-by: from Arnd and a Tested-by: from Lothar.
> > Could you add a MODULE_AUTHOR() field, too?
> 
> In general, these tags should not simply be added by the author without
> having the person who did the reviewing or testing specifically provide
> them!
> 
> In this particular case, I'm happy with the driver in version 2, good job!
> Please do add my
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
Will do.  Appreciate the review effort.

Regards,
Shawn

WARNING: multiple messages have this Message-ID (diff)
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/7] mmc: mxs-mmc: add mmc host driver for i.MX23/28
Date: Wed, 16 Feb 2011 05:27:18 +0800	[thread overview]
Message-ID: <20110215212717.GF10990@S2100-06.ap.freescale.net> (raw)
In-Reply-To: <201102132335.54868.arnd@arndb.de>

On Sun, Feb 13, 2011 at 11:35:54PM +0100, Arnd Bergmann wrote:
> On Sunday 13 February 2011, Chris Ball wrote:
> > On Mon, Feb 14, 2011 at 10:32:20AM +0800, Shawn Guo wrote:
> > > This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28.
> > > The driver calls into mxs-dma via generic dmaengine api for both pio
> > > and data transfer.
> > > 
> > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> > 
> > Please add a Reviewed-by: from Arnd and a Tested-by: from Lothar.
> > Could you add a MODULE_AUTHOR() field, too?
> 
> In general, these tags should not simply be added by the author without
> having the person who did the reviewing or testing specifically provide
> them!
> 
> In this particular case, I'm happy with the driver in version 2, good job!
> Please do add my
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> 
Will do.  Appreciate the review effort.

Regards,
Shawn

  parent reply	other threads:[~2011-02-15 21:27 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14  2:32 [PATCH v2 0/7] Add mmc driver for i.MX23/28 Shawn Guo
2011-02-14  2:32 ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 1/7] mmc: mxs-mmc: add mmc host " Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-13 19:26   ` Chris Ball
2011-02-13 19:26     ` Chris Ball
2011-02-13 22:35     ` Arnd Bergmann
2011-02-13 22:35       ` Arnd Bergmann
2011-02-14  0:25       ` Chris Ball
2011-02-14  0:25         ` Chris Ball
2011-02-15 21:27       ` Shawn Guo [this message]
2011-02-15 21:27         ` Shawn Guo
2011-02-15 21:26     ` Shawn Guo
2011-02-15 21:26       ` Shawn Guo
2011-02-14 15:39   ` Wolfram Sang
2011-02-14 15:39     ` Wolfram Sang
2011-02-15 21:28     ` Shawn Guo
2011-02-15 21:28       ` Shawn Guo
2011-02-14 16:59   ` Wolfram Sang
2011-02-14 16:59     ` Wolfram Sang
2011-02-15 22:39     ` Shawn Guo
2011-02-15 22:39       ` Shawn Guo
2011-02-15 17:13       ` Wolfram Sang
2011-02-15 17:13         ` Wolfram Sang
2011-02-15 17:19         ` Russell King - ARM Linux
2011-02-15 17:19           ` Russell King - ARM Linux
2011-02-15 17:29           ` Wolfram Sang
2011-02-15 17:29             ` Wolfram Sang
2011-02-15 17:32             ` Russell King - ARM Linux
2011-02-15 17:32               ` Russell King - ARM Linux
2011-02-16 20:28             ` Shawn Guo
2011-02-16 20:28               ` Shawn Guo
2011-02-16 15:33               ` Wolfram Sang
2011-02-16 15:33                 ` Wolfram Sang
2011-02-17  4:17                 ` Shawn Guo
2011-02-17  4:17                   ` Shawn Guo
2011-02-17 12:06                   ` Wolfram Sang
2011-02-17 12:06                     ` Wolfram Sang
2011-02-16 15:59               ` Arnd Bergmann
2011-02-16 15:59                 ` Arnd Bergmann
2011-02-17  2:44                 ` Shawn Guo
2011-02-17  2:44                   ` Shawn Guo
2011-02-14 16:59   ` Russell King - ARM Linux
2011-02-14 16:59     ` Russell King - ARM Linux
2011-02-15 22:03     ` Shawn Guo
2011-02-15 22:03       ` Shawn Guo
2011-02-15 14:13       ` Russell King - ARM Linux
2011-02-15 14:13         ` Russell King - ARM Linux
2011-02-14  2:32 ` [PATCH v2 2/7] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 3/7] ARM: mxs: make ssp error irq definition consistent Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 4/7] ARM: mxs: dynamically allocate mmc device Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 5/7] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 6/7] ARM: mxs/mx23evk: add mmc device Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14  2:32 ` [PATCH v2 7/7] ARM: mxs/mx28evk: " Shawn Guo
2011-02-14  2:32   ` Shawn Guo
2011-02-14 10:26   ` Wolfram Sang
2011-02-14 10:26     ` Wolfram Sang
2011-02-15 23:11     ` Shawn Guo
2011-02-15 23:11       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110215212717.GF10990@S2100-06.ap.freescale.net \
    --to=shawn.guo@freescale.com \
    --cc=LW@karo-electronics.de \
    --cc=arnd@arndb.de \
    --cc=cjb@laptop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.