All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: wwguy <wey-yi.w.guy@intel.com>,
	Intel Linux Wireless <ilw@linux.intel.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] iwlwifi: fix dma mappings and skbs leak
Date: Wed, 16 Feb 2011 10:49:16 +0100	[thread overview]
Message-ID: <20110216094913.GB2812@redhat.com> (raw)
In-Reply-To: <1297776631.3935.16.camel@jlt3.sipsolutions.net>

On Tue, Feb 15, 2011 at 02:30:31PM +0100, Johannes Berg wrote:
> On Tue, 2011-02-15 at 14:22 +0100, Stanislaw Gruszka wrote:
> > On Tue, Feb 15, 2011 at 02:09:53PM +0100, Johannes Berg wrote:
> > > Hmm. That's a bit strange, ieee80211_mgd_deauth() should also call
> > > ieee80211_set_disassoc()?
> > 
> > But only if ifmgd->associated == req->bss
> 
> Yeah but that means we're deauthenticating from the BSS we're associated
> with. How could it be a different one? Maybe you can print them or
> something, hmm..

I debug it more, ieee80211_sta_rx_notify() can be called after dissasociate 
from ieee80211_rx_h_sta_process() when device receive frames and I do rmmod.
I'll post proposed fix in separate email.

Stanislaw

  reply	other threads:[~2011-02-16  9:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 14:32 [PATCH v2] iwlwifi: fix dma mappings and skbs leak Stanislaw Gruszka
2011-02-14 15:51 ` wwguy
2011-02-15 11:34   ` Stanislaw Gruszka
2011-02-15 11:50     ` Johannes Berg
2011-02-15 13:04       ` Stanislaw Gruszka
2011-02-15 13:09         ` Johannes Berg
2011-02-15 13:22           ` Stanislaw Gruszka
2011-02-15 13:30             ` Johannes Berg
2011-02-16  9:49               ` Stanislaw Gruszka [this message]
2011-02-16  9:54               ` [PATCH] mac80211: fix conn_mon_timer running after disassociate Stanislaw Gruszka
2011-02-16 11:10                 ` Johannes Berg
2011-02-18  2:19                 ` Sujith
2011-02-18  7:48                   ` Stanislaw Gruszka
2011-02-19  9:04         ` [PATCH v2] iwlwifi: fix dma mappings and skbs leak Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216094913.GB2812@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=ilw@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wey-yi.w.guy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.