* [PATCH] r8169: incorrect args to oob notify
@ 2011-02-23 17:52 Stephen Hemminger
2011-02-23 20:00 ` Francois Romieu
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2011-02-23 17:52 UTC (permalink / raw)
To: Francois Romieu, David Miller; +Cc: netdev
Sparse detected this bug. The function oob_notify was being
passed the private ptr, but expected to get the ioaddr.
Compile checked only; not tested on real hardware.
Patch against net-next-2.6 but should be applied to net-2.6.
Bug not present in 2.6.37 and earlier.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/r8169.c 2011-02-23 09:46:30.042289776 -0800
+++ b/drivers/net/r8169.c 2011-02-23 09:48:00.167355773 -0800
@@ -617,8 +617,9 @@ static void ocp_write(struct rtl8169_pri
}
}
-static void rtl8168_oob_notify(void __iomem *ioaddr, u8 cmd)
+static void rtl8168_oob_notify(struct rtl8169_private *tp, u8 cmd)
{
+ void __iomem *ioaddr = tp->mmio_addr;
int i;
RTL_W8(ERIDR, cmd);
@@ -630,7 +631,7 @@ static void rtl8168_oob_notify(void __io
break;
}
- ocp_write(ioaddr, 0x1, 0x30, 0x00000001);
+ ocp_write(tp, 0x1, 0x30, 0x00000001);
}
#define OOB_CMD_RESET 0x00
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] r8169: incorrect args to oob notify
2011-02-23 17:52 [PATCH] r8169: incorrect args to oob notify Stephen Hemminger
@ 2011-02-23 20:00 ` Francois Romieu
0 siblings, 0 replies; 2+ messages in thread
From: Francois Romieu @ 2011-02-23 20:00 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David Miller, netdev, Hayes Wang
Stephen Hemminger <shemminger@vyatta.com> :
[...]
> Sparse detected this bug. The function oob_notify was being
> passed the private ptr, but expected to get the ioaddr.
> Compile checked only; not tested on real hardware.
>
> Patch against net-next-2.6 but should be applied to net-2.6.
> Bug not present in 2.6.37 and earlier.
Hayes has sent this fix and a few others. I am giving them a short
testing right now.
--
Ueimor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-23 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-23 17:52 [PATCH] r8169: incorrect args to oob notify Stephen Hemminger
2011-02-23 20:00 ` Francois Romieu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.