All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Anoop P A <anoop.pa@gmail.com>
Cc: "gregkh @ suse . de" <gregkh@suse.de>,
	"dbrownell @ users . sourceforge . net" 
	<dbrownell@users.sourceforge.net>,
	"stern @ rowland . harvard . edu" <stern@rowland.harvard.edu>,
	"pkondeti @ codeaurora . org" <pkondeti@codeaurora.org>,
	"jacob . jun . pan @ intel . com" <jacob.jun.pan@intel.com>,
	"linux-usb @ vger . kernel . org" <linux-usb@vger.kernel.org>,
	"alek . du @ intel . com" <alek.du@intel.com>,
	"linux-kernel @ vger . kernel . org"
	<linux-kernel@vger.kernel.org>,
	"gadiyar @ ti . com" <gadiyar@ti.com>,
	"ralf @ linux-mips . org" <ralf@linux-mips.org>,
	"linux-mips @ linux-mips . org" <linux-mips@linux-mips.org>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH v5] EHCI bus glue for on-chip PMC MSP USB controller
Date: Thu, 24 Feb 2011 14:28:19 +0300	[thread overview]
Message-ID: <20110224110138.GA28665@bicker> (raw)
In-Reply-To: <1298542755.9950.277.camel@paanoop1-desktop>

On Thu, Feb 24, 2011 at 03:49:15PM +0530, Anoop P A wrote:
> > Also this is dead code.  No one will complain, if you just delete it.
> You mean entire ehci_msp_suspend() ??
> 

Sure why not?  It's not really ready to submit.  People can't complain
about it if you don't submit it.

(Understand that I'm from the peanut gallery.  I'm not in anyway a 
maintainer of this code and my suggestions carry very little weight).

regards,
dan carpenter

  reply	other threads:[~2011-02-24 11:29 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-21 11:06 [PATCH] EHCI support for on-chip PMC MSP USB controller Anoop P
2010-12-21 16:00 ` Alan Stern
2010-12-21 16:00   ` Alan Stern
2010-12-21 17:59   ` Greg KH
2010-12-22 14:34 ` [PATCH V2 0/2] " Anoop P.A
2010-12-22 14:36 ` [PATCH V2 1/2] " Anoop P.A
2010-12-22 14:58   ` Anoop P A
2010-12-24  9:44   ` Shane McDonald
2011-01-27 11:28     ` [PATCH v3] EHCI bus glue " Anoop P.A
2011-02-04 19:56       ` Greg KH
2011-02-09 14:12         ` Anoop P A
2011-02-09 17:20           ` Greg KH
2011-02-09 15:10       ` Matthieu CASTET
2011-02-09 15:44         ` Anoop P A
2011-02-15 10:43       ` [PATCH v4] " Anoop P.A
2011-02-15 17:44         ` Matthieu CASTET
2011-02-22 15:35           ` [PATCH v5] " Anoop P.A
2011-02-22 15:35             ` Anoop P.A
2011-02-22 20:04             ` Dan Carpenter
2011-02-22 20:04               ` Dan Carpenter
2011-02-23 13:22               ` Anoop P A
2011-02-23 13:22                 ` Anoop P A
2011-02-23 17:02                 ` Dan Carpenter
2011-02-23 17:02                   ` Dan Carpenter
2011-02-24 10:19                   ` Anoop P A
2011-02-24 10:19                     ` Anoop P A
2011-02-24 11:28                     ` Dan Carpenter [this message]
2011-02-24 11:28                       ` Dan Carpenter
2011-02-24 13:56                       ` [PATCH] " Anoop P.A
2011-02-24 13:56                         ` Anoop P.A
2010-12-22 14:36 ` [PATCH V2 2/2] MSP onchip root hub over current quirk Anoop P.A
2010-12-23  2:18   ` Alan Stern
2010-12-23  2:18     ` Alan Stern
2010-12-23  9:29     ` Anoop P A
2010-12-23 16:08       ` Alan Stern
2010-12-23 16:08         ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110224110138.GA28665@bicker \
    --to=error27@gmail.com \
    --cc=alek.du@intel.com \
    --cc=anoop.pa@gmail.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gadiyar@ti.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=jacob.jun.pan@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pkondeti@codeaurora.org \
    --cc=ralf@linux-mips.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.