From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Matt Janus <hello@mattjan.us>,
linux-media@vger.kernel.org, Andy Walls <awalls@md.metrocast.net>
Subject: Re: oops cx2341x control handler
Date: Thu, 24 Feb 2011 14:51:30 +0100 [thread overview]
Message-ID: <201102241451.30452.hverkuil@xs4all.nl> (raw)
In-Reply-To: <4D666116.70605@redhat.com>
On Thursday, February 24, 2011 14:45:58 Mauro Carvalho Chehab wrote:
> Em 25-01-2011 19:29, Hans Verkuil escreveu:
> > Hi Matt,
> >
> > On Tuesday, January 25, 2011 03:10:38 Matt Janus wrote:
> >> A quick test with mplayer didn't error, when i tried to use mythtv the driver crashed and resulted in this:
> >
> > I could reproduce this and the fix is below. Please test!
>
> What's the status of this patch? Should it be applied or not?
Absolutely! It's a nasty bug.
Regards,
Hans
>
> Cheers,
> Mauro
> >
> > Regards,
> >
> > Hans
> >
> > From 6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f Mon Sep 17 00:00:00 2001
> > Message-Id: <6b7c84508e915f26a9b701ef2f5fa0b92ca62f2f.1295990866.git.hverkuil@xs4all.nl>
> > From: Hans Verkuil <hverkuil@xs4all.nl>
> > Date: Tue, 25 Jan 2011 22:25:39 +0100
> > Subject: [PATCH] cx18: fix kernel oops when setting MPEG control before capturing.
> >
> > The cxhdl->priv field was not set initially, only after capturing started.
> >
> > Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
> > ---
> > drivers/media/video/cx18/cx18-driver.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/media/video/cx18/cx18-driver.c b/drivers/media/video/cx18/cx18-driver.c
> > index 869690b..877e201 100644
> > --- a/drivers/media/video/cx18/cx18-driver.c
> > +++ b/drivers/media/video/cx18/cx18-driver.c
> > @@ -713,6 +713,7 @@ static int __devinit cx18_init_struct1(struct cx18 *cx)
> > cx->cxhdl.capabilities = CX2341X_CAP_HAS_TS | CX2341X_CAP_HAS_SLICED_VBI;
> > cx->cxhdl.ops = &cx18_cxhdl_ops;
> > cx->cxhdl.func = cx18_api_func;
> > + cx->cxhdl.priv = &cx->streams[CX18_ENC_STREAM_TYPE_MPG];
> > ret = cx2341x_handler_init(&cx->cxhdl, 50);
> > if (ret)
> > return ret;
>
>
--
Hans Verkuil - video4linux developer - sponsored by Cisco
next prev parent reply other threads:[~2011-02-24 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 2:10 oops cx2341x control handler Matt Janus
2011-01-25 21:29 ` Hans Verkuil
2011-02-24 13:45 ` Mauro Carvalho Chehab
2011-02-24 13:51 ` Hans Verkuil [this message]
2011-02-24 14:27 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102241451.30452.hverkuil@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=awalls@md.metrocast.net \
--cc=hello@mattjan.us \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.