[Bug 29572] New: Radeon card reports wrong temperature when switched off

[Bug 29572] New: Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572

           Summary: Radeon card reports wrong temperature when switched
                    off
           Product: Drivers
           Version: 2.5
    Kernel Version: 2.6.38-rc5
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Video(DRI - non Intel)
        AssignedTo: drivers_video-dri@kernel-bugs.osdl.org
        ReportedBy: mail@3v1n0.net
                CC: mail@3v1n0.net
        Regression: Yes


In previous versions of the kernel (I've tested the 2.6.37 version) when the I
switched off the radeon card using vga_switcheroo libsensors was correctly
reporting that the radeon temperature was 0° (or invalid).

This doesn't happen any more using the latest kernel, in fact (after the commit
20d391d72519527d2266a0166490118b40ff998d, I figure) when my radeon card has
been switched off (or after a suspend/resume cycle) sensors indicates:

radeon-pci-0100
Adapter: PCI adapter
temp1:      +2147355.6°C

This is obiouvsly impossible.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572


Alex Deucher <alexdeucher@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexdeucher@gmail.com




--- Comment #1 from Alex Deucher <alexdeucher@gmail.com>  2011-02-21 15:38:00 ---
When the GPU is powered down, the temperature is undefined as the hw sensor
only works when the GPU is powered up and the mmio bar is mapped.  0°C or
+2147355.6°C are both wrong.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #2 from Marco Trevisan (Treviño) <mail@3v1n0.net>  2011-02-21 16:24:51 ---
Ok, both are wrong... But I'd prefer that 0° would be shown (also as a
confirmation that the card is OFF) instead of an invalid value...

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572


Andrew Morton <akpm@linux-foundation.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |akpm@linux-foundation.org




--- Comment #3 from Andrew Morton <akpm@linux-foundation.org>  2011-02-24 00:13:17 ---
Retaining the old behavior is desirable.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #4 from Alex Deucher <alexdeucher@gmail.com>  2011-02-24 04:36:28 ---
The old behavior was wrong.  The temperature value in the register was
interpreted incorrectly prior to my recent patch (improper handling of signed
values).  Also, if the card is disabled, the value of the mmio registers is
undefined.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #5 from Andrew Morton <akpm@linux-foundation.org>  2011-02-24 05:14:11 ---
(In reply to comment #4)
> The old behavior was wrong.

Don't care really. We shouldn't change interfaces.

>  The temperature value in the register was
> interpreted incorrectly prior to my recent patch (improper handling of signed
> values).

That seems unrelated.

>  Also, if the card is disabled, the value of the mmio registers is
> undefined.

So reads should have returned -EINVAL from day one.  Too late to fix that.  The
best thing to do now would be to detect this situation and to return zero,
preserving the API.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #6 from Alex Deucher <alexdeucher@gmail.com>  2011-02-24 06:19:12 ---
The previous behavior was undefined; it just happened to be 0 for one user. 
It's reading back a register from an MMIO aperture on a disabled PCI device. 
It might read back as 50 for someone else in the same situation.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #7 from Alex Deucher <alexdeucher@gmail.com>  2011-02-24 06:21:01 ---
None of the temperatures potentially returned are accurate when the device is
disabled.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #8 from Andrew Morton <akpm@linux-foundation.org>  2011-02-24 08:14:46 ---
The interface changed.  Why is this so hard to understand?  Change it back! 
It's two lines of code, I expect.

I bet everyone's machine was previously reading zero.  Now it's reading random
crap.  Random crap which can lead userspace to think that the machine is
overheating, which could have fairly serious consequences.

We should never have made that temperature readable when the hardware is
disabled.  Now we have done so, we should return a safe and predictable result.
 Not random non-back-compatible crap!

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572


Oldřich Jedlička <oldium.pro@seznam.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |oldium.pro@seznam.cz




--- Comment #9 from Oldřich Jedlička <oldium.pro@seznam.cz>  2011-02-24 10:54:32 ---
I'm personally not convinced that number 0 is the way to go, because it is
quite close to normal temperatures. It looks like a bug in interface and that
it should return -EINVAL. I know that the interface shouldn't change whenever
possible, but this looks like a real interface bug. I also guess it is nowhere
defined that 0°C means "OFF".

And, by the way, think about the cooling with liquid nitrogen (on some advanced
gamer PCs). Is 0°C out of range? Another, maybe more important, question - is
0°C out of the valid value range of the sensor?

Just my 2 cents, ignore me if I said something wrong :-)

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #10 from Alex Deucher <alexdeucher@gmail.com>  2011-02-24 17:36:13 ---
(In reply to comment #8)
> I bet everyone's machine was previously reading zero.  Now it's reading random
> crap.

It was always reading back random random crap, that's my point!  There was
never a special case to return 0 when the card is disabled.  Now we could
return some fixed value when the card is disabled, but as Oldřich noted, is 0
really a reasonable value?

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #11 from Andrew Morton <akpm@linux-foundation.org>  2011-02-24 18:59:33 ---
(In reply to comment #10)
> is 0 really a reasonable value?

Well no, not really.  I assume that a machine will work OK in -30C ambient, in
which case the chip might actually be running at 0C.  That doesn't seem
terribly harmful though.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572





--- Comment #12 from Oldřich Jedlička <oldium.pro@seznam.cz>  2011-02-25 06:17:11 ---
If you use the value 0°C as "OFF" while it is really a valid value, then you
pass the decision whether the card is off outside of the kernel to the software
reading the temperature. So that the software could not trust the value 0 which
would have double meaning and it would have to verify it from other sources.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in 
Real-Time with Splunk. Collect, index and harness all the fast moving IT data 
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business 
insights. http://p.sf.net/sfu/splunk-dev2dev 
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 29572] Radeon card reports wrong temperature when switched off

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=29572


Alan <alan@lxorguk.ukuu.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |alan@lxorguk.ukuu.org.uk
         Resolution|                            |OBSOLETE




-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.