All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henrik Rydberg" <rydberg@euromail.se>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Benjamin Tissoires" <benjamin.tissoires@enac.fr>,
	"Jiri Kosina" <jkosina@suse.cz>,
	"Stéphane Chatty" <chatty@enac.fr>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: Do not create input devices for feature reports
Date: Wed, 2 Mar 2011 16:02:27 +0100	[thread overview]
Message-ID: <20110302150227.GA1973@polaris.bitmath.org> (raw)
In-Reply-To: <20110301175423.GC27560@core.coreip.homeip.net>

Hi Dmitry,

> > For output devices, the only supported case is EV_LED, which passes
> > events to the input device. It is probably assumed that
> > HID_QUIRK_MULTI_INPUT is false for those devices. Jiri?
> > 
> 
> I am probably late to the party fut the above is not true. Here is an
> example of an USB keyboard (wih LEDs) that is split into two:
> 
> I: Bus=0003 Vendor=046d Product=c30e Version=0110
> N: Name="Logitech HID compliant keyboard"
> P: Phys=usb-0000:00:1d.0-1.2/input0
> S:
> Sysfs=/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.0/input/input3
> U: Uniq=
> H: Handlers=sysrq kbd event3
> B: PROP=0
> B: EV=120013
> B: KEY=1000000000007 ff800000000007ff febeffdff3cfffff fffffffffffffffe
> B: MSC=10
> B: LED=7
> 
> I: Bus=0003 Vendor=046d Product=c30e Version=0110
> N: Name="Logitech HID compliant keyboard"
> P: Phys=usb-0000:00:1d.0-1.2/input1
> S:
> Sysfs=/devices/pci0000:00/0000:00:1d.0/usb2/2-1/2-1.2/2-1.2:1.1/input/input4
> U: Uniq=
> H: Handlers=kbd event4
> B: PROP=0
> B: EV=13
> B: KEY=fff ffffffffffffffff 2000000 387ad800d001 1e000000000000 0
> B: MSC=10
> 
> This was done, most likely, because Logitech decided to reuse usage codes
> for different keys.

This looks like different interfaces though, which should be fine. It
is only in the odd case of mixed input and output reports on the same
interface that the MULTI_INPUT quirk would ever have any strange
effect.

Cheers,
Henrik

  reply	other threads:[~2011-03-02 15:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 18:30 [PATCH] hid: Do not create input devices for feature reports Henrik Rydberg
2011-02-24 19:50 ` Benjamin Tissoires
2011-02-24 19:50   ` Benjamin Tissoires
2011-02-24 20:43   ` Henrik Rydberg
2011-02-25 11:18     ` Benjamin Tissoires
2011-02-25 11:18       ` Benjamin Tissoires
2011-02-25 17:19       ` Henrik Rydberg
2011-03-01 17:54         ` Dmitry Torokhov
2011-03-02 15:02           ` Henrik Rydberg [this message]
2011-03-03  8:07             ` Dmitry Torokhov
2011-03-01 16:03 ` Jiri Kosina
2011-03-01 16:21   ` Benjamin Tissoires
2011-03-01 16:21     ` Benjamin Tissoires
2011-03-01 16:26     ` Jiri Kosina
2011-03-08  3:44       ` Rafi Rubin
2011-03-10 16:16       ` Henrik Rydberg
2011-03-10 18:00         ` Jiri Kosina
2011-03-10 18:04           ` Henrik Rydberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302150227.GA1973@polaris.bitmath.org \
    --to=rydberg@euromail.se \
    --cc=benjamin.tissoires@enac.fr \
    --cc=chatty@enac.fr \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.