From: Greg KH <greg@kroah.com> To: James Bottomley <James.Bottomley@suse.de> Cc: Vasiliy Kulikov <segoon@openwall.com>, security@kernel.org, acpi4asus-user@lists.sourceforge.net, linux-scsi@vger.kernel.org, rtc-linux@googlegroups.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, open-iscsi@googlegroups.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs Date: Tue, 15 Mar 2011 07:18:59 -0700 [thread overview] Message-ID: <20110315141859.GA19442@kroah.com> (raw) In-Reply-To: <1300189828.4017.2.camel@mulgrave.site> On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > > Vasiliy Kulikov (20): > > > > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > > > > leds: lp5521: world-writable sysfs engine* files > > > > > leds: lp5523: world-writable engine* sysfs files > > > > > misc: ep93xx_pwm: world-writable sysfs files > > > > > rtc: rtc-ds1511: world-writable sysfs nvram file > > > > > scsi: aic94xx: world-writable sysfs update_bios file > > > > > scsi: iscsi: world-writable sysfs priv_sess file > > > > > > > > These are still not merged :( > > > > > > OK, so I've not been tracking where we are in the dizzying ride on > > > security systems. However, I thought we landed up in the privilege > > > separation arena using capabilities. That means that world writeable > > > files aren't necessarily a problem as long as the correct capabilities > > > checks are in place, right? > > > > There are no capability checks on sysfs files right now, so these all > > need to be fixed. > > That statement is true but irrelevant, isn't it? There can't be > capabilities within sysfs files because the system that does them has no > idea what the capabilities would be. If there were capabilities checks, > they'd have to be in the implementing routines. Ah, you are correct, sorry for the misunderstanding. > I think the questions are twofold: > > 1. Did anyone actually check for capabilities before assuming world > writeable files were wrong? I do not think so as the majority (i.e. all the ones that I looked at) did no such checks. > 2. Even if there aren't any capabilities checks in the implementing > routines, should there be (are we going the separated > capabilities route vs the monolithic root route)? I think the general consensus is that we go the monolithic root route for sysfs files in that we do not allow them to be world writable. Do you have any exceptions that you know of that do these checks? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: greg@kroah.com (Greg KH) To: linux-arm-kernel@lists.infradead.org Subject: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs Date: Tue, 15 Mar 2011 07:18:59 -0700 [thread overview] Message-ID: <20110315141859.GA19442@kroah.com> (raw) In-Reply-To: <1300189828.4017.2.camel@mulgrave.site> On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > > Vasiliy Kulikov (20): > > > > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > > > > leds: lp5521: world-writable sysfs engine* files > > > > > leds: lp5523: world-writable engine* sysfs files > > > > > misc: ep93xx_pwm: world-writable sysfs files > > > > > rtc: rtc-ds1511: world-writable sysfs nvram file > > > > > scsi: aic94xx: world-writable sysfs update_bios file > > > > > scsi: iscsi: world-writable sysfs priv_sess file > > > > > > > > These are still not merged :( > > > > > > OK, so I've not been tracking where we are in the dizzying ride on > > > security systems. However, I thought we landed up in the privilege > > > separation arena using capabilities. That means that world writeable > > > files aren't necessarily a problem as long as the correct capabilities > > > checks are in place, right? > > > > There are no capability checks on sysfs files right now, so these all > > need to be fixed. > > That statement is true but irrelevant, isn't it? There can't be > capabilities within sysfs files because the system that does them has no > idea what the capabilities would be. If there were capabilities checks, > they'd have to be in the implementing routines. Ah, you are correct, sorry for the misunderstanding. > I think the questions are twofold: > > 1. Did anyone actually check for capabilities before assuming world > writeable files were wrong? I do not think so as the majority (i.e. all the ones that I looked at) did no such checks. > 2. Even if there aren't any capabilities checks in the implementing > routines, should there be (are we going the separated > capabilities route vs the monolithic root route)? I think the general consensus is that we go the monolithic root route for sysfs files in that we do not allow them to be world writable. Do you have any exceptions that you know of that do these checks? thanks, greg k-h
next prev parent reply other threads:[~2011-03-15 14:22 UTC|newest] Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-04 12:22 [PATCH 00/20] world-writable files in sysfs and debugfs Vasiliy Kulikov 2011-02-04 12:22 ` Vasiliy Kulikov 2011-02-04 12:22 ` Vasiliy Kulikov 2011-02-04 12:22 ` Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 01/20] mach-omap2: mux: world-writable debugfs files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 20:09 ` Tony Lindgren 2011-02-04 20:09 ` Tony Lindgren 2011-02-04 12:23 ` [PATCH 02/20] mach-omap2: pm: world-writable debugfs timer files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 20:10 ` Tony Lindgren 2011-02-04 20:10 ` Tony Lindgren 2011-02-04 22:53 ` Kevin Hilman 2011-02-04 22:53 ` Kevin Hilman 2011-02-04 12:23 ` [PATCH 03/20] mach-omap2: smartreflex: world-writable debugfs voltage files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 20:10 ` Tony Lindgren 2011-02-04 20:10 ` Tony Lindgren 2011-02-04 22:54 ` Kevin Hilman 2011-02-04 22:54 ` Kevin Hilman 2011-02-07 5:33 ` Menon, Nishanth 2011-02-07 5:33 ` Menon, Nishanth 2011-02-04 12:23 ` [PATCH 04/20] mach-ux500: mbox-db5500: world-writable sysfs fifo file Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 05/20] leds: lp5521: world-writable sysfs engine* files Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 06/20] leds: lp5523: world-writable engine* sysfs files Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 07/20] video: sn9c102: world-wirtable " Vasiliy Kulikov 2011-02-04 15:29 ` Mauro Carvalho Chehab 2011-02-04 20:28 ` Luca Risolia 2011-02-04 12:23 ` [PATCH 08/20] mfd: ab3100: world-writable debugfs *_priv files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-18 17:01 ` Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 09/20] mfd: ab3500: world-writable debugfs register-* files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 10/20] mfd: ab8500: " Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 11/20] misc: ep93xx_pwm: world-writable sysfs files Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 12/20] net: can: at91_can: " Vasiliy Kulikov 2011-02-04 12:42 ` Kurt Van Dijck 2011-02-04 12:42 ` Kurt Van Dijck 2011-02-04 21:06 ` David Miller 2011-02-04 21:06 ` David Miller 2011-02-07 11:38 ` About bittiming calculation result Tomoya MORINAGA 2011-02-07 12:00 ` Wolfgang Grandegger 2011-02-07 12:00 ` Wolfgang Grandegger 2011-02-07 15:52 ` Wolfgang Grandegger 2011-02-07 15:52 ` Wolfgang Grandegger 2011-02-08 1:27 ` Tomoya MORINAGA 2011-02-08 1:27 ` Tomoya MORINAGA 2011-02-08 7:57 ` Wolfgang Grandegger 2011-02-08 7:57 ` Wolfgang Grandegger 2011-02-08 1:09 ` Tomoya MORINAGA 2011-02-08 1:09 ` Tomoya MORINAGA 2011-02-08 3:29 ` Bhupesh SHARMA 2011-02-08 3:29 ` Bhupesh SHARMA 2011-02-08 4:11 ` Tomoya MORINAGA 2011-02-08 4:11 ` Tomoya MORINAGA 2011-02-04 12:23 ` [PATCH 13/20] net: can: janz-ican3: world-writable sysfs termination file Vasiliy Kulikov 2011-02-04 21:06 ` David Miller 2011-02-04 21:06 ` David Miller 2011-02-04 12:23 ` [PATCH 14/20] platform: x86: acer-wmi: world-writable sysfs threeg file Vasiliy Kulikov 2011-02-04 12:23 ` [PATCH 15/20] platform: x86: asus_acpi: world-writable procfs files Vasiliy Kulikov 2011-02-04 12:23 ` Vasiliy Kulikov 2011-02-04 12:53 ` Corentin Chary 2011-02-04 12:24 ` [PATCH 16/20] platform: x86: tc1100-wmi: world-writable sysfs wireless and jogdial files Vasiliy Kulikov 2011-02-04 12:24 ` [PATCH 17/20] rtc: rtc-ds1511: world-writable sysfs nvram file Vasiliy Kulikov 2011-02-04 12:24 ` [PATCH 18/20] scsi: aic94xx: world-writable sysfs update_bios file Vasiliy Kulikov 2011-02-04 12:24 ` [PATCH 19/20] scsi: iscsi: world-writable sysfs priv_sess file Vasiliy Kulikov 2011-03-13 8:28 ` Mike Christie 2011-03-13 8:28 ` Mike Christie 2011-02-04 12:24 ` [PATCH 20/20] fs: ubifs: world-writable debugfs dump_* files Vasiliy Kulikov 2011-02-04 12:24 ` Vasiliy Kulikov 2011-02-06 15:16 ` Artem Bityutskiy 2011-02-06 15:16 ` Artem Bityutskiy 2011-02-04 13:11 ` [rtc-linux] [PATCH 00/20] world-writable files in sysfs and debugfs Linus Walleij 2011-02-04 13:11 ` Linus Walleij 2011-02-04 13:11 ` Linus Walleij 2011-02-04 13:11 ` Linus Walleij 2011-02-21 11:42 ` Samuel Ortiz 2011-03-12 20:23 ` Vasiliy Kulikov 2011-03-12 20:23 ` Vasiliy Kulikov 2011-03-12 20:23 ` Vasiliy Kulikov 2011-03-14 22:18 ` [Security] " Andrew Morton 2011-03-14 22:18 ` Andrew Morton 2011-03-15 2:26 ` James Bottomley 2011-03-15 2:26 ` James Bottomley 2011-03-15 3:09 ` [Security] " Greg KH 2011-03-15 3:09 ` Greg KH 2011-03-15 11:50 ` James Bottomley 2011-03-15 11:50 ` James Bottomley 2011-03-15 14:18 ` Greg KH [this message] 2011-03-15 14:18 ` Greg KH 2011-03-15 14:25 ` James Bottomley 2011-03-15 14:25 ` James Bottomley 2011-03-15 16:08 ` Vasiliy Kulikov 2011-03-15 16:08 ` Vasiliy Kulikov 2011-03-15 16:32 ` James Bottomley 2011-03-15 16:32 ` James Bottomley 2011-03-15 16:32 ` James Bottomley 2011-03-12 20:23 ` Vasiliy Kulikov 2011-03-12 20:23 ` Vasiliy Kulikov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110315141859.GA19442@kroah.com \ --to=greg@kroah.com \ --cc=James.Bottomley@suse.de \ --cc=acpi4asus-user@lists.sourceforge.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=open-iscsi@googlegroups.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=rtc-linux@googlegroups.com \ --cc=security@kernel.org \ --cc=segoon@openwall.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.