[PATCH stable] PCI: return correct value when writing to the "reset" attribute

* [PATCH stable] PCI: return correct value when writing to the "reset" attribute
@ 2011-03-23 12:21 Michael S. Tsirkin
  2011-03-23 22:50 ` [stable] " Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2011-03-23 12:21 UTC (permalink / raw)
  To: stable
  Cc: Jesse Barnes, Michal Schmidt, Tejun Heo, Christoph Lameter,
	linux-pci, linux-kernel

commit 447c5dd7338638f526e9bcf7dcf69b4da5835c7d
Author: Michal Schmidt <mschmidt@redhat.com>
Date:   Tue May 11 11:44:54 2010 +0200

A successful write() to the "reset" sysfs attribute should return the
number of bytes written, not 0. Otherwise userspace (bash) retries the
write over and over again.

Acked-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Applies without changes to all of 2.6.32,2.6.33,2.6.34

This bug is starting to bite userspace, it seems that the right thing to
do is to fix the bug in stable kernels.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

---
 drivers/pci/pci-sysfs.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 3a3b911..e44682c 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -939,7 +939,12 @@ static ssize_t reset_store(struct device *dev,
 
 	if (val != 1)
 		return -EINVAL;
-	return pci_reset_function(pdev);
+
+	result = pci_reset_function(pdev);
+	if (result < 0)
+		return result;
+
+	return count;
 }
 
 static struct device_attribute reset_attr = __ATTR(reset, 0200, NULL, reset_store);
-- 
1.7.3.2.91.g446ac

^ permalink raw reply related	[flat|nested] 2+ messages in thread