* [PATCH] FIX: imsm: Do not change serial if disk failed
@ 2011-03-23 16:36 Krzysztof Wojcik
2011-03-23 23:17 ` NeilBrown
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Wojcik @ 2011-03-23 16:36 UTC (permalink / raw)
To: neilb
Cc: linux-raid, wojciech.neubauer, adam.kwolek, dan.j.williams,
ed.ciechanowski
This patch rollback one change connected with mdadm-OROM
compatibility:
adding ':0' at the end of disk serial number if disk is
detected as failed.
Current mdadm's implementation does not distinguish two
cases when disk is marked as failed:
1. If disk is really failed- disconnected, broken
2. Just marked as failed by mdadm- using "-f" option
Second case is not yet fully handled and compatible with
IMSM standard.
Changing serial number of existing, operational disk causes
problems in "thunderdome" and "load_super" functions that use
serial numbers to disks comparisons and searching.
The change must be recalled until full support will be
developed.
Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
---
super-intel.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 2b41e08..a91bcc2 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -5232,11 +5232,6 @@ static int mark_failure(struct imsm_dev *dev, struct imsm_disk *disk, int idx)
if (is_failed(disk) && (ord & IMSM_ORD_REBUILD))
return 0;
- sprintf(buf, "%s:0", disk->serial);
- if ((len = strlen(buf)) >= MAX_RAID_SERIAL_LEN)
- shift = len - MAX_RAID_SERIAL_LEN + 1;
- strncpy((char *)disk->serial, &buf[shift], MAX_RAID_SERIAL_LEN);
-
disk->status |= FAILED_DISK;
set_imsm_ord_tbl_ent(map, slot, idx | IMSM_ORD_REBUILD);
if (map->failed_disk_num == 0xff)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] FIX: imsm: Do not change serial if disk failed
2011-03-23 16:36 [PATCH] FIX: imsm: Do not change serial if disk failed Krzysztof Wojcik
@ 2011-03-23 23:17 ` NeilBrown
2011-03-24 15:42 ` Wojcik, Krzysztof
0 siblings, 1 reply; 3+ messages in thread
From: NeilBrown @ 2011-03-23 23:17 UTC (permalink / raw)
To: Krzysztof Wojcik
Cc: linux-raid, wojciech.neubauer, adam.kwolek, dan.j.williams,
ed.ciechanowski
On Wed, 23 Mar 2011 17:36:29 +0100 Krzysztof Wojcik
<krzysztof.wojcik@intel.com> wrote:
> This patch rollback one change connected with mdadm-OROM
> compatibility:
> adding ':0' at the end of disk serial number if disk is
> detected as failed.
> Current mdadm's implementation does not distinguish two
> cases when disk is marked as failed:
> 1. If disk is really failed- disconnected, broken
> 2. Just marked as failed by mdadm- using "-f" option
>
> Second case is not yet fully handled and compatible with
> IMSM standard.
> Changing serial number of existing, operational disk causes
> problems in "thunderdome" and "load_super" functions that use
> serial numbers to disks comparisons and searching.
> The change must be recalled until full support will be
> developed.
>
> Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
> ---
> super-intel.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 2b41e08..a91bcc2 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5232,11 +5232,6 @@ static int mark_failure(struct imsm_dev *dev, struct imsm_disk *disk, int idx)
> if (is_failed(disk) && (ord & IMSM_ORD_REBUILD))
> return 0;
>
> - sprintf(buf, "%s:0", disk->serial);
> - if ((len = strlen(buf)) >= MAX_RAID_SERIAL_LEN)
> - shift = len - MAX_RAID_SERIAL_LEN + 1;
> - strncpy((char *)disk->serial, &buf[shift], MAX_RAID_SERIAL_LEN);
> -
> disk->status |= FAILED_DISK;
> set_imsm_ord_tbl_ent(map, slot, idx | IMSM_ORD_REBUILD);
> if (map->failed_disk_num == 0xff)
Applied thanks.
That was my last remaining issue before I'm comfortable releasing
mdadm-3.2.1
Does Intel have anything concerns about releasing the current code as
mdadm-3.2.1?
Thanks,
NeilBrown
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] FIX: imsm: Do not change serial if disk failed
2011-03-23 23:17 ` NeilBrown
@ 2011-03-24 15:42 ` Wojcik, Krzysztof
0 siblings, 0 replies; 3+ messages in thread
From: Wojcik, Krzysztof @ 2011-03-24 15:42 UTC (permalink / raw)
To: NeilBrown
Cc: linux-raid, Neubauer, Wojciech, Kwolek, Adam, Williams, Dan J,
Ciechanowski, Ed
> -----Original Message-----
> From: linux-raid-owner@vger.kernel.org [mailto:linux-raid-
> owner@vger.kernel.org] On Behalf Of NeilBrown
> Sent: Thursday, March 24, 2011 12:18 AM
> To: Wojcik, Krzysztof
> Cc: linux-raid@vger.kernel.org; Neubauer, Wojciech; Kwolek, Adam;
> Williams, Dan J; Ciechanowski, Ed
> Subject: Re: [PATCH] FIX: imsm: Do not change serial if disk failed
>
> That was my last remaining issue before I'm comfortable releasing
> mdadm-3.2.1
> Does Intel have anything concerns about releasing the current code as
> mdadm-3.2.1?
Neil,
We have only two patches for test suite. Anna will sent them today.
After applying this, we are ready to 3.2.1 release.
Regards
Krzysztof
>
> Thanks,
> NeilBrown
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-24 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-23 16:36 [PATCH] FIX: imsm: Do not change serial if disk failed Krzysztof Wojcik
2011-03-23 23:17 ` NeilBrown
2011-03-24 15:42 ` Wojcik, Krzysztof
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.