* [PATCH 0/2] bonding:delete two unused variables
@ 2011-04-11 8:17 Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 1/2] bonding:delete unused alb_timer Weiping Pan(潘卫平)
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Weiping Pan(潘卫平) @ 2011-04-11 8:17 UTC (permalink / raw)
To: fubar, andy; +Cc: netdev, linux-kernel, Weiping Pan
I found that variable alb_timer and rlb_interval_counter in struct
alb_bond_info are not used by other codes any more, so delete them.
Weiping Pan(潘卫平) (2):
bonding:delete unused alb_timer
bonding:delete unused rlb_interval_counter
drivers/net/bonding/bond_alb.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
--
1.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] bonding:delete unused alb_timer
2011-04-11 8:17 [PATCH 0/2] bonding:delete two unused variables Weiping Pan(潘卫平)
@ 2011-04-11 8:17 ` Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 2/2] bonding:delete unused rlb_interval_counter Weiping Pan(潘卫平)
2011-04-11 19:02 ` [PATCH 0/2] bonding:delete two unused variables Jay Vosburgh
2 siblings, 0 replies; 6+ messages in thread
From: Weiping Pan(潘卫平) @ 2011-04-11 8:17 UTC (permalink / raw)
To: fubar, andy; +Cc: netdev, linux-kernel, Weiping Pan
Now bonding-alb uses delayed_work instead of timer_list.
Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
---
drivers/net/bonding/bond_alb.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_alb.h b/drivers/net/bonding/bond_alb.h
index 86861f0..f2a1d0a 100644
--- a/drivers/net/bonding/bond_alb.h
+++ b/drivers/net/bonding/bond_alb.h
@@ -122,7 +122,6 @@ struct tlb_slave_info {
};
struct alb_bond_info {
- struct timer_list alb_timer;
struct tlb_client_info *tx_hashtbl; /* Dynamically allocated */
spinlock_t tx_hashtbl_lock;
u32 unbalanced_load;
--
1.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] bonding:delete unused rlb_interval_counter
2011-04-11 8:17 [PATCH 0/2] bonding:delete two unused variables Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 1/2] bonding:delete unused alb_timer Weiping Pan(潘卫平)
@ 2011-04-11 8:17 ` Weiping Pan(潘卫平)
2011-04-11 19:02 ` [PATCH 0/2] bonding:delete two unused variables Jay Vosburgh
2 siblings, 0 replies; 6+ messages in thread
From: Weiping Pan(潘卫平) @ 2011-04-11 8:17 UTC (permalink / raw)
To: fubar, andy; +Cc: netdev, linux-kernel, Weiping Pan
Now, alb_bond_info uses rx_ntt,rlb_update_delay_counter and
rlb_update_retry_counter to decide when to call rlb_update_rx_clients().
Signed-off-by: Weiping Pan(潘卫平) <panweiping3@gmail.com>
---
drivers/net/bonding/bond_alb.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/bonding/bond_alb.h b/drivers/net/bonding/bond_alb.h
index f2a1d0a..01ed1fb 100644
--- a/drivers/net/bonding/bond_alb.h
+++ b/drivers/net/bonding/bond_alb.h
@@ -139,7 +139,6 @@ struct alb_bond_info {
struct slave *next_rx_slave;/* next slave to be assigned
* to a new rx client for
*/
- u32 rlb_interval_counter;
u8 primary_is_promisc; /* boolean */
u32 rlb_promisc_timeout_counter;/* counts primary
* promiscuity time
--
1.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] bonding:delete two unused variables
2011-04-11 8:17 [PATCH 0/2] bonding:delete two unused variables Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 1/2] bonding:delete unused alb_timer Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 2/2] bonding:delete unused rlb_interval_counter Weiping Pan(潘卫平)
@ 2011-04-11 19:02 ` Jay Vosburgh
2011-04-11 20:16 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Jay Vosburgh @ 2011-04-11 19:02 UTC (permalink / raw)
To: Weiping Pan(潘卫平); +Cc: andy, netdev, linux-kernel
>I found that variable alb_timer and rlb_interval_counter in struct
>alb_bond_info are not used by other codes any more, so delete them.
>
>Weiping Pan(潘卫平) (2):
> bonding:delete unused alb_timer
> bonding:delete unused rlb_interval_counter
For both patches.
Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> drivers/net/bonding/bond_alb.h | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
>--
>1.7.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] bonding:delete two unused variables
2011-04-11 19:02 ` [PATCH 0/2] bonding:delete two unused variables Jay Vosburgh
@ 2011-04-11 20:16 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-04-11 20:16 UTC (permalink / raw)
To: fubar; +Cc: panweiping3, andy, netdev, linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 581 bytes --]
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 11 Apr 2011 12:02:09 -0700
>
>>I found that variable alb_timer and rlb_interval_counter in struct
>>alb_bond_info are not used by other codes any more, so delete them.
>>
>>Weiping Pan(æ½å«å¹³) (2):
>> bonding:delete unused alb_timer
>> bonding:delete unused rlb_interval_counter
>
> For both patches.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] bonding:delete two unused variables
@ 2011-04-11 20:16 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-04-11 20:16 UTC (permalink / raw)
To: fubar; +Cc: panweiping3, andy, netdev, linux-kernel
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 11 Apr 2011 12:02:09 -0700
>
>>I found that variable alb_timer and rlb_interval_counter in struct
>>alb_bond_info are not used by other codes any more, so delete them.
>>
>>Weiping Pan(潘卫平) (2):
>> bonding:delete unused alb_timer
>> bonding:delete unused rlb_interval_counter
>
> For both patches.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-11 20:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-11 8:17 [PATCH 0/2] bonding:delete two unused variables Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 1/2] bonding:delete unused alb_timer Weiping Pan(潘卫平)
2011-04-11 8:17 ` [PATCH 2/2] bonding:delete unused rlb_interval_counter Weiping Pan(潘卫平)
2011-04-11 19:02 ` [PATCH 0/2] bonding:delete two unused variables Jay Vosburgh
2011-04-11 20:16 ` David Miller
2011-04-11 20:16 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.