From: David Miller <davem@davemloft.net>
To: dwalter@barracuda.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ipv6: RTA_PREFSRC support for ipv6 route source address selection
Date: Tue, 12 Apr 2011 15:16:59 -0700 (PDT) [thread overview]
Message-ID: <20110412.151659.15244967.davem@davemloft.net> (raw)
In-Reply-To: <20110412.150511.35038648.davem@davemloft.net>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: Text/Plain; charset=utf-8, Size: 1123 bytes --]
From: David Miller <davem@davemloft.net>
Date: Tue, 12 Apr 2011 15:05:11 -0700 (PDT)
> From: Daniel Walter <dwalter@barracuda.com>
> Date: Mon, 11 Apr 2011 09:03:29 +0200
>
>> [ipv6] Add support for RTA_PREFSRC
>>
>> This patch allows a user to select the preferred source address
>> for a specific IPv6-Route. It can be set via a netlink message
>> setting RTA_PREFSRC to a valid IPv6 address which must be
>> up on the device the route will be bound to.
>>
>>
>> Signed-off-by: Daniel Walter <dwalter@barracuda.com>
>
> Ok, I can live with this, applied, thanks!
Sorry, I had to revert.
Please fix this warning, test your patch, and resubmit it.
net/ipv6/ip6_output.c: In function ‘ip6_dst_lookup_tail’:
net/ipv6/ip6_output.c:936: warning: passing argument 3 of ‘ip6_route_get_saddr’ from incompatible pointer type
include/net/ip6_route.h:87: note: expected ‘struct in6_addr *’ but argument is of type ‘struct dst_entry **’
Thanks.
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: dwalter@barracuda.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ipv6: RTA_PREFSRC support for ipv6 route source address selection
Date: Tue, 12 Apr 2011 15:16:59 -0700 (PDT) [thread overview]
Message-ID: <20110412.151659.15244967.davem@davemloft.net> (raw)
In-Reply-To: <20110412.150511.35038648.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Tue, 12 Apr 2011 15:05:11 -0700 (PDT)
> From: Daniel Walter <dwalter@barracuda.com>
> Date: Mon, 11 Apr 2011 09:03:29 +0200
>
>> [ipv6] Add support for RTA_PREFSRC
>>
>> This patch allows a user to select the preferred source address
>> for a specific IPv6-Route. It can be set via a netlink message
>> setting RTA_PREFSRC to a valid IPv6 address which must be
>> up on the device the route will be bound to.
>>
>>
>> Signed-off-by: Daniel Walter <dwalter@barracuda.com>
>
> Ok, I can live with this, applied, thanks!
Sorry, I had to revert.
Please fix this warning, test your patch, and resubmit it.
net/ipv6/ip6_output.c: In function ‘ip6_dst_lookup_tail’:
net/ipv6/ip6_output.c:936: warning: passing argument 3 of ‘ip6_route_get_saddr’ from incompatible pointer type
include/net/ip6_route.h:87: note: expected ‘struct in6_addr *’ but argument is of type ‘struct dst_entry **’
Thanks.
next prev parent reply other threads:[~2011-04-12 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 7:03 [PATCH 1/1] ipv6: RTA_PREFSRC support for ipv6 route source address selection Daniel Walter
2011-04-11 7:03 ` Daniel Walter
2011-04-12 22:05 ` David Miller
2011-04-12 22:05 ` David Miller
2011-04-12 22:16 ` David Miller [this message]
2011-04-12 22:16 ` David Miller
2011-04-14 7:10 Daniel Walter
2011-04-14 14:01 ` Stephen Clark
2011-04-14 14:24 ` YOSHIFUJI Hideaki
2011-04-14 14:49 ` Daniel Walter
2011-04-14 15:02 ` Stephen Clark
2011-04-15 22:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412.151659.15244967.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwalter@barracuda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.