* [Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response
2011-04-11 15:44 [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response jvesely
@ 2011-04-11 15:44 ` jvesely
2011-04-11 21:35 ` Brad Hards
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: jvesely @ 2011-04-11 15:44 UTC (permalink / raw)
To: qemu-devel
** Patch added: "report error on stall response"
https://bugs.launchpad.net/bugs/757654/+attachment/2017520/+files/usb_stall.patch
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/757654
Title:
UHCI fails to signal stall response
Status in QEMU:
New
Bug description:
When TD execution results in STALL error (STALL handshake, no stall as
a result of err count reaching 0), there is no way to know about it
except for checking that TD. IMO it is an error condition and it
should be reflected in the status register (and issue an interrupt if
enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response
@ 2011-04-11 15:44 jvesely
2011-04-11 15:44 ` [Qemu-devel] [Bug 757654] " jvesely
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: jvesely @ 2011-04-11 15:44 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
When TD execution results in STALL error (STALL handshake, no stall as a
result of err count reaching 0), there is no way to know about it except
for checking that TD. IMO it is an error condition and it should be
reflected in the status register (and issue an interrupt if enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/757654
Title:
UHCI fails to signal stall response
Status in QEMU:
New
Bug description:
When TD execution results in STALL error (STALL handshake, no stall as
a result of err count reaching 0), there is no way to know about it
except for checking that TD. IMO it is an error condition and it
should be reflected in the status register (and issue an interrupt if
enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response
2011-04-11 15:44 [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response jvesely
2011-04-11 15:44 ` [Qemu-devel] [Bug 757654] " jvesely
@ 2011-04-11 21:35 ` Brad Hards
2011-04-14 10:35 ` jvesely
2016-08-17 11:33 ` T. Huth
3 siblings, 0 replies; 6+ messages in thread
From: Brad Hards @ 2011-04-11 21:35 UTC (permalink / raw)
To: qemu-devel
Hi,
Thanks for reporting this issue.
Just so you are aware: the qemu USB maintainer is probably going to be
away for a while longer, so don't be too worried if this patch doesn't
get looked at for 2-4 weeks.
Brad
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/757654
Title:
UHCI fails to signal stall response
Status in QEMU:
New
Bug description:
When TD execution results in STALL error (STALL handshake, no stall as
a result of err count reaching 0), there is no way to know about it
except for checking that TD. IMO it is an error condition and it
should be reflected in the status register (and issue an interrupt if
enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response
2011-04-11 15:44 [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response jvesely
2011-04-11 15:44 ` [Qemu-devel] [Bug 757654] " jvesely
2011-04-11 21:35 ` Brad Hards
@ 2011-04-14 10:35 ` jvesely
2011-04-14 11:11 ` Stefan Hajnoczi
2016-08-17 11:33 ` T. Huth
3 siblings, 1 reply; 6+ messages in thread
From: jvesely @ 2011-04-14 10:35 UTC (permalink / raw)
To: qemu-devel
No problem, it's not like it breaks something. This fix just makes
driver development easier.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/757654
Title:
UHCI fails to signal stall response
Status in QEMU:
New
Bug description:
When TD execution results in STALL error (STALL handshake, no stall as
a result of err count reaching 0), there is no way to know about it
except for checking that TD. IMO it is an error condition and it
should be reflected in the status register (and issue an interrupt if
enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response
2011-04-14 10:35 ` jvesely
@ 2011-04-14 11:11 ` Stefan Hajnoczi
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Hajnoczi @ 2011-04-14 11:11 UTC (permalink / raw)
To: Bug 757654; +Cc: qemu-devel
On Thu, Apr 14, 2011 at 11:35 AM, jvesely <757654@bugs.launchpad.net> wrote:
> No problem, it's not like it breaks something. This fix just makes
> driver development easier.
Please send your patch to the mailing list:
http://wiki.qemu.org/Contribute/SubmitAPatch
It may seem petty to ask this since you've already attached it to the
bug, but for QEMU development to scale and keep at a rapid pace,
everyone needs to follow these steps on submitting patches. Thanks
for your effort!
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response
2011-04-11 15:44 [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response jvesely
` (2 preceding siblings ...)
2011-04-14 10:35 ` jvesely
@ 2016-08-17 11:33 ` T. Huth
3 siblings, 0 replies; 6+ messages in thread
From: T. Huth @ 2016-08-17 11:33 UTC (permalink / raw)
To: qemu-devel
Patch had been included here:
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=8656954aedbd9995e68e
... so closing this ticket now.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/757654
Title:
UHCI fails to signal stall response
Status in QEMU:
Fix Released
Bug description:
When TD execution results in STALL error (STALL handshake, no stall as
a result of err count reaching 0), there is no way to know about it
except for checking that TD. IMO it is an error condition and it
should be reflected in the status register (and issue an interrupt if
enabled).
Ways to replicate:
Send a query that is answered by stall (like set_idle request to a mouse)
Expected behavior:
UHCI hc sets status bit 1 (usb error interrupt) and issues an interrupt
current behavior:
Neither status bit is set nor interrupt triggered
Version 0.14
attached patch for current master (quick fix, it might be I got something wrong)
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/757654/+subscriptions
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-17 11:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-11 15:44 [Qemu-devel] [Bug 757654] [NEW] UHCI fails to signal stall response jvesely
2011-04-11 15:44 ` [Qemu-devel] [Bug 757654] " jvesely
2011-04-11 21:35 ` Brad Hards
2011-04-14 10:35 ` jvesely
2011-04-14 11:11 ` Stefan Hajnoczi
2016-08-17 11:33 ` T. Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.