* [PATCH] sparc32: avoid build warning at mm/percpu.c:1647
@ 2011-04-20 9:57 Daniel Hellstrom
2011-04-20 10:18 ` Sam Ravnborg
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Daniel Hellstrom @ 2011-04-20 9:57 UTC (permalink / raw)
To: sparclinux
Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
---
arch/sparc/include/asm/pgtable_32.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/include/asm/pgtable_32.h b/arch/sparc/include/asm/pgtable_32.h
index 303bd4d..5aa2e9c 100644
--- a/arch/sparc/include/asm/pgtable_32.h
+++ b/arch/sparc/include/asm/pgtable_32.h
@@ -456,9 +456,9 @@ extern int io_remap_pfn_range(struct vm_area_struct *vma,
#endif /* !(__ASSEMBLY__) */
-#define VMALLOC_START 0xfe600000
+#define VMALLOC_START 0xfe600000UL
/* XXX Alter this when I get around to fixing sun4c - Anton */
-#define VMALLOC_END 0xffc00000
+#define VMALLOC_END 0xffc00000UL
/* We provide our own get_unmapped_area to cope with VA holes for userland */
--
1.5.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] sparc32: avoid build warning at mm/percpu.c:1647
2011-04-20 9:57 [PATCH] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
@ 2011-04-20 10:18 ` Sam Ravnborg
2011-04-21 18:03 ` David Miller
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2011-04-20 10:18 UTC (permalink / raw)
To: sparclinux
On Wed, Apr 20, 2011 at 11:57:28AM +0200, Daniel Hellstrom wrote:
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> ---
> arch/sparc/include/asm/pgtable_32.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
I guess this is the same warnign that has annoyed me.
In general always include the warning that you fix,
so we can google for it etc.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sparc32: avoid build warning at mm/percpu.c:1647
2011-04-20 9:57 [PATCH] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
2011-04-20 10:18 ` Sam Ravnborg
@ 2011-04-21 18:03 ` David Miller
2011-04-21 18:50 ` daniel
2011-04-21 18:58 ` daniel
3 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2011-04-21 18:03 UTC (permalink / raw)
To: sparclinux
From: Daniel Hellstrom <daniel@gaisler.com>
Date: Wed, 20 Apr 2011 11:57:28 +0200
> Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
I find it amazing that this patch builds, yet with current tools it
does.
It seems that some time in the recent past, binutils started accepting
constants in assembler that have type tag suffixes such as "UL".
But I know that older binutils do not accept this, and we use
VMALLOC_{START,END} in arch/sparc/kernel/entry.S
So please use the mechanism we have in place to handle this problem,
include linux/const.h and use the AC() macros as we do in pgtable_64.h
for this.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sparc32: avoid build warning at mm/percpu.c:1647
2011-04-20 9:57 [PATCH] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
2011-04-20 10:18 ` Sam Ravnborg
2011-04-21 18:03 ` David Miller
@ 2011-04-21 18:50 ` daniel
2011-04-21 18:58 ` daniel
3 siblings, 0 replies; 5+ messages in thread
From: daniel @ 2011-04-21 18:50 UTC (permalink / raw)
To: sparclinux
On Thu, 21 Apr 2011 11:03:56 -0700 (PDT), David Miller wrote:
From: Daniel Hellstrom <daniel@gaisler.com>
> Date: Wed, 20 Apr 2011 11:57:28 +0200
>
> > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
>
> So please use the mechanism we have in place to handle this problem,
> include linux/const.h and use the AC() macros as we do in pgtable_64.h
> for this.
Had forgotten that, will try to resend it tomorrow... unless Sam is quicker :)
Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sparc32: avoid build warning at mm/percpu.c:1647
2011-04-20 9:57 [PATCH] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
` (2 preceding siblings ...)
2011-04-21 18:50 ` daniel
@ 2011-04-21 18:58 ` daniel
3 siblings, 0 replies; 5+ messages in thread
From: daniel @ 2011-04-21 18:58 UTC (permalink / raw)
To: sparclinux
On Thu, 21 Apr 2011 14:50:02 -0400, daniel@gaisler.com wrote:
>
> On Thu, 21 Apr 2011 11:03:56 -0700 (PDT), David Miller wrote:
> From: Daniel Hellstrom <daniel@gaisler.com>
> > Date: Wed, 20 Apr 2011 11:57:28 +0200
> >
> > > Signed-off-by: Daniel Hellstrom <daniel@gaisler.com>
> >
> > So please use the mechanism we have in place to handle this problem,
> > include linux/const.h and use the AC() macros as we do in pgtable_64.h
> > for this. Had forgotten that, will try to resend it tomorrow...
> unless Sam is quicker :)
>
Sam was quicker... I'm getting old... :(
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-04-21 18:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-20 9:57 [PATCH] sparc32: avoid build warning at mm/percpu.c:1647 Daniel Hellstrom
2011-04-20 10:18 ` Sam Ravnborg
2011-04-21 18:03 ` David Miller
2011-04-21 18:50 ` daniel
2011-04-21 18:58 ` daniel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.