All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Mike Rapoport <mike@compulab.co.il>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] omap: fix build when MTD_NAND_OMAP2 and TOUCHSCREEN_ADS7846 are disabled
Date: Fri, 6 May 2011 00:25:23 -0700	[thread overview]
Message-ID: <20110506072523.GA25670@atomide.com> (raw)
In-Reply-To: <53A11D3C-4DBA-4772-AF14-3590772F6AA1@linuxhacker.ru>

* Oleg Drokin <green@linuxhacker.ru> [110504 08:59]:
> Hello!
> 
> On May 4, 2011, at 9:27 AM, Mike Rapoport wrote:
> 
> > Commits 5e6a64b36ce346b7a2d481ef9fa315290eb28e5e (omap: move detection of
> > NAND CS to common-board-devices) and 96974a249b0cf3537f49115a59be67e2c54f315c
> > (omap: consolidate touch screen initialization among different boards)
> > break compilation when CONFIG_MTD_NAND_OMAP2 and
> > CONFIG_TOUCHSCREEN_ADS7846 are not selected.
> > Removing ifdefs and stubs from common-board-devices.h fixes the problem.
> 
> Works for me.

We should not build in code unnecessarily unless the boards has
ads7847. Many boards don't have it.

So how about do the ifdef optimization for ads7846_spi_board_info
and omap_ads7846_init in common-board-devices.c?

That keeps the header clean and the we have all the code in one
place in a way where it's optimized out if not selected.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] omap: fix build when MTD_NAND_OMAP2 and TOUCHSCREEN_ADS7846 are disabled
Date: Fri, 6 May 2011 00:25:23 -0700	[thread overview]
Message-ID: <20110506072523.GA25670@atomide.com> (raw)
In-Reply-To: <53A11D3C-4DBA-4772-AF14-3590772F6AA1@linuxhacker.ru>

* Oleg Drokin <green@linuxhacker.ru> [110504 08:59]:
> Hello!
> 
> On May 4, 2011, at 9:27 AM, Mike Rapoport wrote:
> 
> > Commits 5e6a64b36ce346b7a2d481ef9fa315290eb28e5e (omap: move detection of
> > NAND CS to common-board-devices) and 96974a249b0cf3537f49115a59be67e2c54f315c
> > (omap: consolidate touch screen initialization among different boards)
> > break compilation when CONFIG_MTD_NAND_OMAP2 and
> > CONFIG_TOUCHSCREEN_ADS7846 are not selected.
> > Removing ifdefs and stubs from common-board-devices.h fixes the problem.
> 
> Works for me.

We should not build in code unnecessarily unless the boards has
ads7847. Many boards don't have it.

So how about do the ifdef optimization for ads7846_spi_board_info
and omap_ads7846_init in common-board-devices.c?

That keeps the header clean and the we have all the code in one
place in a way where it's optimized out if not selected.

Regards,

Tony

  reply	other threads:[~2011-05-06  7:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-04 13:27 [PATCH] omap: fix build when MTD_NAND_OMAP2 and TOUCHSCREEN_ADS7846 are disabled Mike Rapoport
2011-05-04 13:27 ` Mike Rapoport
2011-05-04 16:02 ` Oleg Drokin
2011-05-04 16:02   ` Oleg Drokin
2011-05-06  7:25   ` Tony Lindgren [this message]
2011-05-06  7:25     ` Tony Lindgren
2011-05-06 19:58     ` [PATCH v2] " Mike Rapoport
2011-05-06 19:58       ` Mike Rapoport
2011-05-09 15:19       ` Tony Lindgren
2011-05-09 15:19         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110506072523.GA25670@atomide.com \
    --to=tony@atomide.com \
    --cc=green@linuxhacker.ru \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mike@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.