* [PATCH] x86: fix mrst sparse complaints
@ 2011-05-06 22:00 Luis R. Rodriguez
2011-05-06 22:31 ` Alan Cox
2011-05-07 9:46 ` [tip:x86/cleanups] x86: Fix " tip-bot for Luis R. Rodriguez
0 siblings, 2 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2011-05-06 22:00 UTC (permalink / raw)
To: akpm, mingo, tglx, hpa
Cc: x86, linux-kernel, linux-wireless, allen.kao, roman.gezikov,
joonas.viskari, Luis R. Rodriguez
This fixes these few sparse complaints:
CHECK arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
CC arch/x86/platform/mrst/mrst.o
Cc: Roman Gezikov <roman.gezikov@atheros.com>
Cc: Joonas Viskari <joonas.viskari@atheros.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Allen Kao <allen.kao@atheros.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: x86@kernel.org
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
arch/x86/platform/mrst/mrst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
return 0;
}
-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
{
sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
apbt_time_init();
}
-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
{
if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;
--
1.7.4.15.g7811d
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: fix mrst sparse complaints
2011-05-06 22:00 [PATCH] x86: fix mrst sparse complaints Luis R. Rodriguez
@ 2011-05-06 22:31 ` Alan Cox
2011-05-07 9:46 ` [tip:x86/cleanups] x86: Fix " tip-bot for Luis R. Rodriguez
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2011-05-06 22:31 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: akpm, mingo, tglx, hpa, x86, linux-kernel, linux-wireless,
allen.kao, roman.gezikov, joonas.viskari
On Fri, 6 May 2011 15:00:09 -0700
"Luis R. Rodriguez" <lrodriguez@atheros.com> wrote:
> This fixes these few sparse complaints:
>
> CHECK arch/x86/platform/mrst/mrst.c
> arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
> arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
> CC arch/x86/platform/mrst/mrst.o
Please Cc me on Moorestown/Medfield tree stuff. Looks sane enough.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:x86/cleanups] x86: Fix mrst sparse complaints
2011-05-06 22:00 [PATCH] x86: fix mrst sparse complaints Luis R. Rodriguez
2011-05-06 22:31 ` Alan Cox
@ 2011-05-07 9:46 ` tip-bot for Luis R. Rodriguez
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Luis R. Rodriguez @ 2011-05-07 9:46 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, joonas.viskari, lrodriguez, allen.kao,
alan, roman.gezikov, akpm, tglx, mingo
Commit-ID: 8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Gitweb: http://git.kernel.org/tip/8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Author: Luis R. Rodriguez <lrodriguez@atheros.com>
AuthorDate: Fri, 6 May 2011 15:00:09 -0700
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sat, 7 May 2011 10:52:30 +0200
x86: Fix mrst sparse complaints
Fix these Sparse complaints:
CHECK arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Roman Gezikov <roman.gezikov@atheros.com>
Cc: Joonas Viskari <joonas.viskari@atheros.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Allen Kao <allen.kao@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Link: http://lkml.kernel.org/r/1304719209-26913-1-git-send-email-lrodriguez@atheros.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/platform/mrst/mrst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
return 0;
}
-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
{
sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
apbt_time_init();
}
-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
{
if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-07 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-06 22:00 [PATCH] x86: fix mrst sparse complaints Luis R. Rodriguez
2011-05-06 22:31 ` Alan Cox
2011-05-07 9:46 ` [tip:x86/cleanups] x86: Fix " tip-bot for Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.