All of lore.kernel.org
 help / color / mirror / Atom feed
* [Patch] ext4: remove a useless #ifdef in super.c
@ 2011-04-06  6:02 Amerigo Wang
  2011-05-09  2:04 ` Ted Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Amerigo Wang @ 2011-04-06  6:02 UTC (permalink / raw)
  To: linux-kernel
  Cc: akpm, WANG Cong, Theodore Ts'o, Andreas Dilger, linux-ext4

There is already an #ifdef CONFIG_QUOTA some lines above,
so this one is totally useless.

Signed-off-by: WANG Cong <amwang@redhat.com>

---
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 22546ad..a5a73ac 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1170,9 +1170,7 @@ static ssize_t ext4_quota_write(struct super_block *sb, int type,
 				const char *data, size_t len, loff_t off);
 
 static const struct dquot_operations ext4_quota_operations = {
-#ifdef CONFIG_QUOTA
 	.get_reserved_space = ext4_get_reserved_space,
-#endif
 	.write_dquot	= ext4_write_dquot,
 	.acquire_dquot	= ext4_acquire_dquot,
 	.release_dquot	= ext4_release_dquot,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch] ext4: remove a useless #ifdef in super.c
  2011-04-06  6:02 [Patch] ext4: remove a useless #ifdef in super.c Amerigo Wang
@ 2011-05-09  2:04 ` Ted Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-05-09  2:04 UTC (permalink / raw)
  To: Amerigo Wang; +Cc: linux-kernel, akpm, Andreas Dilger, linux-ext4

On Wed, Apr 06, 2011 at 02:02:01PM +0800, Amerigo Wang wrote:
> There is already an #ifdef CONFIG_QUOTA some lines above,
> so this one is totally useless.
> 
> Signed-off-by: WANG Cong <amwang@redhat.com>

Thanks, added to the ext4 tree.

					- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-09  2:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-06  6:02 [Patch] ext4: remove a useless #ifdef in super.c Amerigo Wang
2011-05-09  2:04 ` Ted Ts'o

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.