From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-mmc@vger.kernel.org, openezx-devel@lists.openezx.org,
Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
Date: Tue, 10 May 2011 21:32:33 +0100 [thread overview]
Message-ID: <20110510203233.GA5315@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110510220214.916621d1.ospite@studenti.unina.it>
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote:
> I was blindly trusting code already in mainline again, and for that I
> apologize, I finally took the time to look at the implementation
> of IS_ERR() and test its use, and being IS_ERR(NULL) true it is not what
> we want indeed, see the attached test program.
>
> So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL();
> how does that sound? Am I still missing anything?
That sounds a lot better, and should avoid the issue which caused me to
throw out the original patch.
WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
Date: Tue, 10 May 2011 21:32:33 +0100 [thread overview]
Message-ID: <20110510203233.GA5315@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110510220214.916621d1.ospite@studenti.unina.it>
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote:
> I was blindly trusting code already in mainline again, and for that I
> apologize, I finally took the time to look at the implementation
> of IS_ERR() and test its use, and being IS_ERR(NULL) true it is not what
> we want indeed, see the attached test program.
>
> So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL();
> how does that sound? Am I still missing anything?
That sounds a lot better, and should avoid the issue which caused me to
throw out the original patch.
next prev parent reply other threads:[~2011-05-10 20:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 20:11 [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR Antonio Ospite
2011-05-09 20:11 ` Antonio Ospite
2011-05-09 20:15 ` Mark Brown
2011-05-09 20:15 ` Mark Brown
2011-05-09 20:23 ` Russell King - ARM Linux
2011-05-09 20:23 ` Russell King - ARM Linux
2011-05-09 20:36 ` Mark Brown
2011-05-09 20:36 ` Mark Brown
2011-05-10 20:02 ` Antonio Ospite
2011-05-10 20:02 ` Antonio Ospite
2011-05-10 20:32 ` Russell King - ARM Linux [this message]
2011-05-10 20:32 ` Russell King - ARM Linux
2011-05-10 20:36 ` Mark Brown
2011-05-10 20:36 ` Mark Brown
2011-05-11 10:19 ` [PATCH v2 1/2] pxamci: remove the ifdef CONFIG_REGULATOR Antonio Ospite
2011-05-11 10:19 ` Antonio Ospite
2011-05-11 13:07 ` Mark Brown
2011-05-11 13:07 ` Mark Brown
2011-05-11 14:41 ` Chris Ball
2011-05-11 14:41 ` Chris Ball
2011-05-11 20:19 ` Antonio Ospite
2011-05-11 20:19 ` Antonio Ospite
2011-05-11 10:19 ` [PATCH 2/2] pxamci: fix coding style for multi statement conditionals Antonio Ospite
2011-05-11 10:19 ` Antonio Ospite
2011-05-11 10:26 ` [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR Antonio Ospite
2011-05-11 10:26 ` Antonio Ospite
2011-05-10 11:59 ` Sergei Shtylyov
2011-05-10 11:59 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510203233.GA5315@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cjb@laptop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openezx-devel@lists.openezx.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.