All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-04-02  2:09 ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-02  2:09 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc; +Cc: ben-linux, Kukjin Kim, Russell King

The current mainline codes of ARCH_S5PC100 can not support
suspend to ram. So needs this for preventing build error.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
Oops, I missed this in my previous patch.

As I know, firstly ARCH_S5P64X0 will support suspend to ram
then ARCH_S5PC100 will do it. But right now, we need this.

 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 7c0effb..5c3e232 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2010,7 +2010,7 @@ menu "Power management options"
 source "kernel/power/Kconfig"
 
 config ARCH_SUSPEND_POSSIBLE
-	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on !ARCH_S5P64X0 && !ARCH_S5P6442 && !ARCH_S5PC100
 	def_bool y
 
 endmenu
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-04-02  2:09 ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-02  2:09 UTC (permalink / raw)
  To: linux-arm-kernel

The current mainline codes of ARCH_S5PC100 can not support
suspend to ram. So needs this for preventing build error.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
Oops, I missed this in my previous patch.

As I know, firstly ARCH_S5P64X0 will support suspend to ram
then ARCH_S5PC100 will do it. But right now, we need this.

 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 7c0effb..5c3e232 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2010,7 +2010,7 @@ menu "Power management options"
 source "kernel/power/Kconfig"
 
 config ARCH_SUSPEND_POSSIBLE
-	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on !ARCH_S5P64X0 && !ARCH_S5P6442 && !ARCH_S5PC100
 	def_bool y
 
 endmenu
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* Re: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-04-02  2:09 ` Kukjin Kim
@ 2011-04-02  9:19   ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:19 UTC (permalink / raw)
  To: Kukjin Kim; +Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> The current mainline codes of ARCH_S5PC100 can not support
> suspend to ram. So needs this for preventing build error.
> 
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> Oops, I missed this in my previous patch.
> 
> As I know, firstly ARCH_S5P64X0 will support suspend to ram
> then ARCH_S5PC100 will do it. But right now, we need this.

I'd much rather do this a different way - let me know if this means
the SoC based dependencies can be dropped.  Patches to follow.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-04-02  9:19   ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> The current mainline codes of ARCH_S5PC100 can not support
> suspend to ram. So needs this for preventing build error.
> 
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> Oops, I missed this in my previous patch.
> 
> As I know, firstly ARCH_S5P64X0 will support suspend to ram
> then ARCH_S5PC100 will do it. But right now, we need this.

I'd much rather do this a different way - let me know if this means
the SoC based dependencies can be dropped.  Patches to follow.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
  2011-04-02  9:19   ` Russell King - ARM Linux
@ 2011-04-02  9:20     ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:20 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc; +Cc: ben-linux, Kukjin Kim

CONFIG_PM is now set whenever we support either runtime PM in addition
to suspend and hibernate.  This causes build errors when runtime PM is
enabled on a platform, but the CPU does not have the appropriate support
for suspend.

So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
allow runtime PM to be enabled without causing build errors.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/kernel/Makefile  |    2 +-
 arch/arm/mm/proc-arm920.S |    2 +-
 arch/arm/mm/proc-arm926.S |    2 +-
 arch/arm/mm/proc-sa1100.S |    2 +-
 arch/arm/mm/proc-v6.S     |    2 +-
 arch/arm/mm/proc-v7.S     |    2 +-
 arch/arm/mm/proc-xsc3.S   |    2 +-
 arch/arm/mm/proc-xscale.S |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
index 74554f1..8d95446 100644
--- a/arch/arm/kernel/Makefile
+++ b/arch/arm/kernel/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_MODULES)		+= armksyms.o module.o
 obj-$(CONFIG_ARTHUR)		+= arthur.o
 obj-$(CONFIG_ISA_DMA)		+= dma-isa.o
 obj-$(CONFIG_PCI)		+= bios32.o isa.o
-obj-$(CONFIG_PM)		+= sleep.o
+obj-$(CONFIG_PM_SLEEP)		+= sleep.o
 obj-$(CONFIG_HAVE_SCHED_CLOCK)	+= sched_clock.o
 obj-$(CONFIG_SMP)		+= smp.o smp_tlb.o
 obj-$(CONFIG_HAVE_ARM_SCU)	+= smp_scu.o
diff --git a/arch/arm/mm/proc-arm920.S b/arch/arm/mm/proc-arm920.S
index 219980e..394b623 100644
--- a/arch/arm/mm/proc-arm920.S
+++ b/arch/arm/mm/proc-arm920.S
@@ -390,7 +390,7 @@ ENTRY(cpu_arm920_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/plat-s3c24xx/sleep.S */
 .globl	cpu_arm920_suspend_size
 .equ	cpu_arm920_suspend_size, 4 * 3
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_arm920_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ PID
diff --git a/arch/arm/mm/proc-arm926.S b/arch/arm/mm/proc-arm926.S
index 6a4bdb2..0ed85d9 100644
--- a/arch/arm/mm/proc-arm926.S
+++ b/arch/arm/mm/proc-arm926.S
@@ -404,7 +404,7 @@ ENTRY(cpu_arm926_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/plat-s3c24xx/sleep.S */
 .globl	cpu_arm926_suspend_size
 .equ	cpu_arm926_suspend_size, 4 * 3
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_arm926_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ PID
diff --git a/arch/arm/mm/proc-sa1100.S b/arch/arm/mm/proc-sa1100.S
index 74483d1..184a9c9 100644
--- a/arch/arm/mm/proc-sa1100.S
+++ b/arch/arm/mm/proc-sa1100.S
@@ -171,7 +171,7 @@ ENTRY(cpu_sa1100_set_pte_ext)
 
 .globl	cpu_sa1100_suspend_size
 .equ	cpu_sa1100_suspend_size, 4*4
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_sa1100_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c3, c0, 0		@ domain ID
diff --git a/arch/arm/mm/proc-v6.S b/arch/arm/mm/proc-v6.S
index 832b6bd..3874412 100644
--- a/arch/arm/mm/proc-v6.S
+++ b/arch/arm/mm/proc-v6.S
@@ -124,7 +124,7 @@ ENTRY(cpu_v6_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/mach-s3c64xx/sleep.S */
 .globl	cpu_v6_suspend_size
 .equ	cpu_v6_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_v6_do_suspend)
 	stmfd	sp!, {r4 - r11, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ FCSE/PID
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 262fa88..713cea1 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -211,7 +211,7 @@ cpu_v7_name:
 /* Suspend/resume support: derived from arch/arm/mach-s5pv210/sleep.S */
 .globl	cpu_v7_suspend_size
 .equ	cpu_v7_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_v7_do_suspend)
 	stmfd	sp!, {r4 - r11, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ FCSE/PID
diff --git a/arch/arm/mm/proc-xsc3.S b/arch/arm/mm/proc-xsc3.S
index 63d8b20..5962136 100644
--- a/arch/arm/mm/proc-xsc3.S
+++ b/arch/arm/mm/proc-xsc3.S
@@ -417,7 +417,7 @@ ENTRY(cpu_xsc3_set_pte_ext)
 
 .globl	cpu_xsc3_suspend_size
 .equ	cpu_xsc3_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_xsc3_do_suspend)
 	stmfd	sp!, {r4 - r10, lr}
 	mrc	p14, 0, r4, c6, c0, 0	@ clock configuration, for turbo mode
diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
index 086038c..ce233bc 100644
--- a/arch/arm/mm/proc-xscale.S
+++ b/arch/arm/mm/proc-xscale.S
@@ -518,7 +518,7 @@ ENTRY(cpu_xscale_set_pte_ext)
 
 .globl	cpu_xscale_suspend_size
 .equ	cpu_xscale_suspend_size, 4 * 7
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_xscale_do_suspend)
 	stmfd	sp!, {r4 - r10, lr}
 	mrc	p14, 0, r4, c6, c0, 0	@ clock configuration, for turbo mode
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
@ 2011-04-02  9:20     ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:20 UTC (permalink / raw)
  To: linux-arm-kernel

CONFIG_PM is now set whenever we support either runtime PM in addition
to suspend and hibernate.  This causes build errors when runtime PM is
enabled on a platform, but the CPU does not have the appropriate support
for suspend.

So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
allow runtime PM to be enabled without causing build errors.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/kernel/Makefile  |    2 +-
 arch/arm/mm/proc-arm920.S |    2 +-
 arch/arm/mm/proc-arm926.S |    2 +-
 arch/arm/mm/proc-sa1100.S |    2 +-
 arch/arm/mm/proc-v6.S     |    2 +-
 arch/arm/mm/proc-v7.S     |    2 +-
 arch/arm/mm/proc-xsc3.S   |    2 +-
 arch/arm/mm/proc-xscale.S |    2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
index 74554f1..8d95446 100644
--- a/arch/arm/kernel/Makefile
+++ b/arch/arm/kernel/Makefile
@@ -29,7 +29,7 @@ obj-$(CONFIG_MODULES)		+= armksyms.o module.o
 obj-$(CONFIG_ARTHUR)		+= arthur.o
 obj-$(CONFIG_ISA_DMA)		+= dma-isa.o
 obj-$(CONFIG_PCI)		+= bios32.o isa.o
-obj-$(CONFIG_PM)		+= sleep.o
+obj-$(CONFIG_PM_SLEEP)		+= sleep.o
 obj-$(CONFIG_HAVE_SCHED_CLOCK)	+= sched_clock.o
 obj-$(CONFIG_SMP)		+= smp.o smp_tlb.o
 obj-$(CONFIG_HAVE_ARM_SCU)	+= smp_scu.o
diff --git a/arch/arm/mm/proc-arm920.S b/arch/arm/mm/proc-arm920.S
index 219980e..394b623 100644
--- a/arch/arm/mm/proc-arm920.S
+++ b/arch/arm/mm/proc-arm920.S
@@ -390,7 +390,7 @@ ENTRY(cpu_arm920_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/plat-s3c24xx/sleep.S */
 .globl	cpu_arm920_suspend_size
 .equ	cpu_arm920_suspend_size, 4 * 3
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_arm920_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ PID
diff --git a/arch/arm/mm/proc-arm926.S b/arch/arm/mm/proc-arm926.S
index 6a4bdb2..0ed85d9 100644
--- a/arch/arm/mm/proc-arm926.S
+++ b/arch/arm/mm/proc-arm926.S
@@ -404,7 +404,7 @@ ENTRY(cpu_arm926_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/plat-s3c24xx/sleep.S */
 .globl	cpu_arm926_suspend_size
 .equ	cpu_arm926_suspend_size, 4 * 3
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_arm926_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ PID
diff --git a/arch/arm/mm/proc-sa1100.S b/arch/arm/mm/proc-sa1100.S
index 74483d1..184a9c9 100644
--- a/arch/arm/mm/proc-sa1100.S
+++ b/arch/arm/mm/proc-sa1100.S
@@ -171,7 +171,7 @@ ENTRY(cpu_sa1100_set_pte_ext)
 
 .globl	cpu_sa1100_suspend_size
 .equ	cpu_sa1100_suspend_size, 4*4
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_sa1100_do_suspend)
 	stmfd	sp!, {r4 - r7, lr}
 	mrc	p15, 0, r4, c3, c0, 0		@ domain ID
diff --git a/arch/arm/mm/proc-v6.S b/arch/arm/mm/proc-v6.S
index 832b6bd..3874412 100644
--- a/arch/arm/mm/proc-v6.S
+++ b/arch/arm/mm/proc-v6.S
@@ -124,7 +124,7 @@ ENTRY(cpu_v6_set_pte_ext)
 /* Suspend/resume support: taken from arch/arm/mach-s3c64xx/sleep.S */
 .globl	cpu_v6_suspend_size
 .equ	cpu_v6_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_v6_do_suspend)
 	stmfd	sp!, {r4 - r11, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ FCSE/PID
diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
index 262fa88..713cea1 100644
--- a/arch/arm/mm/proc-v7.S
+++ b/arch/arm/mm/proc-v7.S
@@ -211,7 +211,7 @@ cpu_v7_name:
 /* Suspend/resume support: derived from arch/arm/mach-s5pv210/sleep.S */
 .globl	cpu_v7_suspend_size
 .equ	cpu_v7_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_v7_do_suspend)
 	stmfd	sp!, {r4 - r11, lr}
 	mrc	p15, 0, r4, c13, c0, 0	@ FCSE/PID
diff --git a/arch/arm/mm/proc-xsc3.S b/arch/arm/mm/proc-xsc3.S
index 63d8b20..5962136 100644
--- a/arch/arm/mm/proc-xsc3.S
+++ b/arch/arm/mm/proc-xsc3.S
@@ -417,7 +417,7 @@ ENTRY(cpu_xsc3_set_pte_ext)
 
 .globl	cpu_xsc3_suspend_size
 .equ	cpu_xsc3_suspend_size, 4 * 8
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_xsc3_do_suspend)
 	stmfd	sp!, {r4 - r10, lr}
 	mrc	p14, 0, r4, c6, c0, 0	@ clock configuration, for turbo mode
diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
index 086038c..ce233bc 100644
--- a/arch/arm/mm/proc-xscale.S
+++ b/arch/arm/mm/proc-xscale.S
@@ -518,7 +518,7 @@ ENTRY(cpu_xscale_set_pte_ext)
 
 .globl	cpu_xscale_suspend_size
 .equ	cpu_xscale_suspend_size, 4 * 7
-#ifdef CONFIG_PM
+#ifdef CONFIG_PM_SLEEP
 ENTRY(cpu_xscale_do_suspend)
 	stmfd	sp!, {r4 - r10, lr}
 	mrc	p14, 0, r4, c6, c0, 0	@ clock configuration, for turbo mode
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: Only allow PM_SLEEP with CPUs which support suspend
  2011-04-02  9:19   ` Russell King - ARM Linux
@ 2011-04-02  9:21     ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:21 UTC (permalink / raw)
  To: linux-arm-kernel, linux-samsung-soc; +Cc: ben-linux, Kukjin Kim

Offering CONFIG_PM_SLEEP for CPUs which do not support suspend leads to
build errors, so only set CONFIG_ARCH_SUSPEND_POSSIBLE if we have a CPU
selected which supports suspend.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b9f78b..9954c9b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2012,6 +2012,8 @@ source "kernel/power/Kconfig"
 
 config ARCH_SUSPEND_POSSIBLE
 	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on CPU_ARM920T || CPU_ARM926T || CPU_SA1100 || \
+		CPU_V6 || CPU_V6K || CPU_V7 || CPU_XSC3 || CPU_XSCALE
 	def_bool y
 
 endmenu
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH 2/2] ARM: Only allow PM_SLEEP with CPUs which support suspend
@ 2011-04-02  9:21     ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-02  9:21 UTC (permalink / raw)
  To: linux-arm-kernel

Offering CONFIG_PM_SLEEP for CPUs which do not support suspend leads to
build errors, so only set CONFIG_ARCH_SUSPEND_POSSIBLE if we have a CPU
selected which supports suspend.

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 arch/arm/Kconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 5b9f78b..9954c9b 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2012,6 +2012,8 @@ source "kernel/power/Kconfig"
 
 config ARCH_SUSPEND_POSSIBLE
 	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on CPU_ARM920T || CPU_ARM926T || CPU_SA1100 || \
+		CPU_V6 || CPU_V6K || CPU_V7 || CPU_XSC3 || CPU_XSCALE
 	def_bool y
 
 endmenu
-- 
1.7.4

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
  2011-04-02  9:20     ` Russell King - ARM Linux
@ 2011-04-03 11:26       ` Arnaud Patard (Rtp)
  -1 siblings, 0 replies; 24+ messages in thread
From: Arnaud Patard @ 2011-04-03 11:26 UTC (permalink / raw)
  To: Russell King - ARM Linux
  Cc: Kukjin Kim, linux-samsung-soc, ben-linux, linux-arm-kernel

Hi,

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> CONFIG_PM is now set whenever we support either runtime PM in addition
> to suspend and hibernate.  This causes build errors when runtime PM is
> enabled on a platform, but the CPU does not have the appropriate support
> for suspend.
>
> So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
> allow runtime PM to be enabled without causing build errors.

I've build-tested on some failing platforms theses 2 patches and the
build are now succeeding. The only PM related zImage build error I found
was for s5pc100:

arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory

S5PC100 is a armv7 that's why it's still selected. I guess it will still
need some extra care unless the pm-core.h file is provided. One can try
use the same file as for s5pv210.h. I guess that it has probably not be
done because it was not working (I'm even wondering the differences
between s5pc100 and s5pv210 but this has nothing to do with our current
build troubles).


Arnaud

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
@ 2011-04-03 11:26       ` Arnaud Patard (Rtp)
  0 siblings, 0 replies; 24+ messages in thread
From: Arnaud Patard (Rtp) @ 2011-04-03 11:26 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

Russell King - ARM Linux <linux@arm.linux.org.uk> writes:

> CONFIG_PM is now set whenever we support either runtime PM in addition
> to suspend and hibernate.  This causes build errors when runtime PM is
> enabled on a platform, but the CPU does not have the appropriate support
> for suspend.
>
> So, switch this code to use CONFIG_PM_SLEEP rather than CONFIG_PM to
> allow runtime PM to be enabled without causing build errors.

I've build-tested on some failing platforms theses 2 patches and the
build are now succeeding. The only PM related zImage build error I found
was for s5pc100:

arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory

S5PC100 is a armv7 that's why it's still selected. I guess it will still
need some extra care unless the pm-core.h file is provided. One can try
use the same file as for s5pv210.h. I guess that it has probably not be
done because it was not working (I'm even wondering the differences
between s5pc100 and s5pv210 but this has nothing to do with our current
build troubles).


Arnaud

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
  2011-04-03 11:26       ` Arnaud Patard (Rtp)
@ 2011-04-03 12:27         ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-03 12:27 UTC (permalink / raw)
  To: Arnaud Patard; +Cc: linux-arm-kernel, linux-samsung-soc, Kukjin Kim, ben-linux

On Sun, Apr 03, 2011 at 01:26:35PM +0200, Arnaud Patard wrote:
> I've build-tested on some failing platforms theses 2 patches and the
> build are now succeeding. The only PM related zImage build error I found
> was for s5pc100:
> 
> arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory

That probably existing from before the consolidation patch, so I won't
worry about it.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
@ 2011-04-03 12:27         ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-03 12:27 UTC (permalink / raw)
  To: linux-arm-kernel

On Sun, Apr 03, 2011 at 01:26:35PM +0200, Arnaud Patard wrote:
> I've build-tested on some failing platforms theses 2 patches and the
> build are now succeeding. The only PM related zImage build error I found
> was for s5pc100:
> 
> arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such file or directory

That probably existing from before the consolidation patch, so I won't
worry about it.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* RE: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-04-02  9:19   ` Russell King - ARM Linux
@ 2011-04-04 11:47     ` Kukjin Kim
  -1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-04 11:47 UTC (permalink / raw)
  To: 'Russell King - ARM Linux'
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

Russell King - ARM Linux wrote:
> 
> On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > The current mainline codes of ARCH_S5PC100 can not support
> > suspend to ram. So needs this for preventing build error.
> >
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > Oops, I missed this in my previous patch.
> >
> > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > then ARCH_S5PC100 will do it. But right now, we need this.
> 
> I'd much rather do this a different way - let me know if this means
> the SoC based dependencies can be dropped.  Patches to follow.

Yeah, I checked your patches. It's ok to me but this is also needed right
now for preventing build errors with s5pc100_defconfig...because there is no
regarding headers for supporting suspend to ram.

However as I mentioned, the suspend to ram will be supported soon on them
then we can drop its dependencies.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-04-04 11:47     ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-04 11:47 UTC (permalink / raw)
  To: linux-arm-kernel

Russell King - ARM Linux wrote:
> 
> On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > The current mainline codes of ARCH_S5PC100 can not support
> > suspend to ram. So needs this for preventing build error.
> >
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > ---
> > Oops, I missed this in my previous patch.
> >
> > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > then ARCH_S5PC100 will do it. But right now, we need this.
> 
> I'd much rather do this a different way - let me know if this means
> the SoC based dependencies can be dropped.  Patches to follow.

Yeah, I checked your patches. It's ok to me but this is also needed right
now for preventing build errors with s5pc100_defconfig...because there is no
regarding headers for supporting suspend to ram.

However as I mentioned, the suspend to ram will be supported soon on them
then we can drop its dependencies.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* RE: [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
  2011-04-03 12:27         ` Russell King - ARM Linux
@ 2011-04-04 11:50           ` Kukjin Kim
  -1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-04 11:50 UTC (permalink / raw)
  To: 'Russell King - ARM Linux', 'Arnaud Patard'
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

Russell King - ARM Linux wrote:
> 
> On Sun, Apr 03, 2011 at 01:26:35PM +0200, Arnaud Patard wrote:
> > I've build-tested on some failing platforms theses 2 patches and the
> > build are now succeeding. The only PM related zImage build error I found
> > was for s5pc100:
> >
> > arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such
file
> or directory
> 
> That probably existing from before the consolidation patch, so I won't
> worry about it.

Yeah, Russell is right :)

I will sort it out.
Thanks for your pointing out.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP
@ 2011-04-04 11:50           ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-04-04 11:50 UTC (permalink / raw)
  To: linux-arm-kernel

Russell King - ARM Linux wrote:
> 
> On Sun, Apr 03, 2011 at 01:26:35PM +0200, Arnaud Patard wrote:
> > I've build-tested on some failing platforms theses 2 patches and the
> > build are now succeeding. The only PM related zImage build error I found
> > was for s5pc100:
> >
> > arch/arm/plat-samsung/pm.c:32:26: fatal error: mach/pm-core.h: No such
file
> or directory
> 
> That probably existing from before the consolidation patch, so I won't
> worry about it.

Yeah, Russell is right :)

I will sort it out.
Thanks for your pointing out.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* Re: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-04-04 11:47     ` Kukjin Kim
@ 2011-04-28 18:43       ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-28 18:43 UTC (permalink / raw)
  To: Kukjin Kim; +Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> > 
> > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > The current mainline codes of ARCH_S5PC100 can not support
> > > suspend to ram. So needs this for preventing build error.
> > >
> > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > ---
> > > Oops, I missed this in my previous patch.
> > >
> > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > then ARCH_S5PC100 will do it. But right now, we need this.
> > 
> > I'd much rather do this a different way - let me know if this means
> > the SoC based dependencies can be dropped.  Patches to follow.
> 
> Yeah, I checked your patches. It's ok to me but this is also needed right
> now for preventing build errors with s5pc100_defconfig...because there is no
> regarding headers for supporting suspend to ram.
> 
> However as I mentioned, the suspend to ram will be supported soon on them
> then we can drop its dependencies.

Could I have an updated patch which applies to mainline please?

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-04-28 18:43       ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-04-28 18:43 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> > 
> > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > The current mainline codes of ARCH_S5PC100 can not support
> > > suspend to ram. So needs this for preventing build error.
> > >
> > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > ---
> > > Oops, I missed this in my previous patch.
> > >
> > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > then ARCH_S5PC100 will do it. But right now, we need this.
> > 
> > I'd much rather do this a different way - let me know if this means
> > the SoC based dependencies can be dropped.  Patches to follow.
> 
> Yeah, I checked your patches. It's ok to me but this is also needed right
> now for preventing build errors with s5pc100_defconfig...because there is no
> regarding headers for supporting suspend to ram.
> 
> However as I mentioned, the suspend to ram will be supported soon on them
> then we can drop its dependencies.

Could I have an updated patch which applies to mainline please?

^ permalink raw reply	[flat|nested] 24+ messages in thread
* RE: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-04-28 18:43       ` Russell King - ARM Linux
@ 2011-05-02  1:09         ` Kukjin Kim
  -1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-05-02  1:09 UTC (permalink / raw)
  To: 'Russell King - ARM Linux'
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

Russell King - ARM Linux wrote:
> 
> On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > Russell King - ARM Linux wrote:
> > >
> > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > suspend to ram. So needs this for preventing build error.
> > > >
> > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > ---
> > > > Oops, I missed this in my previous patch.
> > > >
> > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > >
> > > I'd much rather do this a different way - let me know if this means
> > > the SoC based dependencies can be dropped.  Patches to follow.
> >
> > Yeah, I checked your patches. It's ok to me but this is also needed
right
> > now for preventing build errors with s5pc100_defconfig...because there
is
> no
> > regarding headers for supporting suspend to ram.
> >
> > However as I mentioned, the suspend to ram will be supported soon on
them
> > then we can drop its dependencies.
> 
> Could I have an updated patch which applies to mainline please?

From: Kukjin Kim <kgene.kim@samsung.com>
Date: Mon, 2 May 2011 09:33:01 +0900
Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100

The current mainline codes of ARCH_S5PC100 cannot support
suspend to ram. So needs this for preventing build error.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 377a7a5..96839d9 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2010,7 +2010,7 @@ menu "Power management options"
 source "kernel/power/Kconfig"

 config ARCH_SUSPEND_POSSIBLE
-	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on !ARCH_S5P64X0 && !ARCH_S5P6442 && !ARCH_S5PC100
 	depends on CPU_ARM920T || CPU_ARM926T || CPU_SA1100 || \
 		CPU_V6 || CPU_V6K || CPU_V7 || CPU_XSC3 || CPU_XSCALE
 	def_bool y
-- 

If any problems, please let me know.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-05-02  1:09         ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-05-02  1:09 UTC (permalink / raw)
  To: linux-arm-kernel

Russell King - ARM Linux wrote:
> 
> On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > Russell King - ARM Linux wrote:
> > >
> > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > suspend to ram. So needs this for preventing build error.
> > > >
> > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > ---
> > > > Oops, I missed this in my previous patch.
> > > >
> > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > >
> > > I'd much rather do this a different way - let me know if this means
> > > the SoC based dependencies can be dropped.  Patches to follow.
> >
> > Yeah, I checked your patches. It's ok to me but this is also needed
right
> > now for preventing build errors with s5pc100_defconfig...because there
is
> no
> > regarding headers for supporting suspend to ram.
> >
> > However as I mentioned, the suspend to ram will be supported soon on
them
> > then we can drop its dependencies.
> 
> Could I have an updated patch which applies to mainline please?

From: Kukjin Kim <kgene.kim@samsung.com>
Date: Mon, 2 May 2011 09:33:01 +0900
Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100

The current mainline codes of ARCH_S5PC100 cannot support
suspend to ram. So needs this for preventing build error.

Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
---
 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 377a7a5..96839d9 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2010,7 +2010,7 @@ menu "Power management options"
 source "kernel/power/Kconfig"

 config ARCH_SUSPEND_POSSIBLE
-	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on !ARCH_S5P64X0 && !ARCH_S5P6442 && !ARCH_S5PC100
 	depends on CPU_ARM920T || CPU_ARM926T || CPU_SA1100 || \
 		CPU_V6 || CPU_V6K || CPU_V7 || CPU_XSC3 || CPU_XSCALE
 	def_bool y
-- 

If any problems, please let me know.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply related	[flat|nested] 24+ messages in thread
* Re: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-05-02  1:09         ` Kukjin Kim
@ 2011-05-12  9:05           ` Russell King - ARM Linux
  -1 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-05-12  9:05 UTC (permalink / raw)
  To: Kukjin Kim; +Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

On Mon, May 02, 2011 at 10:09:55AM +0900, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> > 
> > On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > > Russell King - ARM Linux wrote:
> > > >
> > > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > > suspend to ram. So needs this for preventing build error.
> > > > >
> > > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > > ---
> > > > > Oops, I missed this in my previous patch.
> > > > >
> > > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > > >
> > > > I'd much rather do this a different way - let me know if this means
> > > > the SoC based dependencies can be dropped.  Patches to follow.
> > >
> > > Yeah, I checked your patches. It's ok to me but this is also needed
> right
> > > now for preventing build errors with s5pc100_defconfig...because there
> is
> > no
> > > regarding headers for supporting suspend to ram.
> > >
> > > However as I mentioned, the suspend to ram will be supported soon on
> them
> > > then we can drop its dependencies.
> > 
> > Could I have an updated patch which applies to mainline please?
> 
> From: Kukjin Kim <kgene.kim@samsung.com>
> Date: Mon, 2 May 2011 09:33:01 +0900
> Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
> 
> The current mainline codes of ARCH_S5PC100 cannot support
> suspend to ram. So needs this for preventing build error.
> 
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>

Looks fine, but can it go to the patch system please?

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-05-12  9:05           ` Russell King - ARM Linux
  0 siblings, 0 replies; 24+ messages in thread
From: Russell King - ARM Linux @ 2011-05-12  9:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, May 02, 2011 at 10:09:55AM +0900, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> > 
> > On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > > Russell King - ARM Linux wrote:
> > > >
> > > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > > suspend to ram. So needs this for preventing build error.
> > > > >
> > > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > > ---
> > > > > Oops, I missed this in my previous patch.
> > > > >
> > > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > > >
> > > > I'd much rather do this a different way - let me know if this means
> > > > the SoC based dependencies can be dropped.  Patches to follow.
> > >
> > > Yeah, I checked your patches. It's ok to me but this is also needed
> right
> > > now for preventing build errors with s5pc100_defconfig...because there
> is
> > no
> > > regarding headers for supporting suspend to ram.
> > >
> > > However as I mentioned, the suspend to ram will be supported soon on
> them
> > > then we can drop its dependencies.
> > 
> > Could I have an updated patch which applies to mainline please?
> 
> From: Kukjin Kim <kgene.kim@samsung.com>
> Date: Mon, 2 May 2011 09:33:01 +0900
> Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
> 
> The current mainline codes of ARCH_S5PC100 cannot support
> suspend to ram. So needs this for preventing build error.
> 
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>

Looks fine, but can it go to the patch system please?

^ permalink raw reply	[flat|nested] 24+ messages in thread
* RE: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
  2011-05-12  9:05           ` Russell King - ARM Linux
@ 2011-05-16  7:15             ` Kukjin Kim
  -1 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-05-16  7:15 UTC (permalink / raw)
  To: 'Russell King - ARM Linux'
  Cc: linux-arm-kernel, linux-samsung-soc, ben-linux

Russell King - ARM Linux wrote:
> 
> On Mon, May 02, 2011 at 10:09:55AM +0900, Kukjin Kim wrote:
> > Russell King - ARM Linux wrote:
> > >
> > > On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > > > Russell King - ARM Linux wrote:
> > > > >
> > > > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > > > suspend to ram. So needs this for preventing build error.
> > > > > >
> > > > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > > > ---
> > > > > > Oops, I missed this in my previous patch.
> > > > > >
> > > > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > > > >
> > > > > I'd much rather do this a different way - let me know if this
means
> > > > > the SoC based dependencies can be dropped.  Patches to follow.
> > > >
> > > > Yeah, I checked your patches. It's ok to me but this is also needed
> > right
> > > > now for preventing build errors with s5pc100_defconfig...because
there
> > is
> > > no
> > > > regarding headers for supporting suspend to ram.
> > > >
> > > > However as I mentioned, the suspend to ram will be supported soon on
> > them
> > > > then we can drop its dependencies.
> > >
> > > Could I have an updated patch which applies to mainline please?
> >
> > From: Kukjin Kim <kgene.kim@samsung.com>
> > Date: Mon, 2 May 2011 09:33:01 +0900
> > Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
> >
> > The current mainline codes of ARCH_S5PC100 cannot support
> > suspend to ram. So needs this for preventing build error.
> >
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> Looks fine, but can it go to the patch system please?

Ok, will do soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
* [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
@ 2011-05-16  7:15             ` Kukjin Kim
  0 siblings, 0 replies; 24+ messages in thread
From: Kukjin Kim @ 2011-05-16  7:15 UTC (permalink / raw)
  To: linux-arm-kernel

Russell King - ARM Linux wrote:
> 
> On Mon, May 02, 2011 at 10:09:55AM +0900, Kukjin Kim wrote:
> > Russell King - ARM Linux wrote:
> > >
> > > On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > > > Russell King - ARM Linux wrote:
> > > > >
> > > > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > > > suspend to ram. So needs this for preventing build error.
> > > > > >
> > > > > > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > > > > > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> > > > > > ---
> > > > > > Oops, I missed this in my previous patch.
> > > > > >
> > > > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > > > >
> > > > > I'd much rather do this a different way - let me know if this
means
> > > > > the SoC based dependencies can be dropped.  Patches to follow.
> > > >
> > > > Yeah, I checked your patches. It's ok to me but this is also needed
> > right
> > > > now for preventing build errors with s5pc100_defconfig...because
there
> > is
> > > no
> > > > regarding headers for supporting suspend to ram.
> > > >
> > > > However as I mentioned, the suspend to ram will be supported soon on
> > them
> > > > then we can drop its dependencies.
> > >
> > > Could I have an updated patch which applies to mainline please?
> >
> > From: Kukjin Kim <kgene.kim@samsung.com>
> > Date: Mon, 2 May 2011 09:33:01 +0900
> > Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100
> >
> > The current mainline codes of ARCH_S5PC100 cannot support
> > suspend to ram. So needs this for preventing build error.
> >
> > Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> > Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> 
> Looks fine, but can it go to the patch system please?

Ok, will do soon.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

^ permalink raw reply	[flat|nested] 24+ messages in thread
end of thread, other threads:[~2011-05-16  7:15 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-02  2:09 [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100 Kukjin Kim
2011-04-02  2:09 ` Kukjin Kim
2011-04-02  9:19 ` Russell King - ARM Linux
2011-04-02  9:19   ` Russell King - ARM Linux
2011-04-02  9:20   ` [PATCH 1/2] ARM: Make consolidated PM sleep code depend on PM_SLEEP Russell King - ARM Linux
2011-04-02  9:20     ` Russell King - ARM Linux
2011-04-03 11:26     ` Arnaud Patard
2011-04-03 11:26       ` Arnaud Patard (Rtp)
2011-04-03 12:27       ` Russell King - ARM Linux
2011-04-03 12:27         ` Russell King - ARM Linux
2011-04-04 11:50         ` Kukjin Kim
2011-04-04 11:50           ` Kukjin Kim
2011-04-02  9:21   ` [PATCH 2/2] ARM: Only allow PM_SLEEP with CPUs which support suspend Russell King - ARM Linux
2011-04-02  9:21     ` Russell King - ARM Linux
2011-04-04 11:47   ` [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100 Kukjin Kim
2011-04-04 11:47     ` Kukjin Kim
2011-04-28 18:43     ` Russell King - ARM Linux
2011-04-28 18:43       ` Russell King - ARM Linux
2011-05-02  1:09       ` Kukjin Kim
2011-05-02  1:09         ` Kukjin Kim
2011-05-12  9:05         ` Russell King - ARM Linux
2011-05-12  9:05           ` Russell King - ARM Linux
2011-05-16  7:15           ` Kukjin Kim
2011-05-16  7:15             ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.