* Qgit should use "git config" instead of "git repo-config"
@ 2011-05-09 21:20 Jonathan Rogers
2011-05-09 21:36 ` Thiago Farina
2011-05-09 23:19 ` Jonathan Nieder
0 siblings, 2 replies; 8+ messages in thread
From: Jonathan Rogers @ 2011-05-09 21:20 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
Here's a small patch to cause qgit to use "git config" instead of "git
repo-config" in a couple of places.
--
Jonathan Ross Rogers
[-- Attachment #2: qgit_config.patch --]
[-- Type: text/plain, Size: 699 bytes --]
diff --git a/src/git.cpp b/src/git.cpp
index 50e6dd3..8e9365c 100644
--- a/src/git.cpp
+++ b/src/git.cpp
@@ -427,7 +427,7 @@ void Git::setTextCodec(QTextCodec* tc) {
if (name == "Big5-HKSCS")
name = "Big5";
- run("git repo-config i18n.commitencoding " + name);
+ run("git config i18n.commitencoding " + name);
}
QTextCodec* Git::getTextCodec(bool* isGitArchive) {
@@ -437,7 +437,7 @@ QTextCodec* Git::getTextCodec(bool* isGitArchive) {
return NULL;
QString runOutput;
- if (!run("git repo-config --get i18n.commitencoding", &runOutput))
+ if (!run("git config --get i18n.commitencoding", &runOutput))
return NULL;
if (runOutput.isEmpty()) // git docs says default is utf-8
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
2011-05-09 21:20 Qgit should use "git config" instead of "git repo-config" Jonathan Rogers
@ 2011-05-09 21:36 ` Thiago Farina
[not found] ` <4DC85F33.4020305@socialserve.com>
2011-05-09 23:19 ` Jonathan Nieder
1 sibling, 1 reply; 8+ messages in thread
From: Thiago Farina @ 2011-05-09 21:36 UTC (permalink / raw)
To: Jonathan Rogers; +Cc: git
On Mon, May 9, 2011 at 6:20 PM, Jonathan Rogers <jrogers@socialserve.com> wrote:
> Here's a small patch to cause qgit to use "git config" instead of "git
> repo-config" in a couple of places.
>
Please, read Documentation/SubmittingPatches for a guide about how to
submit a patch to this list.
Thanks,
Best regards!
> --
> Jonathan Ross Rogers
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
2011-05-09 21:20 Qgit should use "git config" instead of "git repo-config" Jonathan Rogers
2011-05-09 21:36 ` Thiago Farina
@ 2011-05-09 23:19 ` Jonathan Nieder
2011-05-09 23:35 ` Jonathan Rogers
2011-05-14 8:35 ` Marco Costalba
1 sibling, 2 replies; 8+ messages in thread
From: Jonathan Nieder @ 2011-05-09 23:19 UTC (permalink / raw)
To: Jonathan Rogers; +Cc: git, Marco Costalba, Thiago Farina
Hi Jonathan,
Jonathan Rogers wrote:
> Here's a small patch to cause qgit to use "git config" instead of
> "git repo-config" in a couple of places.
Thanks! I noticed you also submitted this at [1].
Looking at the qgit source[2] I don't see an address to send patches to;
cc-ing Marco for advice.
Hope that helps,
Jonathan
[1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829
[2] http://git.kernel.org/?p=qgit/qgit4.git
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
2011-05-09 23:19 ` Jonathan Nieder
@ 2011-05-09 23:35 ` Jonathan Rogers
2011-05-14 8:35 ` Marco Costalba
1 sibling, 0 replies; 8+ messages in thread
From: Jonathan Rogers @ 2011-05-09 23:35 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: git, Marco Costalba, Thiago Farina
Jonathan Nieder wrote:
> Hi Jonathan,
>
> Jonathan Rogers wrote:
>
>> Here's a small patch to cause qgit to use "git config" instead of
>> "git repo-config" in a couple of places.
> Thanks! I noticed you also submitted this at [1].
>
> Looking at the qgit source[2] I don't see an address to send patches to;
> cc-ing Marco for advice.
Yes, this list is the only address listed in the docs that I found. It
looks like some patches have been accepted on the SourceForge project
have been accepted, but I'm not sure if that's the preferred location.
Thanks for the help.
> Hope that helps,
> Jonathan
>
> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829
> [2] http://git.kernel.org/?p=qgit/qgit4.git
--
Jonathan Ross Rogers
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
[not found] ` <4DC87943.6010805@socialserve.com>
@ 2011-05-10 0:11 ` Thiago Farina
0 siblings, 0 replies; 8+ messages in thread
From: Thiago Farina @ 2011-05-10 0:11 UTC (permalink / raw)
To: Jonathan Rogers; +Cc: Git Mailing List
Please, don't forget to +cc the mailing list!
On Mon, May 9, 2011 at 8:31 PM, Jonathan Rogers <jrogers@socialserve.com> wrote:
> Thiago Farina wrote:
>>
>> I think what he means by "Bugs or feature requests should be sent to
>> the git@vger.kernel.org mailing list." is?
>
> I don't understand the question.
>>
Ops, not a question. s/?/:
>> Reporting bugs on git goes to this mailing list. If you have a
>> suggestion that you would wanted to see on the git core you could try
>> to send to this mailing list.
>>
>> He doesn't say that bug fixes and improvements to the source code of
>> qgit4 should be send to this mailing list. Patches sent here are for
>> the git source code at all if I'm not wrong.
>
> Since the README and author clearly state that the git@vger.kernel.org is
> the preferred place to discuss qgit, it's not clear to me where else is an
> appropriate place to send the patch.
>>>>
>>>> Maybe there is another list for qgit4?
>>>
>>> If there is, please share it with me.
>>
>> Maybe try to send a pull request on github or an email to the author?
>
> I also sent the patch to the author. The repository is on git.kernel.org, so
> I'm not sure how github would be involved.
>
I just saw this at: https://github.com/kaitanie/qgit4/
> <URL:http://git.kernel.org/?p=qgit/qgit4.git;a=summary>
>
> --
> Jonathan Ross Rogers
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
2011-05-09 23:19 ` Jonathan Nieder
2011-05-09 23:35 ` Jonathan Rogers
@ 2011-05-14 8:35 ` Marco Costalba
2011-05-14 8:56 ` Jonathan Nieder
1 sibling, 1 reply; 8+ messages in thread
From: Marco Costalba @ 2011-05-14 8:35 UTC (permalink / raw)
To: Jonathan Nieder; +Cc: Jonathan Rogers, git, Thiago Farina
On Tue, May 10, 2011 at 00:19, Jonathan Nieder <jrnieder@gmail.com> wrote:
> Hi Jonathan,
>
> Jonathan Rogers wrote:
>
>> Here's a small patch to cause qgit to use "git config" instead of
>> "git repo-config" in a couple of places.
>
> Thanks! I noticed you also submitted this at [1].
>
> Looking at the qgit source[2] I don't see an address to send patches to;
> cc-ing Marco for advice.
>
> Hope that helps,
> Jonathan
>
> [1] http://sourceforge.net/tracker/index.php?func=detail&aid=3299672&group_id=139897&atid=744829
> [2] http://git.kernel.org/?p=qgit/qgit4.git
>
Hi Jonathan,
thanks for the patch, please send to git list (if other people
don't mind), I more or less routinely read the list. I really should
do at least some maintenance work on qgit that has gone vastly
bitrotten in the past months.....
Marco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Qgit should use "git config" instead of "git repo-config"
2011-05-14 8:35 ` Marco Costalba
@ 2011-05-14 8:56 ` Jonathan Nieder
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Nieder @ 2011-05-14 8:56 UTC (permalink / raw)
To: Marco Costalba; +Cc: Jonathan Rogers, git, Thiago Farina
Marco Costalba wrote:
> thanks for the patch, please send to git list (if other people
> don't mind), I more or less routinely read the list. I really should
> do at least some maintenance work on qgit that has gone vastly
> bitrotten in the past months.....
Thanks. I don't know how I managed to miss that when skimming the
README.
-- >8 --
Subject: Emphasize that patches go to the git list
So now even people with poor reading comprehension ability and
search engines can tell where to send qgit improvements.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
README | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/README b/README
index d1989ca..b07c463 100644
--- a/README
+++ b/README
@@ -4,7 +4,7 @@ qgit, a git GUI viewer
With qgit you will be able to browse revisions history, view patch content
and changed files, graphically following different development branches.
-Bugs or feature requests should be sent to the git@vger.kernel.org
+Bugs, patches, and feature requests should be sent to the git@vger.kernel.org
mailing list.
Main features
--
1.7.5.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Qgit should use "git config" instead of "git repo-config"
@ 2011-05-09 21:15 Jonathan Rogers
0 siblings, 0 replies; 8+ messages in thread
From: Jonathan Rogers @ 2011-05-09 21:15 UTC (permalink / raw)
To: git
[-- Attachment #1: Type: text/plain, Size: 135 bytes --]
Here's a small patch to cause qgit to use "git config" instead of "git
repo-config" in a couple of places.
--
Jonathan Ross Rogers
[-- Attachment #2: qgit_config.patch --]
[-- Type: text/plain, Size: 698 bytes --]
diff --git a/src/git.cpp b/src/git.cpp
index 50e6dd3..8e9365c 100644
--- a/src/git.cpp
+++ b/src/git.cpp
@@ -427,7 +427,7 @@ void Git::setTextCodec(QTextCodec* tc) {
if (name == "Big5-HKSCS")
name = "Big5";
- run("git repo-config i18n.commitencoding " + name);
+ run("git config i18n.commitencoding " + name);
}
QTextCodec* Git::getTextCodec(bool* isGitArchive) {
@@ -437,7 +437,7 @@ QTextCodec* Git::getTextCodec(bool* isGitArchive) {
return NULL;
QString runOutput;
- if (!run("git repo-config --get i18n.commitencoding", &runOutput))
+ if (!run("git config --get i18n.commitencoding", &runOutput))
return NULL;
if (runOutput.isEmpty()) // git docs says default is utf-8
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-05-14 8:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-09 21:20 Qgit should use "git config" instead of "git repo-config" Jonathan Rogers
2011-05-09 21:36 ` Thiago Farina
[not found] ` <4DC85F33.4020305@socialserve.com>
[not found] ` <BANLkTimuWFSq_5_HkfgyXhRG6ysaVt_JwQ@mail.gmail.com>
[not found] ` <4DC8617F.70001@socialserve.com>
[not found] ` <BANLkTinsMTucb0Vj=rhkUNtv+hgsq2VfSg@mail.gmail.com>
[not found] ` <4DC87943.6010805@socialserve.com>
2011-05-10 0:11 ` Thiago Farina
2011-05-09 23:19 ` Jonathan Nieder
2011-05-09 23:35 ` Jonathan Rogers
2011-05-14 8:35 ` Marco Costalba
2011-05-14 8:56 ` Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2011-05-09 21:15 Jonathan Rogers
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.