USB driver "option" proposed patch to support Huawei E353 hardware

USB driver "option" proposed patch to support Huawei E353 hardware

[Marcin Gałczyński]

[-- Attachment #1: Type: text/plain, Size: 686 bytes --]

Hi,

I am sharing patch to the devices/usb/serial/option.c. This allows operation 
of Huawei E353 broadband modem using the “option” driver. The patch simply 
adds new constant with proper product ID and an entry to usb_device_id. I 
worked on the fresh driver file downloaded from GIT. Tested on Dell inspiron 
1764 (i3 core cpu) and brand new Huawei E353 modem, Fedora 15 beta.

Looking at the type of change, i doubt it has potential to introduce 
problems in other parts of kernel or the driver itself.

I am not an active kernel developer, thus i would not be joining the list... 
for now. If You’d like to reach me, please respond directly.


--best rgds
Marcin Galczynski 

[-- Attachment #2: devices-usb-serial-option.c-enable-huaweiE353.path --]
[-- Type: application/octet-stream, Size: 1076 bytes --]

*** option.c.old	2011-05-14 02:11:00.174063786 +0200
--- option.c	2011-05-14 02:03:34.312602150 +0200
***************
*** 149,154 ****
--- 149,155 ----
  #define HUAWEI_PRODUCT_K3765			0x1465
  #define HUAWEI_PRODUCT_E14AC			0x14AC
  #define HUAWEI_PRODUCT_ETS1220			0x1803
+ #define HUAWEI_PRODUCT_E353			0x1506
  
  #define QUANTA_VENDOR_ID			0x0408
  #define QUANTA_PRODUCT_Q101			0xEA02
***************
*** 532,537 ****
--- 533,539 ----
  	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_K3765, 0xff, 0xff, 0xff) },
  	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_ETS1220, 0xff, 0xff, 0xff) },
  	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E14AC, 0xff, 0xff, 0xff) },
+ 	{ USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E353, 0xff, 0x01, 0x01) },
  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) },
  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) },
  	{ USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V740) },

Re: USB driver "option" proposed patch to support Huawei E353 hardware

[Oliver Neukum]

Am Samstag, 14. Mai 2011, 02:44:10 schrieb Marcin Gałczyński:
> Hi,
> 
> I am sharing patch to the devices/usb/serial/option.c. This allows operation 
> of Huawei E353 broadband modem using the “option” driver. The patch simply 
> adds new constant with proper product ID and an entry to usb_device_id. I 
> worked on the fresh driver file downloaded from GIT. Tested on Dell inspiron 
> 1764 (i3 core cpu) and brand new Huawei E353 modem, Fedora 15 beta.
> 
> Looking at the type of change, i doubt it has potential to introduce 
> problems in other parts of kernel or the driver itself.
> 
> I am not an active kernel developer, thus i would not be joining the list... 
> for now. If You’d like to reach me, please respond directly.

Hi,

the patch looks good, but please resend it to linux-usb@vger.kernel.org
and add a Signed-off-by: line with your name and mail.

	Regards
		Oliver