All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mohan Pallaka <mpallaka@codeaurora.org>
Cc: linux@arm.linux.org.uk, rmk+kernel@arm.linux.org.uk,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-input@vger.kernel.org, linux-i2c@vger.kernel.org,
	rmk@dyn-67.arm.linux.org.uk
Subject: Re: [PATCH 1/2] pwm: Add stubs for pwm operations
Date: Tue, 17 May 2011 23:45:52 -0700	[thread overview]
Message-ID: <20110518064552.GA31801@core.coreip.homeip.net> (raw)
In-Reply-To: <1305695926-25855-2-git-send-email-mpallaka@codeaurora.org>

On Wed, May 18, 2011 at 10:48:45AM +0530, Mohan Pallaka wrote:
> Chip drivers that support both pwm and non-pwm modes
> would encounter compilation errors if the platform doesn't
> have support for pwm, even though the chip is programmed
> to work in non-pwm mode. Add stubs for pwm functions to
> avoid compilation errors in these scenarios.
> 
> Signed-off-by: Mohan Pallaka <mpallaka@codeaurora.org>
> ---
>  include/linux/pwm.h |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index 7c77575..f0bc51f 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -3,6 +3,7 @@
>  
>  struct pwm_device;
>  
> +#if defined(CONFIG_PWM)

Shouldn't it be CONFIG_HAVE_PWM?

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] pwm: Add stubs for pwm operations
Date: Tue, 17 May 2011 23:45:52 -0700	[thread overview]
Message-ID: <20110518064552.GA31801@core.coreip.homeip.net> (raw)
In-Reply-To: <1305695926-25855-2-git-send-email-mpallaka@codeaurora.org>

On Wed, May 18, 2011 at 10:48:45AM +0530, Mohan Pallaka wrote:
> Chip drivers that support both pwm and non-pwm modes
> would encounter compilation errors if the platform doesn't
> have support for pwm, even though the chip is programmed
> to work in non-pwm mode. Add stubs for pwm functions to
> avoid compilation errors in these scenarios.
> 
> Signed-off-by: Mohan Pallaka <mpallaka@codeaurora.org>
> ---
>  include/linux/pwm.h |   24 ++++++++++++++++++++++++
>  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> index 7c77575..f0bc51f 100644
> --- a/include/linux/pwm.h
> +++ b/include/linux/pwm.h
> @@ -3,6 +3,7 @@
>  
>  struct pwm_device;
>  
> +#if defined(CONFIG_PWM)

Shouldn't it be CONFIG_HAVE_PWM?

Thanks.

-- 
Dmitry

  reply	other threads:[~2011-05-18  6:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-18  5:18 [PATCH 0/2] Support for isa1200 haptic chip Mohan Pallaka
2011-05-18  5:18 ` Mohan Pallaka
2011-05-18  5:18 ` [PATCH 1/2] pwm: Add stubs for pwm operations Mohan Pallaka
2011-05-18  5:18   ` Mohan Pallaka
2011-05-18  6:45   ` Dmitry Torokhov [this message]
2011-05-18  6:45     ` Dmitry Torokhov
2011-05-18  5:18 ` [PATCH 2/2] input: misc: Add support for isa1200 chip Mohan Pallaka
2011-05-18  5:18   ` Mohan Pallaka
2011-05-18 13:00 [PATCH 1/2] pwm: Add stubs for pwm operations Mohan Pallaka
2011-05-18 13:00 ` Mohan Pallaka
2011-05-18 13:00 ` Mohan Pallaka
2011-05-20  4:59 Mohan Pallaka
2011-05-20  4:59 ` Mohan Pallaka
2011-05-21 14:30 ` Mohan Pallaka
2011-05-21 14:30   ` Mohan Pallaka
2011-05-24 11:04   ` Mohan Pallaka
2011-05-24 11:04     ` Mohan Pallaka
     [not found]     ` <4DDB90D9.1020902-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2011-05-26 11:31       ` Mohan Pallaka
2011-05-26 11:31         ` Mohan Pallaka
2011-05-26 11:31         ` Mohan Pallaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110518064552.GA31801@core.coreip.homeip.net \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mpallaka@codeaurora.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=rmk@dyn-67.arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.