From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Timur Tabi <timur@freescale.com>,
kumar.gala@freescale.com, benh@kernel.crashing.org,
akpm@kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-console@vger.kernel.org
Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Date: Thu, 19 May 2011 15:36:12 +0100 [thread overview]
Message-ID: <20110519153612.726140be@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110519142225.GC21441@kroah.com>
On Thu, 19 May 2011 07:22:25 -0700
Greg KH <greg@kroah.com> wrote:
> On Thu, May 19, 2011 at 08:54:31AM -0500, Timur Tabi wrote:
> > +/*
> > + * The udbg subsystem calls this function to display a single character.
> > + * We convert CR to a CR/LF.
> > + */
> > +static void ehv_bc_udbg_putc(char c)
> > +{
> > + if (c == '\n')
> > + byte_channel_spin_send('\r');
> > +
> > + byte_channel_spin_send(c);
> > +}
>
> Why do this conversion in the driver? Shouldn't that be something that
> userspace worries about?
udbg is a bit before the land of userspace so it needs to do whatever
adaption the firmware/happyvisor interface wants.
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: kumar.gala@freescale.com, linux-kernel@vger.kernel.org,
akpm@kernel.org, linux-console@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Timur Tabi <timur@freescale.com>
Subject: Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver
Date: Thu, 19 May 2011 15:36:12 +0100 [thread overview]
Message-ID: <20110519153612.726140be@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20110519142225.GC21441@kroah.com>
On Thu, 19 May 2011 07:22:25 -0700
Greg KH <greg@kroah.com> wrote:
> On Thu, May 19, 2011 at 08:54:31AM -0500, Timur Tabi wrote:
> > +/*
> > + * The udbg subsystem calls this function to display a single character.
> > + * We convert CR to a CR/LF.
> > + */
> > +static void ehv_bc_udbg_putc(char c)
> > +{
> > + if (c == '\n')
> > + byte_channel_spin_send('\r');
> > +
> > + byte_channel_spin_send(c);
> > +}
>
> Why do this conversion in the driver? Shouldn't that be something that
> userspace worries about?
udbg is a bit before the land of userspace so it needs to do whatever
adaption the firmware/happyvisor interface wants.
next prev parent reply other threads:[~2011-05-19 14:37 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 13:54 [PATCH 0/7] This patchset adds support for running Linux under the Freescale hypervisor, Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 13:54 ` [PATCH 1/7] powerpc: make irq_choose_cpu() available to all PIC drivers Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 2/7] powerpc: introduce ePAPR embedded hypervisor hcall interface Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 3/7] powerpc: introduce the ePAPR embedded hypervisor vmpic driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 4/7] powerpc: add Freescale hypervisor partition control functions Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-06-22 11:41 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 5/7] powerpc/85xx: add board support for the Freescale hypervisor Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-06-22 11:42 ` Kumar Gala
2011-06-22 11:42 ` Kumar Gala
2011-06-22 11:42 ` Kumar Gala
2011-05-19 13:54 ` [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisor byte channel driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 14:22 ` Greg KH
2011-05-19 14:22 ` Greg KH
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:27 ` Timur Tabi
2011-05-19 14:36 ` Alan Cox [this message]
2011-05-19 14:36 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 14:33 ` Alan Cox
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:14 ` Timur Tabi
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:50 ` Alan Cox
2011-05-19 15:54 ` Timur Tabi
2011-05-19 15:54 ` Timur Tabi
2011-05-19 15:54 ` Timur Tabi
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:00 ` Alan Cox
2011-05-19 16:02 ` Greg KH
2011-05-19 16:02 ` Greg KH
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:18 ` Timur Tabi
2011-05-19 16:05 ` Timur Tabi
2011-05-19 16:05 ` Timur Tabi
2011-05-19 16:05 ` Timur Tabi
2011-05-20 9:54 ` Alan Cox
2011-05-20 9:54 ` Alan Cox
2011-05-20 9:54 ` Alan Cox
2011-05-19 16:31 ` Timur Tabi
2011-05-19 16:31 ` Timur Tabi
2011-05-19 16:31 ` Timur Tabi
2011-05-19 17:25 ` Alan Cox
2011-05-19 17:25 ` Alan Cox
2011-05-19 17:25 ` Alan Cox
2011-05-19 15:02 ` Arnd Bergmann
2011-05-19 15:02 ` Arnd Bergmann
2011-05-19 15:09 ` Timur Tabi
2011-05-19 15:09 ` Timur Tabi
2011-05-19 15:09 ` Timur Tabi
2011-05-19 13:54 ` [PATCH 7/7] drivers/misc: introduce Freescale hypervisor management driver Timur Tabi
2011-05-19 13:54 ` Timur Tabi
2011-05-19 13:56 ` [PATCH 0/7] This patchset adds support for running Linux under the Freescale hypervisor, Timur Tabi
2011-05-19 13:56 ` Timur Tabi
2011-05-20 20:29 ` Kumar Gala
2011-05-20 20:29 ` Kumar Gala
2011-05-20 20:29 ` Kumar Gala
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 21:09 ` Tabi Timur-B04825
2011-05-23 22:27 ` Kumar Gala
2011-05-23 22:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519153612.726140be@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=kumar.gala@freescale.com \
--cc=linux-console@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.