All of lore.kernel.org
 help / color / mirror / Atom feed
* ppp, "Features changed" flooding the log
@ 2011-05-20 13:42 Denys Fedoryshchenko
  2011-05-20 13:44 ` Denys Fedoryshchenko
  2011-05-20 18:22 ` David Miller
  0 siblings, 2 replies; 4+ messages in thread
From: Denys Fedoryshchenko @ 2011-05-20 13:42 UTC (permalink / raw)
  To: netdev

 Hi

 Is it supposed to be like this?
 [   41.575487] ppp313: Features changed: 0x00006800 -> 0x00006000
 [   41.681499] ppp314: Features changed: 0x00006800 -> 0x00006000
 [   41.796728] ppp315: Features changed: 0x00006800 -> 0x00006000
 [   41.909575] ppp316: Features changed: 0x00006800 -> 0x00006000
 [   42.027802] ppp317: Features changed: 0x00006800 -> 0x00006000
 [   42.142698] ppp318: Features changed: 0x00006800 -> 0x00006000
 [   42.292753] ppp319: Features changed: 0x00006800 -> 0x00006000
 [   42.408706] ppp320: Features changed: 0x00006800 -> 0x00006000
 [   42.544745] ppp321: Features changed: 0x00006800 -> 0x00006000
 [   42.634743] ppp322: Features changed: 0x00006800 -> 0x00006000
 [   42.740747] ppp323: Features changed: 0x00006800 -> 0x00006000
 [   42.856579] ppp324: Features changed: 0x00006800 -> 0x00006000

 I guess ppp dropping GSO, but is it should be there on first place?
 GSO is disabled on all ethernet interfaces.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ppp, "Features changed" flooding the log
  2011-05-20 13:42 ppp, "Features changed" flooding the log Denys Fedoryshchenko
@ 2011-05-20 13:44 ` Denys Fedoryshchenko
  2011-05-20 14:00   ` Eric Dumazet
  2011-05-20 18:22 ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Denys Fedoryshchenko @ 2011-05-20 13:44 UTC (permalink / raw)
  To: Denys Fedoryshchenko; +Cc: netdev

 On Fri, 20 May 2011 16:42:08 +0300, Denys Fedoryshchenko wrote:
> Hi
>
> Is it supposed to be like this?
> [   41.575487] ppp313: Features changed: 0x00006800 -> 0x00006000
> [   41.681499] ppp314: Features changed: 0x00006800 -> 0x00006000
> [   41.796728] ppp315: Features changed: 0x00006800 -> 0x00006000
> [   41.909575] ppp316: Features changed: 0x00006800 -> 0x00006000
> [   42.027802] ppp317: Features changed: 0x00006800 -> 0x00006000
> [   42.142698] ppp318: Features changed: 0x00006800 -> 0x00006000
> [   42.292753] ppp319: Features changed: 0x00006800 -> 0x00006000
> [   42.408706] ppp320: Features changed: 0x00006800 -> 0x00006000
> [   42.544745] ppp321: Features changed: 0x00006800 -> 0x00006000
> [   42.634743] ppp322: Features changed: 0x00006800 -> 0x00006000
> [   42.740747] ppp323: Features changed: 0x00006800 -> 0x00006000
> [   42.856579] ppp324: Features changed: 0x00006800 -> 0x00006000
>
> I guess ppp dropping GSO, but is it should be there on first place?
> GSO is disabled on all ethernet interfaces.
 And as i see GRO enabled there, i guess it can be harmful for shapers, 
 how to disable it?
 NewNet-PPPoE ~ # ethtool -K ppp0 gro off
 Cannot set device GRO settings: Operation not supported
 Or there is no need for that?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ppp, "Features changed" flooding the log
  2011-05-20 13:44 ` Denys Fedoryshchenko
@ 2011-05-20 14:00   ` Eric Dumazet
  0 siblings, 0 replies; 4+ messages in thread
From: Eric Dumazet @ 2011-05-20 14:00 UTC (permalink / raw)
  To: Denys Fedoryshchenko; +Cc: netdev

Le vendredi 20 mai 2011 à 16:44 +0300, Denys Fedoryshchenko a écrit :

>  And as i see GRO enabled there, i guess it can be harmful for shapers, 
>  how to disable it?
>  NewNet-PPPoE ~ # ethtool -K ppp0 gro off
>  Cannot set device GRO settings: Operation not supported
>  Or there is no need for that?
> --

No need, since GRO sits on top of NAPI (physical devices)

ppp is done after this layer, frames are directly delivered to IP layer.

But yes, this log flood is nasty.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: ppp, "Features changed" flooding the log
  2011-05-20 13:42 ppp, "Features changed" flooding the log Denys Fedoryshchenko
  2011-05-20 13:44 ` Denys Fedoryshchenko
@ 2011-05-20 18:22 ` David Miller
  1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2011-05-20 18:22 UTC (permalink / raw)
  To: denys; +Cc: netdev

From: Denys Fedoryshchenko <denys@visp.net.lb>
Date: Fri, 20 May 2011 16:42:08 +0300

> Hi
> 
> Is it supposed to be like this?
> [   41.575487] ppp313: Features changed: 0x00006800 -> 0x00006000
> [   41.681499] ppp314: Features changed: 0x00006800 -> 0x00006000
> [   41.796728] ppp315: Features changed: 0x00006800 -> 0x00006000
> [   41.909575] ppp316: Features changed: 0x00006800 -> 0x00006000
> [   42.027802] ppp317: Features changed: 0x00006800 -> 0x00006000
> [   42.142698] ppp318: Features changed: 0x00006800 -> 0x00006000
> [   42.292753] ppp319: Features changed: 0x00006800 -> 0x00006000
> [   42.408706] ppp320: Features changed: 0x00006800 -> 0x00006000
> [   42.544745] ppp321: Features changed: 0x00006800 -> 0x00006000
> [   42.634743] ppp322: Features changed: 0x00006800 -> 0x00006000
> [   42.740747] ppp323: Features changed: 0x00006800 -> 0x00006000
> [   42.856579] ppp324: Features changed: 0x00006800 -> 0x00006000
> 
> I guess ppp dropping GSO, but is it should be there on first place?
> GSO is disabled on all ethernet interfaces.

Linus released 2.6.39 before I could merge the patch that gets rid
of this, will send it to 2.6.39-stable.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-05-20 18:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 13:42 ppp, "Features changed" flooding the log Denys Fedoryshchenko
2011-05-20 13:44 ` Denys Fedoryshchenko
2011-05-20 14:00   ` Eric Dumazet
2011-05-20 18:22 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.