[PATCH] netdev: stop Features changed message

[PATCH] netdev: stop Features changed message

[Stephen Hemminger]

The new in 2.6.39 message "Features changed:" occurs a lot
on many configurations. It provides information to driver developers
but is not user friendly. Printing out hex values is just confusing.
Reduce priority so that it doesn't show up unless debugging.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/core/dev.c	2011-05-20 08:59:40.248885114 -0700
+++ b/net/core/dev.c	2011-05-20 09:00:32.925437770 -0700
@@ -5258,7 +5258,7 @@ void netdev_update_features(struct net_d
 	if (dev->features == features)
 		return;
 
-	netdev_info(dev, "Features changed: 0x%08x -> 0x%08x\n",
+	netdev_dbg(dev, "Features changed: 0x%08x -> 0x%08x\n",
 		dev->features, features);
 
 	if (dev->netdev_ops->ndo_set_features)

Re: [PATCH] netdev: stop Features changed message

[Michał Mirosław]

2011/5/20 Stephen Hemminger <shemminger@vyatta.com>:
> The new in 2.6.39 message "Features changed:" occurs a lot
> on many configurations. It provides information to driver developers
> but is not user friendly. Printing out hex values is just confusing.
> Reduce priority so that it doesn't show up unless debugging.

The same patch is already in net-next:
604ae14ffb6d75d6eef4757859226b758d6bf9e3. Wasn't it meat for
net/stable back then?

Best Regards,
Michał Mirosław

Re: [PATCH] netdev: stop Features changed message

[David Miller]

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Fri, 20 May 2011 09:02:08 -0700

> The new in 2.6.39 message "Features changed:" occurs a lot
> on many configurations. It provides information to driver developers
> but is not user friendly. Printing out hex values is just confusing.
> Reduce priority so that it doesn't show up unless debugging.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

THis was already in net-2.6 and is queued up for 2.6.39-stable

Re: [PATCH] netdev: stop Features changed message

[Stephen Hemminger]

On Fri, 20 May 2011 14:26:50 -0400 (EDT)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Fri, 20 May 2011 09:02:08 -0700
> 
> > The new in 2.6.39 message "Features changed:" occurs a lot
> > on many configurations. It provides information to driver developers
> > but is not user friendly. Printing out hex values is just confusing.
> > Reduce priority so that it doesn't show up unless debugging.
> > 
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
> 
> THis was already in net-2.6 and is queued up for 2.6.39-stable

ok.

--