All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old()
@ 2011-05-19 22:09 David Miller
  2011-05-20  2:43 ` Gustavo F. Padovan
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2011-05-19 22:09 UTC (permalink / raw)
  To: linux-bluetooth


Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
index 386cfaf..bcf077c 100644
--- a/net/bluetooth/rfcomm/sock.c
+++ b/net/bluetooth/rfcomm/sock.c
@@ -741,7 +741,6 @@ static int rfcomm_sock_setsockopt(struct socket *sock, int level, int optname, c
 static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __user *optval, int __user *optlen)
 {
 	struct sock *sk = sock->sk;
-	struct sock *l2cap_sk;
 	struct rfcomm_conninfo cinfo;
 	struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;
 	int len, err = 0;
@@ -786,8 +785,6 @@ static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __u
 			break;
 		}
 
-		l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
-
 		cinfo.hci_handle = conn->hcon->handle;
 		memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old()
  2011-05-19 22:09 [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old() David Miller
@ 2011-05-20  2:43 ` Gustavo F. Padovan
  0 siblings, 0 replies; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-05-20  2:43 UTC (permalink / raw)
  To: David Miller; +Cc: linux-bluetooth

* David Miller <davem@davemloft.net> [2011-05-19 18:09:00 -0400]:

> 
> Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
> index 386cfaf..bcf077c 100644
> --- a/net/bluetooth/rfcomm/sock.c
> +++ b/net/bluetooth/rfcomm/sock.c
> @@ -741,7 +741,6 @@ static int rfcomm_sock_setsockopt(struct socket *sock, int level, int optname, c
>  static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __user *optval, int __user *optlen)
>  {
>  	struct sock *sk = sock->sk;
> -	struct sock *l2cap_sk;
>  	struct rfcomm_conninfo cinfo;
>  	struct l2cap_conn *conn = l2cap_pi(sk)->chan->conn;
>  	int len, err = 0;
> @@ -786,8 +785,6 @@ static int rfcomm_sock_getsockopt_old(struct socket *sock, int optname, char __u
>  			break;
>  		}
>  
> -		l2cap_sk = rfcomm_pi(sk)->dlc->session->sock->sk;
> -
>  		cinfo.hci_handle = conn->hcon->handle;
>  		memcpy(cinfo.dev_class, conn->hcon->dev_class, 3);

applied, thanks.

-- 
Gustavo F. Padovan
http://profusion.mobi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-20  2:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-19 22:09 [PATCH] bluetooth: Kill set but not used variable 'l2cap_sk' in rfcomm_sock_getsockopt_old() David Miller
2011-05-20  2:43 ` Gustavo F. Padovan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.