linux-next: build failure after merge of the s390 tree

linux-next: build failure after merge of the s390 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

Hi all,

After merging the s390 tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

mm/rmap.c:788:54: error: macro "page_test_and_clear_dirty" passed 2 arguments, but takes just 1
mm/rmap.c: In function 'page_mkclean':
mm/rmap.c:788: error: 'page_test_and_clear_dirty' undeclared (first use in this function)
mm/rmap.c:788: error: (Each undeclared identifier is reported only once
mm/rmap.c:788: error: for each function it appears in.)
mm/rmap.c:983:52: error: macro "page_test_and_clear_dirty" passed 2 arguments, but takes just 1
mm/rmap.c: In function 'page_remove_rmap':
mm/rmap.c:983: error: 'page_test_and_clear_dirty' undeclared (first use in this function)

Caused by commit 4cbfc8b9f58c ("[S390] merge page_test_dirty and page_clear_dirty").

I have used the s390 tree from next-20110519 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the s390 tree

[Martin Schwidefsky]

On Fri, 20 May 2011 11:56:51 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> After merging the s390 tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> mm/rmap.c:788:54: error: macro "page_test_and_clear_dirty" passed 2 arguments, but takes just 1
> mm/rmap.c: In function 'page_mkclean':
> mm/rmap.c:788: error: 'page_test_and_clear_dirty' undeclared (first use in this function)
> mm/rmap.c:788: error: (Each undeclared identifier is reported only once
> mm/rmap.c:788: error: for each function it appears in.)
> mm/rmap.c:983:52: error: macro "page_test_and_clear_dirty" passed 2 arguments, but takes just 1
> mm/rmap.c: In function 'page_remove_rmap':
> mm/rmap.c:983: error: 'page_test_and_clear_dirty' undeclared (first use in this function)
> 
> Caused by commit 4cbfc8b9f58c ("[S390] merge page_test_dirty and page_clear_dirty").
> 
> I have used the s390 tree from next-20110519 for today.

Oops, sorry about that. Fixed the patch and updated git390.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

Re: linux-next: build failure after merge of the s390 tree

[Heiko Carstens]

On Tue, Jan 10, 2023 at 08:22:21PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the s390 tree, today's linux-next build (s390 allmodconfig)
> failed like this:
> 
> drivers/s390/char/con3270.c:43:24: error: 'condev' defined but not used [-Werror=unused-variable]
>  static struct tty3270 *condev;
>                         ^~~~~~
> 
> Caused by commit
> 
>   c17fe081ac1f ("s390/3270: unify con3270 + tty3270")

Thank you for reporting. This should be fixed now:
https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=features&id=9cab4f7d98eee90b762ffbc87055c9499d51a635

linux-next: build failure after merge of the s390 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

Hi all,

After merging the s390 tree, today's linux-next build (s390 allmodconfig)
failed like this:

drivers/s390/char/con3270.c:43:24: error: 'condev' defined but not used [-Werror=unused-variable]
 static struct tty3270 *condev;
                        ^~~~~~

Caused by commit

  c17fe081ac1f ("s390/3270: unify con3270 + tty3270")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]