* [PATCH]: Fix Ultrastor asm snippet
@ 2011-05-18 15:06 Samuel Thibault
2011-05-20 13:02 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Samuel Thibault @ 2011-05-18 15:06 UTC (permalink / raw)
To: James.Bottomley; +Cc: linux-kernel, linux-scsi, akpm
Commit 1292500b replaced
"=m" (*field) : "1" (*field)
with
"=m" (*field) :
with comment "The following patch fixes it by using the '+' operator on
the (*field) operand, marking it as read-write to gcc."
'+' was actually forgotten. This really puts it.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
diff --git a/drivers/scsi/ultrastor.c b/drivers/scsi/ultrastor.c
index 0571ef9..dc076e0 100644
--- a/drivers/scsi/ultrastor.c
+++ b/drivers/scsi/ultrastor.c
@@ -306,7 +306,7 @@ static inline int find_and_clear_bit_16(unsigned long *field)
"0: bsfw %1,%w0\n\t"
"btr %0,%1\n\t"
"jnc 0b"
- : "=&r" (rv), "=m" (*field) :);
+ : "=&r" (rv), "+m" (*field) :);
return rv;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH]: Fix Ultrastor asm snippet
2011-05-18 15:06 [PATCH]: Fix Ultrastor asm snippet Samuel Thibault
@ 2011-05-20 13:02 ` Christoph Hellwig
2011-05-20 13:04 ` Samuel Thibault
2011-05-20 13:24 ` Alan Cox
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2011-05-20 13:02 UTC (permalink / raw)
To: Samuel Thibault, James.Bottomley, linux-kernel, linux-scsi, akpm
On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> Commit 1292500b replaced
>
> "=m" (*field) : "1" (*field)
>
> with
>
> "=m" (*field) :
>
> with comment "The following patch fixes it by using the '+' operator on
> the (*field) operand, marking it as read-write to gcc."
> '+' was actually forgotten. This really puts it.
Do you actually have the hardware or was this just a code audit?
I have the strong suspicion that this driver is pretty much dead and
bitrotting.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: Fix Ultrastor asm snippet
2011-05-20 13:02 ` Christoph Hellwig
@ 2011-05-20 13:04 ` Samuel Thibault
2011-05-20 13:24 ` Alan Cox
1 sibling, 0 replies; 5+ messages in thread
From: Samuel Thibault @ 2011-05-20 13:04 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: James.Bottomley, linux-kernel, linux-scsi, akpm
Christoph Hellwig, le Fri 20 May 2011 09:02:15 -0400, a écrit :
> On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > Commit 1292500b replaced
> >
> > "=m" (*field) : "1" (*field)
> >
> > with
> >
> > "=m" (*field) :
> >
> > with comment "The following patch fixes it by using the '+' operator on
> > the (*field) operand, marking it as read-write to gcc."
> > '+' was actually forgotten. This really puts it.
>
> Do you actually have the hardware or was this just a code audit?
Just a code audit.
> I have the strong suspicion that this driver is pretty much dead and
> bitrotting.
Most probably, yes.
Samuel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: Fix Ultrastor asm snippet
2011-05-20 13:02 ` Christoph Hellwig
2011-05-20 13:04 ` Samuel Thibault
@ 2011-05-20 13:24 ` Alan Cox
2011-05-24 17:28 ` James Bottomley
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2011-05-20 13:24 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Samuel Thibault, James.Bottomley, linux-kernel, linux-scsi, akpm
On Fri, 20 May 2011 09:02:15 -0400
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > Commit 1292500b replaced
> >
> > "=m" (*field) : "1" (*field)
> >
> > with
> >
> > "=m" (*field) :
> >
> > with comment "The following patch fixes it by using the '+' operator on
> > the (*field) operand, marking it as read-write to gcc."
> > '+' was actually forgotten. This really puts it.
>
> Do you actually have the hardware or was this just a code audit?
>
> I have the strong suspicion that this driver is pretty much dead and
> bitrotting.
There are a pile of scsi drivers like the Ultrastor that probably want
retiring via staging.
I can believe an AHA152x or two lurk around, and the odd NCR53c80 and
clones because they were so voluminous but the rest I doubt somewhat.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH]: Fix Ultrastor asm snippet
2011-05-20 13:24 ` Alan Cox
@ 2011-05-24 17:28 ` James Bottomley
0 siblings, 0 replies; 5+ messages in thread
From: James Bottomley @ 2011-05-24 17:28 UTC (permalink / raw)
To: Alan Cox
Cc: Christoph Hellwig, Samuel Thibault, James.Bottomley,
linux-kernel, linux-scsi, akpm
On Fri, 2011-05-20 at 14:24 +0100, Alan Cox wrote:
> On Fri, 20 May 2011 09:02:15 -0400
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > > Commit 1292500b replaced
> > >
> > > "=m" (*field) : "1" (*field)
> > >
> > > with
> > >
> > > "=m" (*field) :
> > >
> > > with comment "The following patch fixes it by using the '+' operator on
> > > the (*field) operand, marking it as read-write to gcc."
> > > '+' was actually forgotten. This really puts it.
> >
> > Do you actually have the hardware or was this just a code audit?
> >
> > I have the strong suspicion that this driver is pretty much dead and
> > bitrotting.
>
> There are a pile of scsi drivers like the Ultrastor that probably want
> retiring via staging.
OK, can someone work out how we do this and then send the patch (I
assume it's just an update in the deprecated features and a move to
staging?)
> I can believe an AHA152x or two lurk around,
Yes, got one ... and occasionally even test with it.
> and the odd NCR53c80 and
> clones because they were so voluminous but the rest I doubt somewhat.
James
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-24 21:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-18 15:06 [PATCH]: Fix Ultrastor asm snippet Samuel Thibault
2011-05-20 13:02 ` Christoph Hellwig
2011-05-20 13:04 ` Samuel Thibault
2011-05-20 13:24 ` Alan Cox
2011-05-24 17:28 ` James Bottomley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.