[PATCH] jbd2: Fix comment to match the code in jbd2__journal_start()

[PATCH] jbd2: Fix comment to match the code in jbd2__journal_start()

[Eryu Guan]

jbd2__journal_start() returns an ERR_PTR() value rather than NULL on
failure.

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
---
 fs/jbd2/transaction.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
index 05fa77a..7e6a5d6 100644
--- a/fs/jbd2/transaction.c
+++ b/fs/jbd2/transaction.c
@@ -316,7 +316,8 @@ static handle_t *new_handle(int nblocks)
  * This function is visible to journal users (like ext3fs), so is not
  * called with the journal already locked.
  *
- * Return a pointer to a newly allocated handle, or NULL on failure
+ * Return a pointer to a newly allocated handle, or an ERR_PTR() value
+ * on failure.
  */
 handle_t *jbd2__journal_start(journal_t *journal, int nblocks, int gfp_mask)
 {
-- 
1.7.3.4

Re: [PATCH] jbd2: Fix comment to match the code in jbd2__journal_start()

[Jan Kara]

On Tue 24-05-11 00:17:58, Eryu Guan wrote:
> jbd2__journal_start() returns an ERR_PTR() value rather than NULL on
> failure.
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
  Thanks, but please include Ted Ts'o <tytso@mit.edu> in JBD2 patches.
Thanks.

Ted, I've realized that MAINTAINERS has only entry like:
JOURNALLING LAYER FOR BLOCK DEVICES (JBD)
M:      Andrew Morton <akpm@linux-foundation.org>
M:      Jan Kara <jack@suse.cz>
L:      linux-ext4@vger.kernel.org
S:      Maintained
F:      fs/jbd*/
F:      include/linux/ext*jbd*.h
F:      include/linux/jbd*.h

I guess you should add a separate entry for JBD2 so that people will find
you ;).

								Honza
> ---
>  fs/jbd2/transaction.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c
> index 05fa77a..7e6a5d6 100644
> --- a/fs/jbd2/transaction.c
> +++ b/fs/jbd2/transaction.c
> @@ -316,7 +316,8 @@ static handle_t *new_handle(int nblocks)
>   * This function is visible to journal users (like ext3fs), so is not
>   * called with the journal already locked.
>   *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
>   */
>  handle_t *jbd2__journal_start(journal_t *journal, int nblocks, int gfp_mask)
>  {
> -- 
> 1.7.3.4
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

Re: [PATCH] jbd2: Fix comment to match the code in jbd2__journal_start()

[Ted Ts'o]

On Tue, May 24, 2011 at 12:17:58AM +0800, Eryu Guan wrote:
> jbd2__journal_start() returns an ERR_PTR() value rather than NULL on
> failure.
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>

Thanks, added to the ext4 tree.

						- Ted

[PATCH] jbd2: Add MAINTAINERS entry

[Theodore Ts'o]

Create a separate MAINTAINERS entry for jbd2

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
 MAINTAINERS |   13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 649600c..0682c0e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3552,9 +3552,16 @@ M:	Andrew Morton <akpm@linux-foundation.org>
 M:	Jan Kara <jack@suse.cz>
 L:	linux-ext4@vger.kernel.org
 S:	Maintained
-F:	fs/jbd*/
-F:	include/linux/ext*jbd*.h
-F:	include/linux/jbd*.h
+F:	fs/jbd/
+F:	include/linux/ext3_jbd.h
+F:	include/linux/jbd.h
+
+JOURNALLING LAYER FOR BLOCK DEVICES (JBD2)
+M:	"Theodore Ts'o" <tytso@mit.edu>
+L:	linux-ext4@vger.kernel.org
+S:	Maintained
+F:	fs/jbd2/
+F:	include/linux/jbd2.h
 
 JSM Neo PCI based serial card
 M:	Breno Leitao <leitao@linux.vnet.ibm.com>
-- 
1.7.3.1

Re: [PATCH] jbd2: Add MAINTAINERS entry

[Jan Kara]

On Thu 26-05-11 09:53:54, Ted Tso wrote:
> Create a separate MAINTAINERS entry for jbd2
> 
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
  Acked-by: Jan Kara <jack@suse.cz>

								Honza
> ---
>  MAINTAINERS |   13 ++++++++++---
>  1 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 649600c..0682c0e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3552,9 +3552,16 @@ M:	Andrew Morton <akpm@linux-foundation.org>
>  M:	Jan Kara <jack@suse.cz>
>  L:	linux-ext4@vger.kernel.org
>  S:	Maintained
> -F:	fs/jbd*/
> -F:	include/linux/ext*jbd*.h
> -F:	include/linux/jbd*.h
> +F:	fs/jbd/
> +F:	include/linux/ext3_jbd.h
> +F:	include/linux/jbd.h
> +
> +JOURNALLING LAYER FOR BLOCK DEVICES (JBD2)
> +M:	"Theodore Ts'o" <tytso@mit.edu>
> +L:	linux-ext4@vger.kernel.org
> +S:	Maintained
> +F:	fs/jbd2/
> +F:	include/linux/jbd2.h
>  
>  JSM Neo PCI based serial card
>  M:	Breno Leitao <leitao@linux.vnet.ibm.com>
> -- 
> 1.7.3.1
> 
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR