* [PATCH 1 of 9] MD: possible typo
@ 2011-05-24 3:05 Jonathan Brassow
2011-05-24 22:18 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Brassow @ 2011-05-24 3:05 UTC (permalink / raw)
To: linux-raid
Patch name: md-possible-typo.patch
Fix a value printed in kiB but labeled as 'blocks'.
Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
Index: linux-2.6/drivers/md/md.c
===================================================================
--- linux-2.6.orig/drivers/md/md.c
+++ linux-2.6/drivers/md/md.c
@@ -6867,7 +6867,7 @@ void md_do_sync(mddev_t *mddev)
*/
window = 32*(PAGE_SIZE/512);
printk(KERN_INFO "md: using %dk window, over a total of %llu blocks.\n",
- window/2,(unsigned long long) max_sectors/2);
+ window/2, (unsigned long long) max_sectors);
atomic_set(&mddev->recovery_active, 0);
last_check = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1 of 9] MD: possible typo
2011-05-24 3:05 [PATCH 1 of 9] MD: possible typo Jonathan Brassow
@ 2011-05-24 22:18 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-05-24 22:18 UTC (permalink / raw)
To: Jonathan Brassow; +Cc: linux-raid
On Mon, 23 May 2011 22:05:58 -0500 Jonathan Brassow <jbrassow@f14.redhat.com>
wrote:
> Patch name: md-possible-typo.patch
>
> Fix a value printed in kiB but labeled as 'blocks'.
>
> Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
> Index: linux-2.6/drivers/md/md.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/md.c
> +++ linux-2.6/drivers/md/md.c
> @@ -6867,7 +6867,7 @@ void md_do_sync(mddev_t *mddev)
> */
> window = 32*(PAGE_SIZE/512);
> printk(KERN_INFO "md: using %dk window, over a total of %llu blocks.\n",
> - window/2,(unsigned long long) max_sectors/2);
> + window/2, (unsigned long long) max_sectors);
>
> atomic_set(&mddev->recovery_active, 0);
> last_check = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
"blocks" has traditionally meant "kibibytes" in md nomenclature, so this was
"correct".
I'd be quite happy to change the word "blocks" to "KB" (or even "KiB") though.
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-24 22:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-24 3:05 [PATCH 1 of 9] MD: possible typo Jonathan Brassow
2011-05-24 22:18 ` NeilBrown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.