From: Ted Ts'o <tytso@mit.edu>
To: Surbhi Palande <surbhi.palande@canonical.com>
Cc: sandeen@redhat.com, jack@suse.cz, marco.stornelli@gmail.com,
adilger.kernel@dilger.ca, toshi.okajima@jp.fujitsu.com,
m.mizuma@jp.fujitsu.com, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Attempt to sync the fsstress writes to a frozen F.S
Date: Tue, 24 May 2011 17:42:23 -0400 [thread overview]
Message-ID: <20110524214222.GF26055@thunk.org> (raw)
In-Reply-To: <1305097841-2308-1-git-send-email-surbhi.palande@canonical.com>
On Wed, May 11, 2011 at 10:10:41AM +0300, Surbhi Palande wrote:
> While the fsstress background writes are busy dirtying the page cache, if a
> fsfreeze happens then the background writes should stall. A sync should then
> not have any data to sync to the FS. If it does have any data to sync then
> sync will cause a deadlock by holding the s_umount write semaphore and waiting
> in the wait queue for the FS to thaw, whereas the F.S can never thaw without
> getting the s_umount write semaphore.
>
> Signed-off-by: Surbhi Palande <surbhi.palande@canonical.com>
Hi Surbhi,
Have you tried out Jan Kara's patches?
[1/3] fs: Create __block_page_mkwrite() helper passing error values back
[2/3] vfs: Block mmapped writes while the fs is frozen
[3/3] ext4: Rewrite ext4_page_mkwrite() to return locked page
Do these patches fix the problem you've been trying to fix with your
patches? I believe they should, but I would appreciate confirmation
that with these patches, you're no longer able to reproduce the
problem you've been concerned about.
Thanks, regards,
- Ted
next prev parent reply other threads:[~2011-05-24 21:42 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 11:53 [BUG] ext4: cannot unfreeze a filesystem due to a deadlock Masayoshi MIZUMA
2011-02-15 16:06 ` Jan Kara
2011-02-15 17:03 ` Ted Ts'o
2011-02-15 17:29 ` Jan Kara
2011-02-15 18:04 ` Ted Ts'o
2011-02-15 19:11 ` Jan Kara
2011-02-15 23:17 ` Toshiyuki Okajima
2011-02-16 14:56 ` Jan Kara
2011-02-17 3:50 ` Toshiyuki Okajima
2011-02-17 5:13 ` Andreas Dilger
2011-02-17 10:41 ` Jan Kara
2011-02-17 10:45 ` Jan Kara
2011-03-28 8:06 ` [RFC][PATCH] " Toshiyuki Okajima
2011-03-30 14:12 ` Jan Kara
2011-03-31 8:37 ` Yongqiang Yang
2011-03-31 8:48 ` Yongqiang Yang
2011-03-31 14:04 ` Eric Sandeen
2011-03-31 14:36 ` Yongqiang Yang
2011-03-31 15:25 ` Eric Sandeen
2011-03-31 16:28 ` Jan Kara
2011-03-31 12:03 ` Toshiyuki Okajima
2011-04-05 10:25 ` Toshiyuki Okajima
2011-04-05 22:54 ` Jan Kara
2011-04-06 5:09 ` Toshiyuki Okajima
2011-04-06 5:57 ` Jan Kara
2011-04-06 7:40 ` Toshiyuki Okajima
2011-04-06 17:46 ` Jan Kara
2011-04-15 13:39 ` Toshiyuki Okajima
2011-04-15 17:13 ` Jan Kara
2011-04-15 17:17 ` Eric Sandeen
2011-04-15 17:37 ` Jan Kara
2011-04-18 9:05 ` Toshiyuki Okajima
2011-04-18 10:51 ` Jan Kara
2011-04-19 9:43 ` Toshiyuki Okajima
2011-04-22 6:58 ` Toshiyuki Okajima
2011-04-22 21:26 ` Peter M. Petrakis
2011-04-22 21:40 ` Jan Kara
2011-04-22 22:57 ` Peter M. Petrakis
2011-04-22 22:10 ` Jan Kara
2011-04-25 6:28 ` Toshiyuki Okajima
2011-05-03 8:06 ` Surbhi Palande
2011-05-03 11:01 ` Surbhi Palande
2011-05-03 13:08 ` (unknown), Surbhi Palande
2011-05-03 13:46 ` your mail Jan Kara
2011-05-03 13:56 ` Surbhi Palande
2011-05-03 15:26 ` Surbhi Palande
2011-05-03 15:36 ` Jan Kara
2011-05-03 15:43 ` Surbhi Palande
2011-05-04 19:24 ` Jan Kara
2011-05-06 15:20 ` [RFC][PATCH] Do not accept a new handle when the F.S is frozen Surbhi Palande
2011-05-06 15:20 ` [PATCH] Adding support to freeze and unfreeze a journal Surbhi Palande
2011-05-06 20:56 ` Andreas Dilger
2011-05-07 20:04 ` [PATCH v2] " Surbhi Palande
2011-05-08 8:24 ` Marco Stornelli
2011-05-09 9:04 ` Surbhi Palande
2011-05-09 9:24 ` Jan Kara
2011-05-09 9:53 ` Jan Kara
2011-05-09 13:49 ` Surbhi Palande
2011-05-09 14:51 ` [PATCH v3] " Surbhi Palande
2011-05-09 15:08 ` Jan Kara
2011-05-10 15:07 ` [PATCH] " Surbhi Palande
2011-05-10 21:07 ` Andreas Dilger
2011-05-11 7:46 ` Surbhi Palande
2011-05-09 15:23 ` [PATCH v3] " Eric Sandeen
2011-05-11 7:06 ` Surbhi Palande
2011-05-11 7:10 ` [PATCH] Attempt to sync the fsstress writes to a frozen F.S Surbhi Palande
2011-05-12 14:22 ` Eric Sandeen
2011-05-12 14:22 ` Eric Sandeen
2011-05-24 21:42 ` Ted Ts'o [this message]
2011-05-25 12:00 ` Surbhi Palande
2011-05-25 12:12 ` Theodore Tso
2011-05-27 16:28 ` Jan Kara
2011-05-11 9:05 ` [PATCH v3] Adding support to freeze and unfreeze a journal Andreas Dilger
2011-05-12 9:40 ` Surbhi Palande
2011-05-03 13:08 ` [PATCH] Prevent dirtying a page when ext4 F.S is frozen Surbhi Palande
2011-05-03 15:19 ` [RFC][PATCH] Re: [BUG] ext4: cannot unfreeze a filesystem due to a deadlock Jan Kara
2011-05-04 12:09 ` Surbhi Palande
2011-05-04 19:19 ` Jan Kara
2011-05-04 21:34 ` Surbhi Palande
2011-05-04 22:48 ` Jan Kara
2011-05-05 6:06 ` Surbhi Palande
2011-05-05 11:18 ` Jan Kara
2011-05-05 14:01 ` Surbhi Palande
2011-03-31 23:40 ` Dave Chinner
2011-03-31 23:53 ` Eric Sandeen
2011-04-01 14:08 ` Jan Kara
2011-04-06 5:40 ` Dave Chinner
2011-04-06 6:18 ` Jan Kara
2011-04-06 11:21 ` Dave Chinner
2011-04-06 13:44 ` Christoph Hellwig
2011-04-06 22:59 ` Dave Chinner
2011-04-06 17:40 ` Jan Kara
2011-04-06 22:54 ` Dave Chinner
2011-04-08 21:33 ` Jan Kara
2011-05-02 9:07 ` Surbhi Palande
2011-05-02 10:56 ` Jan Kara
2011-05-02 11:27 ` Surbhi Palande
2011-05-02 12:06 ` Surbhi Palande
2011-05-02 12:20 ` Jan Kara
2011-05-02 12:30 ` Surbhi Palande
2011-05-02 13:16 ` Jan Kara
2011-05-02 13:22 ` Christoph Hellwig
2011-05-02 14:20 ` Jan Kara
2011-05-02 14:41 ` Christoph Hellwig
2011-05-02 16:23 ` Jan Kara
2011-05-02 16:38 ` Christoph Hellwig
2011-05-02 13:22 ` Surbhi Palande
2011-05-02 13:24 ` Christoph Hellwig
2011-05-02 13:27 ` Surbhi Palande
2011-05-02 14:26 ` Jan Kara
2011-05-02 14:04 ` Eric Sandeen
2011-05-03 7:27 ` Surbhi Palande
2011-05-03 20:14 ` Eric Sandeen
2011-05-04 8:26 ` Surbhi Palande
2011-05-04 14:30 ` Eric Sandeen
2011-05-02 14:01 ` Eric Sandeen
2011-04-05 10:44 ` Toshiyuki Okajima
2011-12-09 1:56 ` Masayoshi MIZUMA
2011-12-15 12:41 ` Masayoshi MIZUMA
2013-11-29 4:58 ` Yongqiang Yang
2013-11-29 8:00 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524214222.GF26055@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=marco.stornelli@gmail.com \
--cc=sandeen@redhat.com \
--cc=surbhi.palande@canonical.com \
--cc=toshi.okajima@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.