* [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-24 9:51 ` Nicolas Ferre
0 siblings, 0 replies; 11+ messages in thread
From: Nicolas Ferre @ 2011-05-24 9:51 UTC (permalink / raw)
To: broonie, linux-arm-kernel, alsa-devel; +Cc: linux-kernel, Nicolas Ferre
at91sam9g20 is providing master clock to wm8731: not using a crystal but an
external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
we do not need oscillator to be powered.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
sound/soc/atmel/sam9g20_wm8731.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 28afbbf..95572d2 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
"at91sam9g20ek_wm8731 "
": at91sam9g20ek_wm8731_init() called\n");
- ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
+ ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
MCLK_RATE, SND_SOC_CLOCK_IN);
if (ret < 0) {
printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
--
1.7.3
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-24 9:51 ` Nicolas Ferre
0 siblings, 0 replies; 11+ messages in thread
From: Nicolas Ferre @ 2011-05-24 9:51 UTC (permalink / raw)
To: linux-arm-kernel
at91sam9g20 is providing master clock to wm8731: not using a crystal but an
external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
we do not need oscillator to be powered.
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
sound/soc/atmel/sam9g20_wm8731.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 28afbbf..95572d2 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
"at91sam9g20ek_wm8731 "
": at91sam9g20ek_wm8731_init() called\n");
- ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
+ ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
MCLK_RATE, SND_SOC_CLOCK_IN);
if (ret < 0) {
printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
--
1.7.3
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
2011-05-24 9:51 ` Nicolas Ferre
(?)
@ 2011-05-25 11:15 ` Mark Brown
-1 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 11:15 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: linux-arm-kernel, alsa-devel, linux-kernel, lrg
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Adding Liam.
> ---
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 28afbbf..95572d2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
> "at91sam9g20ek_wm8731 "
> ": at91sam9g20ek_wm8731_init() called\n");
>
> - ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
> + ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
> MCLK_RATE, SND_SOC_CLOCK_IN);
> if (ret < 0) {
> printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
> --
> 1.7.3
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 11:15 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 11:15 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: alsa-devel, linux-kernel, linux-arm-kernel, lrg
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Adding Liam.
> ---
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 28afbbf..95572d2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
> "at91sam9g20ek_wm8731 "
> ": at91sam9g20ek_wm8731_init() called\n");
>
> - ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
> + ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
> MCLK_RATE, SND_SOC_CLOCK_IN);
> if (ret < 0) {
> printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
> --
> 1.7.3
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 11:15 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 11:15 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Adding Liam.
> ---
> sound/soc/atmel/sam9g20_wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 28afbbf..95572d2 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -146,7 +146,7 @@ static int at91sam9g20ek_wm8731_init(struct snd_soc_pcm_runtime *rtd)
> "at91sam9g20ek_wm8731 "
> ": at91sam9g20ek_wm8731_init() called\n");
>
> - ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL,
> + ret = snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_MCLK,
> MCLK_RATE, SND_SOC_CLOCK_IN);
> if (ret < 0) {
> printk(KERN_ERR "Failed to set WM8731 SYSCLK: %d\n", ret);
> --
> 1.7.3
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
2011-05-25 11:15 ` Mark Brown
(?)
@ 2011-05-25 12:21 ` Liam Girdwood
-1 siblings, 0 replies; 11+ messages in thread
From: Liam Girdwood @ 2011-05-25 12:21 UTC (permalink / raw)
To: Mark Brown; +Cc: Nicolas Ferre, linux-arm-kernel, alsa-devel, linux-kernel
On 25/05/11 12:15, Mark Brown wrote:
> On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
>> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
>> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
>> we do not need oscillator to be powered.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Adding Liam.
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 12:21 ` Liam Girdwood
0 siblings, 0 replies; 11+ messages in thread
From: Liam Girdwood @ 2011-05-25 12:21 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, Nicolas Ferre, linux-kernel, linux-arm-kernel
On 25/05/11 12:15, Mark Brown wrote:
> On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
>> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
>> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
>> we do not need oscillator to be powered.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Adding Liam.
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 12:21 ` Liam Girdwood
0 siblings, 0 replies; 11+ messages in thread
From: Liam Girdwood @ 2011-05-25 12:21 UTC (permalink / raw)
To: linux-arm-kernel
On 25/05/11 12:15, Mark Brown wrote:
> On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
>> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
>> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
>> we do not need oscillator to be powered.
>>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>
> Adding Liam.
>
Acked-by: Liam Girdwood <lrg@ti.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
2011-05-24 9:51 ` Nicolas Ferre
(?)
@ 2011-05-25 15:01 ` Mark Brown
-1 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 15:01 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: linux-arm-kernel, alsa-devel, linux-kernel
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 15:01 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 15:01 UTC (permalink / raw)
To: Nicolas Ferre; +Cc: alsa-devel, linux-kernel, linux-arm-kernel
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value
@ 2011-05-25 15:01 ` Mark Brown
0 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2011-05-25 15:01 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 24, 2011 at 11:51:16AM +0200, Nicolas Ferre wrote:
> at91sam9g20 is providing master clock to wm8731: not using a crystal but an
> external MCLK. We can avoid conflict and save power using WM8731_SYSCLK_MCLK as
> we do not need oscillator to be powered.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-05-25 15:01 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-24 9:51 [PATCH] ASoc: sam9g20_wm8731: use the proper SYSCKL value Nicolas Ferre
2011-05-24 9:51 ` Nicolas Ferre
2011-05-25 11:15 ` Mark Brown
2011-05-25 11:15 ` Mark Brown
2011-05-25 11:15 ` Mark Brown
2011-05-25 12:21 ` Liam Girdwood
2011-05-25 12:21 ` Liam Girdwood
2011-05-25 12:21 ` Liam Girdwood
2011-05-25 15:01 ` Mark Brown
2011-05-25 15:01 ` Mark Brown
2011-05-25 15:01 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.