All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: rts_pstor: use bitwise operator instead of logical one
@ 2011-05-25  0:03 Nicolas Kaiser
  2011-05-25 18:37 ` Peter Hüwe
  0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Kaiser @ 2011-05-25  0:03 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Wei Wang, devel, linux-kernel

Looks like a typo?

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
 drivers/staging/rts_pstor/sd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
index bddb031..cdae497 100644
--- a/drivers/staging/rts_pstor/sd.c
+++ b/drivers/staging/rts_pstor/sd.c
@@ -2328,7 +2328,7 @@ Switch_Fail:
 
 			retval = sd_send_cmd_get_rsp(chip, IO_SEND_OP_COND, 0, SD_RSP_TYPE_R4, rsp, 5);
 			if (retval == STATUS_SUCCESS) {
-				int func_num = (rsp[1] >> 4) && 0x07;
+				int func_num = (rsp[1] >> 4) & 0x07;
 				if (func_num) {
 					RTSX_DEBUGP("SD_IO card (Function number: %d)!\n", func_num);
 					chip->sd_io = 1;
-- 
1.7.5.rc3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rts_pstor: use bitwise operator instead of logical one
  2011-05-25  0:03 [PATCH] staging: rts_pstor: use bitwise operator instead of logical one Nicolas Kaiser
@ 2011-05-25 18:37 ` Peter Hüwe
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Hüwe @ 2011-05-25 18:37 UTC (permalink / raw)
  To: devel; +Cc: Nicolas Kaiser, Greg Kroah-Hartman, devel, linux-kernel

Am Mittwoch 25 Mai 2011, 02:03:02 schrieb Nicolas Kaiser:
> Looks like a typo?
> 
> Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
I think so, too.

Reviewed-by: Peter Huewe <peterhuewe@gmx.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-25 18:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-25  0:03 [PATCH] staging: rts_pstor: use bitwise operator instead of logical one Nicolas Kaiser
2011-05-25 18:37 ` Peter Hüwe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.