All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Sangbeom Kim <sbkim73@samsung.com>
Subject: Re: [PATCH 2/2] ARM: S5P: Add 64bit PWM timer counter for sched_clock
Date: Sat, 28 May 2011 08:17:10 +0100	[thread overview]
Message-ID: <20110528071710.GU24876@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1306534210-32659-2-git-send-email-kgene.kim@samsung.com>

On Fri, May 27, 2011 at 03:10:10PM -0700, Kukjin Kim wrote:
> From: Sangbeom Kim <sbkim73@samsung.com>
> 
> Basically, PWM timer works with 33Mhz on S5P SoCs and counter
> overflow every 128 secs. So it is needed 64-bit counter for
> supporting proper sched_clock() by 32-bit timer. This patch
> handle overflow control and can solve the problem of suspend
> to resume

NAK.

This patch is a backwards step, and adds a hell of a lot of complexity
which should already be dealt with in generic code.

What is "problem of suspend to resume" exactly?

WARNING: multiple messages have this Message-ID (diff)
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: S5P: Add 64bit PWM timer counter for sched_clock
Date: Sat, 28 May 2011 08:17:10 +0100	[thread overview]
Message-ID: <20110528071710.GU24876@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1306534210-32659-2-git-send-email-kgene.kim@samsung.com>

On Fri, May 27, 2011 at 03:10:10PM -0700, Kukjin Kim wrote:
> From: Sangbeom Kim <sbkim73@samsung.com>
> 
> Basically, PWM timer works with 33Mhz on S5P SoCs and counter
> overflow every 128 secs. So it is needed 64-bit counter for
> supporting proper sched_clock() by 32-bit timer. This patch
> handle overflow control and can solve the problem of suspend
> to resume

NAK.

This patch is a backwards step, and adds a hell of a lot of complexity
which should already be dealt with in generic code.

What is "problem of suspend to resume" exactly?

  reply	other threads:[~2011-05-28  7:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 22:10 [PATCH 1/2] ARM: S5P: Cleanup s5p-time for HRTimer Kukjin Kim
2011-05-27 22:10 ` Kukjin Kim
2011-05-27 22:10 ` [PATCH 2/2] ARM: S5P: Add 64bit PWM timer counter for sched_clock Kukjin Kim
2011-05-27 22:10   ` Kukjin Kim
2011-05-28  7:17   ` Russell King - ARM Linux [this message]
2011-05-28  7:17     ` Russell King - ARM Linux
2011-05-30  1:45     ` Kukjin Kim
2011-05-30  1:45       ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110528071710.GU24876@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.